Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Avoid using needsPaymentMethod in CheckoutComplete step - #7140
Merged
panteliselef merged 2 commits intoNov 4, 2025
Conversation
🦋 Changeset detectedLatest commit: 2eb46fd The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughA patch for Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant User
participant CheckoutComplete
participant Renderer
User->>CheckoutComplete: opens success screen (props: totals, freeTrialEndsAt, paymentMethod)
Note right of CheckoutComplete: Decision based on<br/>totals.totalDueNow.amount > 0<br/>or freeTrialEndsAt !== null
alt totalDueNow > 0 or freeTrialEndsAt set
CheckoutComplete->>Renderer: render "payment/subscription success" title & description
CheckoutComplete->>Renderer: render payment method details (if applicable)
else totalDueNow == 0 and no trial end
CheckoutComplete->>Renderer: render "no-payment success" title & description
end
Renderer->>User: display appropriate success UI
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Comment |
@clerk/agent-toolkit@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/elements@clerk/clerk-expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/clerk-react@clerk/react-router@clerk/remix@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/themes@clerk/types@clerk/upgrade@clerk/vuecommit: |
tmilewski
approved these changes
Nov 4, 2025
wobsoriano
approved these changes
Nov 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
panteliselef
deleted the
elef/bill-1395-on-checkoutcomplete-depend-on-amount-to-display-success
branch
November 4, 2025 15:57
wobsoriano pushed a commit
that referenced
this pull request
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Bug Fixes
Chores