Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
a28fa4d
feat(clerk-js): Lazy query client
panteliselef Sep 10, 2025
a3ad75c
wip
panteliselef Sep 19, 2025
e6d6561
update lock file
panteliselef Oct 3, 2025
82901ad
wip
panteliselef Oct 3, 2025
f5c27e3
feat(shared): `useSubscription` variant with React Query
panteliselef Oct 3, 2025
827f536
cleanup
panteliselef Oct 3, 2025
96b68d2
bundlewatch and changeset
panteliselef Oct 3, 2025
c07fe17
fix lint
panteliselef Oct 3, 2025
7fc1248
wip
panteliselef Oct 3, 2025
7f5cb97
Revert "wip"
panteliselef Oct 14, 2025
6da5615
handle init state
panteliselef Oct 14, 2025
992eda8
add support for infinite
panteliselef Oct 14, 2025
f9b7f64
wip some a few test continue to fail
panteliselef Oct 14, 2025
f8bee5d
mock queryClient
panteliselef Oct 14, 2025
eeae1c5
Merge branch 'refs/heads/main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 4, 2025
73e9101
fix conflicts about `usePagesOrInfinite.swr`
panteliselef Nov 4, 2025
751dd31
temp changeset
panteliselef Nov 4, 2025
582f018
allow unit tests to run with rq variant
panteliselef Nov 4, 2025
47f6649
run `useSubscription` tests locally for RQ variant
panteliselef Nov 4, 2025
fad9ac7
wip
panteliselef Nov 5, 2025
83a1a06
Revert "wip"
panteliselef Nov 5, 2025
7883fb3
fix(shared): Avoid revalidating first page on infinite pagination
panteliselef Nov 5, 2025
5ee3992
wip
panteliselef Nov 5, 2025
8e39385
Revert "wip"
panteliselef Nov 5, 2025
9ff7e2a
address skipped tests
panteliselef Nov 5, 2025
9e7d21d
typos
panteliselef Nov 5, 2025
4a68a52
wip
panteliselef Nov 5, 2025
f7a21ac
fix usePlans
panteliselef Nov 5, 2025
b8ea10d
wip
panteliselef Nov 5, 2025
57cb706
wip
panteliselef Nov 5, 2025
631e5e5
wip
panteliselef Nov 5, 2025
a732df6
all pass
panteliselef Nov 5, 2025
2d3c550
fix swr not passing params in infinite mode
panteliselef Nov 5, 2025
1b4c7f0
improve flakiness
panteliselef Nov 5, 2025
8d90888
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 5, 2025
6f27804
improve flakiness
panteliselef Nov 5, 2025
a9df03b
improve mocks
panteliselef Nov 5, 2025
35f4e83
update CI to include RQ variants
panteliselef Nov 5, 2025
0ffffa2
Merge branch 'main' into elef/replace-swr-with-rq-infinite
panteliselef Nov 10, 2025
031083c
cleanup
panteliselef Nov 10, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-keys-smell.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': patch
---

Build internal variants of all paginated hooks that use React Query instead of SWR.
64 changes: 53 additions & 11 deletions .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,7 +191,7 @@ jobs:
unit-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Unit Tests
name: Unit Tests (${{ matrix.node-version }}, ${{ matrix.filter-label }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand All@@ -205,11 +205,17 @@ jobs:
TURBO_SUMMARIZE: false

strategy:
fail-fast: true
fail-fast: false
matrix:
include:
- node-version: 22
test-filter: "**"
clerk-use-rq: "false"
filter-label: "**"
- node-version: 22
test-filter: "--filter=@clerk/shared --filter=@clerk/clerk-js"
clerk-use-rq: "true"
filter-label: "shared, clerk-js"
Comment thread
panteliselef marked this conversation as resolved.

steps:
- name: Checkout Repo
Expand All@@ -229,22 +235,35 @@ jobs:
turbo-team: ${{ vars.TURBO_TEAM }}
turbo-token: ${{ secrets.TURBO_TOKEN }}

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Run tests in packages
run: |
if [ "${{ matrix.test-filter }}" = "**" ]; then
echo "Running full test suite on Node ${{ matrix.node-version }}."
echo "Running full test suite on Node ${{ matrix.node-version }}"
pnpm turbo test $TURBO_ARGS
else
echo "Running LTS subset on Node ${{ matrix.node-version }}."
echo "Running tests: ${{ matrix.filter-label }}"
pnpm turbo test $TURBO_ARGS ${{ matrix.test-filter }}
fi
env:
NODE_VERSION: ${{ matrix.node-version }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}

- name: Run Typedoc tests
run: |
# Only run Typedoc tests for one matrix version
if [ "${{ matrix.node-version }}" == "22" ]; then
# Only run Typedoc tests for one matrix version and main test run
if [ "${{ matrix.node-version }}" == "22" ] && [ "${{ matrix.test-filter }}" = "**" ]; then
pnpm test:typedoc
fi
env:
Expand All@@ -255,14 +274,14 @@ jobs:
if: ${{ env.TURBO_SUMMARIZE == 'true' }}
continue-on-error: true
with:
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}
name: turbo-summary-report-unit-${{ github.run_id }}-${{ github.run_attempt }}-node-${{ matrix.node-version }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: .turbo/runs
retention-days: 5

integration-tests:
needs: [check-permissions, build-packages]
if: ${{ github.event_name != 'pull_request' || github.event.pull_request.draft == false }}
name: Integration Tests
name: Integration Tests (${{ matrix.test-name }}, ${{ matrix.test-project }}${{ matrix.next-version && format(', {0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && ', RQ' || '' }})
permissions:
contents: read
actions: write # needed for actions/upload-artifact
Expand DownExpand Up@@ -291,18 +310,28 @@ jobs:
'vue',
'nuxt',
'react-router',
'billing',
'machine',
'custom',
]
test-project: ["chrome"]
include:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'false'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '15'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '16'
Expand DownExpand Up@@ -360,12 +389,24 @@ jobs:
echo "affected=${AFFECTED}"
echo "affected=${AFFECTED}" >> $GITHUB_OUTPUT

- name: Rebuild @clerk/shared with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared --force
env:
CLERK_USE_RQ: true

- name: Rebuild dependent packages with CLERK_USE_RQ=true
if: ${{ steps.task-status.outputs.affected == '1' && matrix.clerk-use-rq == 'true' }}
run: pnpm turbo build $TURBO_ARGS --filter=@clerk/shared^... --force
env:
CLERK_USE_RQ: true

- name: Verdaccio
if: ${{ steps.task-status.outputs.affected == '1' }}
uses: ./.github/actions/verdaccio
with:
publish-cmd: |
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi
if [ "$(pnpm config get registry)" = "https://registry.npmjs.org/" ]; then echo 'Error: Using default registry' && exit 1; else CLERK_USE_RQ=${{ matrix.clerk-use-rq }} pnpm turbo build $TURBO_ARGS --only && pnpm changeset publish --no-git-tag; fi

- name: Edit .npmrc [link-workspace-packages=false]
run: sed -i -E 's/link-workspace-packages=(deep|true)/link-workspace-packages=false/' .npmrc
Expand DownExpand Up@@ -425,6 +466,7 @@ jobs:
E2E_NEXTJS_VERSION: ${{ matrix.next-version }}
E2E_PROJECT: ${{ matrix.test-project }}
E2E_CLERK_ENCRYPTION_KEY: ${{ matrix.clerk-encryption-key }}
CLERK_USE_RQ: ${{ matrix.clerk-use-rq }}
INTEGRATION_INSTANCE_KEYS: ${{ secrets.INTEGRATION_INSTANCE_KEYS }}
MAILSAC_API_KEY: ${{ secrets.MAILSAC_API_KEY }}
NODE_EXTRA_CA_CERTS: ${{ github.workspace }}/integration/certs/rootCA.pem
Expand All@@ -433,7 +475,7 @@ jobs:
if: ${{ cancelled() || failure() }}
uses: actions/upload-artifact@v4
with:
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}
name: playwright-traces-${{ github.run_id }}-${{ github.run_attempt }}-${{ matrix.test-name }}${{ matrix.next-version && format('-next{0}', matrix.next-version) || '' }}${{ matrix.clerk-use-rq == 'true' && '-rq' || '' }}
path: integration/test-results
retention-days: 1

Expand Down
22 changes: 22 additions & 0 deletions packages/clerk-js/src/test/mock-helpers.ts
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
import type { ActiveSessionResource, LoadedClerk } from '@clerk/shared/types';
import { type Mocked, vi } from 'vitest';

import { QueryClient } from '../core/query-core';
import type { RouteContextValue } from '../ui/router';

type FunctionLike = (...args: any) => any;
Expand DownExpand Up@@ -45,6 +46,20 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
// Cast clerk to any to allow mocking properties
const clerkAny = clerk as any;

const defaultQueryClient = {
__tag: 'clerk-rq-client' as const,
client: new QueryClient({
defaultOptions: {
queries: {
retry: false,
// Setting staleTime to Infinity will not cause issues between tests as long as each test
// case has its own wrapper that initializes a Clerk instance with a new QueryClient.
staleTime: Infinity,
},
},
}),
};

mockMethodsOf(clerkAny);
if (clerkAny.client) {
mockMethodsOf(clerkAny.client.signIn);
Expand DownExpand Up@@ -76,6 +91,13 @@ export const mockClerkMethods = (clerk: LoadedClerk): DeepVitestMocked<LoadedCle
if (clerkAny.billing) {
mockMethodsOf(clerkAny.billing);
}

// Mock the __internal_queryClient getter property
Object.defineProperty(clerkAny, '__internal_queryClient', {
get: vi.fn(() => defaultQueryClient),
configurable: true,
});

mockProp(clerkAny, 'navigate');
mockProp(clerkAny, 'setActive');
mockProp(clerkAny, 'redirectWithAuth');
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -316,6 +316,12 @@ describe('Checkout', () => {
});

const freeTrialEndsAt = new Date('2025-08-19');

fixtures.clerk.user?.getPaymentMethods.mockResolvedValue({
data: [],
total_count: 0,
});

fixtures.clerk.billing.startCheckout.mockResolvedValue({
id: 'chk_trial_1',
status: 'needs_confirmation',
Expand DownExpand Up@@ -1033,13 +1039,18 @@ describe('Checkout', () => {
{ wrapper },
);

await waitFor(async () => {
await waitFor(() => {
expect(getByRole('heading', { name: 'Checkout' })).toBeVisible();
const addPaymentMethodButton = getByText('Add payment method');
expect(addPaymentMethodButton).toBeVisible();
await userEvent.click(addPaymentMethodButton);
});

const addPaymentMethodButton = await waitFor(() => {
const button = getByText('Add payment method');
expect(button).toBeVisible();
return button;
});

await userEvent.click(addPaymentMethodButton);

await waitFor(() => {
expect(getByRole('button', { name: 'Start free trial' })).toBeInTheDocument();
});
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -117,7 +117,7 @@ describe('OrganizationList', () => {
});
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [
createFakeUserOrganizationMembership({
Expand DownExpand Up@@ -156,7 +156,7 @@ describe('OrganizationList', () => {
}),
);

fixtures.clerk.user?.getOrganizationInvitations.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationInvitations.mockReturnValue(
Promise.resolve({
data: [invitation],
total_count: 1,
Expand DownExpand Up@@ -342,7 +342,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByText(/Personal account/i));

expect(fixtures.router.navigate).toHaveBeenCalledWith(`/user/test_user_id`);
Expand DownExpand Up@@ -376,7 +376,7 @@ describe('OrganizationList', () => {
},
});

fixtures.clerk.user?.getOrganizationMemberships.mockReturnValueOnce(
fixtures.clerk.user?.getOrganizationMemberships.mockReturnValue(
Promise.resolve({
data: [membership],
total_count: 1,
Expand All@@ -392,7 +392,7 @@ describe('OrganizationList', () => {
});

await waitFor(async () => {
fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await userEvent.click(getByRole('button', { name: /Org1/i }));
expect(fixtures.clerk.setActive).toHaveBeenCalledWith(
expect.objectContaining({
Expand DownExpand Up@@ -423,7 +423,7 @@ describe('OrganizationList', () => {
wrapper,
});

fixtures.clerk.setActive.mockReturnValueOnce(Promise.resolve());
fixtures.clerk.setActive.mockReturnValue(Promise.resolve());
await waitFor(async () =>
expect(await findByRole('menuitem', { name: 'Create organization' })).toBeInTheDocument(),
);
Expand Down
Loading
Loading