Uh oh!
There was an error while loading. Please reload this page.
fix(clerk-js): Type method returns with ClerkError - #7213
Merged
Conversation
🦋 Changeset detectedLatest commit: f9ad025 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
WalkthroughTightens error typing and error handling in authentication resources: replaces Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant SignIn as SignInFuture
participant Runner as runAsyncResourceTask
participant API as Backend
Note over Client,SignIn: Old flow (simplified)
Client->>SignIn: finalize(params?)
SignIn->>Runner: run task (no pre-check)
Runner->>API: finalize request
API-->>Runner: response
Runner-->>SignIn: result / error
SignIn-->>Client: returns result (no forced reload)
Note over Client,SignIn: New flow (high-level, changed interactions)
Client->>SignIn: finalize(params?)
SignIn-->>SignIn: preflight check (e.g., createdSessionId) %%#lightblue
alt preflight fails
SignIn-->>Client: returns { error: ClerkRuntimeError } %%#ffdddd
else preflight ok
SignIn->>Runner: run task
Runner->>API: finalize request
API-->>Runner: response
Runner-->>SignIn: { result / error: ClerkError | null }
SignIn-->>Client: returns result
SignIn-->>Client: trigger client.reload() after success %%#ddffdd
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
@clerk/agent-toolkit@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/elements@clerk/clerk-expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/clerk-react@clerk/react-router@clerk/remix@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/themes@clerk/types@clerk/upgrade@clerk/vuecommit: |
alexcarpenter
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the
Promise<{ error: unknown }>return type for the newSignInandSignUpAPIs withPromise<{ error: ClerkError | null }>.It also updates some of the errors used by
SignInFutureto useClerkRuntimeErrorand otherClerkError-based errors where appropriate.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
New Features
Bug Fixes