Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .changeset/young-impalas-grab.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
---
'@clerk/shared': patch
---

Relaxing requirements for RQ variant hooks to enable revalidation across different configurations of the same hook.

```tsx

const { revalidate } = useStatements({ initialPage: 1, pageSize: 10 });
useStatements({ initialPage: 1, pageSize: 12 });

// revalidate from first hook, now invalidates the second hook.
void revalidate();
```
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { renderHook, waitFor } from '@testing-library/react';
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import type { ClerkResource } from '../../../types';
Expand DownExpand Up@@ -486,4 +486,66 @@ describe('createBillingPaginatedHook', () => {
expect(result.current.pageCount).toBe(5);
});
});

describe('revalidate behavior', () => {
it('revalidate fetches fresh data for authenticated hook', async () => {
fetcherMock
.mockResolvedValueOnce({
data: [{ id: 'initial-1' } as DummyResource, { id: 'initial-2' } as DummyResource],
total_count: 2,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' } as DummyResource, { id: 'refetched-2' } as DummyResource],
total_count: 2,
});

const { result } = renderHook(() => useDummyAuth({ initialPage: 1, pageSize: 2 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }, { id: 'initial-2' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }, { id: 'refetched-2' }]));
expect(fetcherMock).toHaveBeenCalledTimes(2);
});

it('revalidate propagates to infinite counterpart only for React Query', async () => {
let seq = 0;
fetcherMock.mockImplementation(async (params: DummyParams) => {
seq++;
return {
data: Array.from({ length: params.pageSize ?? 2 }, (_, i) => ({
id: `item-${params.initialPage ?? 1}-${seq}-${i}`,
})) as DummyResource[],
total_count: 10,
};
});

const useBoth = () => {
const paginated = useDummyAuth({ initialPage: 1, pageSize: 2 });
const infinite = useDummyAuth({ initialPage: 1, pageSize: 2, infinite: true } as any);
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcherMock.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcherMock.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcherMock).toHaveBeenCalledTimes(1));
}
});
});
});
213 changes: 213 additions & 0 deletions packages/shared/src/react/hooks/__tests__/useAPIKeys.spec.tsx
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,213 @@
import { act, renderHook, waitFor } from '@testing-library/react';
import { beforeEach, describe, expect, it, vi } from 'vitest';

import { useAPIKeys } from '../useAPIKeys';
import { createMockClerk, createMockQueryClient } from './mocks/clerk';
import { wrapper } from './wrapper';

const getAllSpy = vi.fn(
async () =>
({
data: [],
total_count: 0,
}) as { data: Array<Record<string, unknown>>; total_count: number },
);

const defaultQueryClient = createMockQueryClient();

const mockClerk = createMockClerk({
apiKeys: {
getAll: getAllSpy,
},
queryClient: defaultQueryClient,
});

vi.mock('../../contexts', () => {
return {
useAssertWrappedByClerkProvider: () => {},
useClerkInstanceContext: () => mockClerk,
};
});

describe('useApiKeys', () => {
beforeEach(() => {
vi.clearAllMocks();
defaultQueryClient.client.clear();
mockClerk.loaded = true;
mockClerk.user = { id: 'user_1' };
});

it('revalidate fetches fresh API keys', async () => {
getAllSpy
.mockResolvedValueOnce({
data: [{ id: 'key_initial' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'key_updated' }],
total_count: 1,
});

const { result } = renderHook(() => useAPIKeys({ subject: 'user_1', pageSize: 1 }), { wrapper });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'key_initial' }]);

await act(async () => {
await result.current.revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'key_updated' }]));
expect(getAllSpy).toHaveBeenCalledTimes(2);
});

it('cascades revalidation for related queries only when using React Query', async () => {
let sequence = 0;
getAllSpy.mockImplementation(async ({ initialPage }: { initialPage?: number } = {}) => {
sequence += 1;
const page = initialPage ?? 1;
return {
data: [{ id: `key-${page}-${sequence}` }],
total_count: 5,
};
});

const useBoth = () => {
const paginated = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const infinite = useAPIKeys({ subject: 'user_1', pageSize: 1, infinite: true });
return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(getAllSpy).toHaveBeenCalledTimes(1));
}
});

it('handles revalidation with different pageSize configurations', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ pageSize }: { pageSize?: number } = {}) => {
seq += 1;
return {
data: [{ id: `key-pageSize-${pageSize ?? 'unknown'}-${seq}` }],
total_count: 3,
};
});

const useHooks = () => {
const small = useAPIKeys({ subject: 'user_1', pageSize: 1 });
const large = useAPIKeys({ subject: 'user_1', pageSize: 5 });
return { small, large };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.small.isLoading).toBe(false));
await waitFor(() => expect(result.current.large.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.small.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('handles revalidation with different query filters', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ query }: { query?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-query-${query ?? 'empty'}-${seq}` }],
total_count: 2,
};
});

const useHooks = () => {
const defaultQuery = useAPIKeys({ subject: 'user_1', pageSize: 11, query: '' });
const filtered = useAPIKeys({ subject: 'user_1', pageSize: 11, query: 'search' });
return { defaultQuery, filtered };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.defaultQuery.isLoading).toBe(false));
await waitFor(() => expect(result.current.filtered.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.defaultQuery.revalidate();
});

const isRQ = Boolean((globalThis as any).__CLERK_USE_RQ__);

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

if (isRQ) {
await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
expect(getAllSpy).toHaveBeenCalledTimes(1);
}
});

it('does not cascade revalidation across different subjects', async () => {
let seq = 0;
getAllSpy.mockImplementation(async ({ subject }: { subject?: string } = {}) => {
seq += 1;
return {
data: [{ id: `key-subject-${subject ?? 'none'}-${seq}` }],
total_count: 4,
};
});

const useHooks = () => {
const primary = useAPIKeys({ subject: 'user_primary', pageSize: 1 });
const secondary = useAPIKeys({ subject: 'user_secondary', pageSize: 1 });
return { primary, secondary };
};

const { result } = renderHook(useHooks, { wrapper });

await waitFor(() => expect(result.current.primary.isLoading).toBe(false));
await waitFor(() => expect(result.current.secondary.isLoading).toBe(false));

getAllSpy.mockClear();

await act(async () => {
await result.current.primary.revalidate();
});

await waitFor(() => expect(getAllSpy.mock.calls.length).toBeGreaterThanOrEqual(1));

expect(getAllSpy).toHaveBeenCalledTimes(1);
const subjects = (getAllSpy.mock.calls as Array<unknown[]>).map(
call => (call[0] as { subject?: string } | undefined)?.subject,
);
expect(subjects).not.toContain('user_secondary');
expect(subjects[0] === undefined || subjects[0] === 'user_primary').toBe(true);
});
});
Original file line numberDiff line numberDiff line change
Expand Up@@ -503,6 +503,35 @@ describe('usePagesOrInfinite - behaviors mirrored from useCoreOrganization', ()
});

describe('usePagesOrInfinite - revalidate behavior', () => {
it('refetches current data when revalidate is invoked', async () => {
const fetcher = vi
.fn()
.mockResolvedValueOnce({
data: [{ id: 'initial-1' }],
total_count: 1,
})
.mockResolvedValueOnce({
data: [{ id: 'refetched-1' }],
total_count: 1,
});

const params = { initialPage: 1, pageSize: 1 };
const config = buildConfig(params);
const keys = buildKeys('t-revalidate-refresh', params);

const { result } = renderUsePagesOrInfinite({ fetcher, config, keys });

await waitFor(() => expect(result.current.isLoading).toBe(false));
expect(result.current.data).toEqual([{ id: 'initial-1' }]);

await act(async () => {
await (result.current as any).revalidate();
});

await waitFor(() => expect(result.current.data).toEqual([{ id: 'refetched-1' }]));
expect(fetcher).toHaveBeenCalledTimes(2);
});

it('pagination mode: isFetching toggles during revalidate, isLoading stays false after initial load', async () => {
const deferred = createDeferredPromise();
let callCount = 0;
Expand DownExpand Up@@ -652,6 +681,47 @@ describe('usePagesOrInfinite - revalidate behavior', () => {
{ id: 'p2-1-revalidate' },
]);
});

it('cascades revalidation to related queries only in React Query mode', async () => {
const params = { initialPage: 1, pageSize: 1 };
const keys = buildKeys('t-revalidate-cascade', params, { userId: 'user_123' });
const fetcher = vi.fn(async ({ initialPage }: any) => ({
data: [{ id: `item-${initialPage}-${fetcher.mock.calls.length}` }],
total_count: 3,
}));

const useBoth = () => {
const paginated = usePagesOrInfinite({
fetcher,
config: buildConfig(params),
keys,
});
const infinite = usePagesOrInfinite({
fetcher,
config: buildConfig(params, { infinite: true }),
keys,
});

return { paginated, infinite };
};

const { result } = renderHook(useBoth, { wrapper });

await waitFor(() => expect(result.current.paginated.isLoading).toBe(false));
await waitFor(() => expect(result.current.infinite.isLoading).toBe(false));

fetcher.mockClear();

await act(async () => {
await result.current.paginated.revalidate();
});

if (__CLERK_USE_RQ__) {
await waitFor(() => expect(fetcher.mock.calls.length).toBeGreaterThanOrEqual(2));
} else {
await waitFor(() => expect(fetcher).toHaveBeenCalledTimes(1));
}
});
});

describe('usePagesOrInfinite - error propagation', () => {
Expand Down
Loading
Loading