Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-clowns-dance.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/clerk-js': minor
---

Removes SWR as direct dependency
5 changes: 5 additions & 0 deletions .changeset/fuzzy-donuts-jam.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/shared': minor
---

Creates compatibility layer for SWR hooks that were previously inside `@clerk/clerk-js`
7 changes: 6 additions & 1 deletion .github/workflows/ci.yml
Original file line numberDiff line numberDiff line change
Expand Up@@ -310,7 +310,6 @@ jobs:
'vue',
'nuxt',
'react-router',
'machine',
'custom',
]
test-project: ["chrome"]
Expand All@@ -321,6 +320,12 @@ jobs:
- test-name: 'billing'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'false'
- test-name: 'machine'
test-project: 'chrome'
clerk-use-rq: 'true'
- test-name: 'nextjs'
test-project: 'chrome'
next-version: '14'
Expand Down
372 changes: 372 additions & 0 deletions integration/tests/machine-auth/component.test.ts

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions packages/clerk-js/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -82,8 +82,7 @@
"dequal": "2.0.3",
"input-otp": "1.4.2",
"qrcode.react": "4.2.0",
"regenerator-runtime": "0.14.1",
"swr": "2.3.4"
"regenerator-runtime": "0.14.1"
},
"devDependencies": {
"@clerk/testing": "workspace:^",
Expand Down
30 changes: 14 additions & 16 deletions packages/clerk-js/src/ui/components/APIKeys/APIKeys.tsx
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
import { isClerkAPIResponseError } from '@clerk/shared/error';
import { __experimental_useAPIKeys as useAPIKeys, useClerk, useOrganization, useUser } from '@clerk/shared/react';
import type { CreateAPIKeyParams } from '@clerk/shared/types';
import type { APIKeyResource } from '@clerk/shared/types';
import { lazy, useState } from 'react';
import useSWRMutation from 'swr/mutation';

import { useProtect } from '@/ui/common';
import { useAPIKeysContext, withCoreUserGuard } from '@/ui/contexts';
Expand DownExpand Up@@ -69,6 +68,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
fetchPage,
pageCount,
count: itemCount,
revalidate: invalidateAll,
} = useAPIKeys({
subject,
pageSize: perPage ?? API_KEYS_PAGE_SIZE,
Expand All@@ -77,12 +77,11 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
enabled: isOrg ? canReadAPIKeys : true,
});

const { invalidateAll } = useAPIKeysPagination({
useAPIKeysPagination({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
});

Expand All@@ -94,11 +93,9 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
};
const card = useCardState();
const clerk = useClerk();
const {
data: createdAPIKey,
trigger: createAPIKey,
isMutating,
} = useSWRMutation('api-keys-create', (_key, { arg }: { arg: CreateAPIKeyParams }) => clerk.apiKeys.create(arg));

const [apiKey, setAPIKey] = useState<APIKeyResource | null>(null);
Comment thread
panteliselef marked this conversation as resolved.

const { t } = useLocalizations();
const [isRevokeModalOpen, setIsRevokeModalOpen] = useState(false);
const [selectedAPIKeyID, setSelectedAPIKeyID] = useState('');
Expand All@@ -107,19 +104,23 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr

const handleCreateAPIKey = async (params: OnCreateParams) => {
try {
await createAPIKey({
card.setLoading();
const apiKey = await clerk.apiKeys.create({
...params,
subject,
});
invalidateAll();
card.setError(undefined);
setIsCopyModalOpen(true);
setAPIKey(apiKey);
} catch (err: any) {
if (isClerkAPIResponseError(err)) {
if (err.status === 409) {
card.setError('API Key name already exists');
}
}
} finally {
card.setIdle();
}
};

Expand DownExpand Up@@ -181,10 +182,7 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
<Action.Open value='add-api-key'>
<Flex sx={t => ({ paddingTop: t.space.$6, paddingBottom: t.space.$6 })}>
<Action.Card sx={{ width: '100%' }}>
<CreateAPIKeyForm
onCreate={handleCreateAPIKey}
isSubmitting={isMutating}
/>
<CreateAPIKeyForm onCreate={handleCreateAPIKey} />
</Action.Card>
</Flex>
</Action.Open>
Expand All@@ -193,8 +191,8 @@ export const APIKeysPage = ({ subject, perPage, revokeModalRoot }: APIKeysPagePr
isOpen={isCopyModalOpen}
onOpen={() => setIsCopyModalOpen(true)}
onClose={() => setIsCopyModalOpen(false)}
apiKeyName={createdAPIKey?.name ?? ''}
apiKeySecret={createdAPIKey?.secret ?? ''}
apiKeyName={apiKey?.name || ''}
apiKeySecret={apiKey?.secret || ''}
modalRoot={revokeModalRoot}
/>
</Action.Root>
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@ import React, { useMemo, useRef, useState } from 'react';
import { useAPIKeysContext } from '@/ui/contexts';
import { Box, Col, descriptors, FormLabel, localizationKeys, Text, useLocalizations } from '@/ui/customizables';
import { useActionContext } from '@/ui/elements/Action/ActionRoot';
import { useCardState } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtons } from '@/ui/elements/FormButtons';
import { FormContainer } from '@/ui/elements/FormContainer';
Expand All@@ -28,7 +29,6 @@ export type OnCreateParams = {

interface CreateAPIKeyFormProps {
onCreate: (params: OnCreateParams) => void;
isSubmitting: boolean;
}

const EXPIRATION_DURATIONS: Record<Exclude<Expiration, 'never'>, (date: Date) => void> = {
Expand DownExpand Up@@ -117,10 +117,11 @@ const ExpirationSelector: React.FC<ExpirationSelectorProps> = ({ selectedExpirat
);
};

export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, isSubmitting }) => {
export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate }) => {
const [selectedExpiration, setSelectedExpiration] = useState<ExpirationOption | null>(null);
const { close: closeCardFn } = useActionContext();
const { showDescription = false } = useAPIKeysContext();
const card = useCardState();
const { t } = useLocalizations();

const nameField = useFormControl('name', '', {
Expand DownExpand Up@@ -251,7 +252,7 @@ export const CreateAPIKeyForm: React.FC<CreateAPIKeyFormProps> = ({ onCreate, is
submitLabel={localizationKeys('apiKeys.formButtonPrimary__add')}
isDisabled={!canSubmit}
onReset={closeCardFn}
isLoading={isSubmitting}
isLoading={card.isLoading}
elementDescriptor={descriptors.apiKeysCreateFormSubmitButton}
/>
</Form.Root>
Expand Down
30 changes: 2 additions & 28 deletions packages/clerk-js/src/ui/components/APIKeys/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
import { useCallback, useEffect, useRef } from 'react';
import { useSWRConfig } from 'swr';
import { useEffect, useRef } from 'react';

type UseAPIKeysPaginationParams = {
query: string;
page: number;
pageCount: number;
isFetching: boolean;
subject: string;
fetchPage: (page: number) => void;
};

Expand All@@ -16,27 +14,7 @@ type UseAPIKeysPaginationParams = {
* - Adjusts page when current page exceeds available pages (e.g., after deletion)
* - Provides cache invalidation function for mutations
*/
export const useAPIKeysPagination = ({
query,
page,
pageCount,
isFetching,
subject,
fetchPage,
}: UseAPIKeysPaginationParams) => {
const { mutate } = useSWRConfig();

// Invalidate all cache entries for this user or organization
const invalidateAll = useCallback(() => {
void mutate(key => {
if (!key || typeof key !== 'object') {
return false;
}
// Match all apiKeys cache entries for this user or organization, regardless of page, pageSize, or query
return 'type' in key && key.type === 'apiKeys' && 'subject' in key && key.subject === subject;
});
}, [mutate, subject]);

export const useAPIKeysPagination = ({ query, page, pageCount, isFetching, fetchPage }: UseAPIKeysPaginationParams) => {
// Reset to first page when query changes
const previousQueryRef = useRef(query);
useEffect(() => {
Expand All@@ -53,8 +31,4 @@ export const useAPIKeysPagination = ({
fetchPage(Math.max(1, pageCount));
}
}, [pageCount, page, isFetching, fetchPage]);

return {
invalidateAll,
};
};
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import { __internal_usePaymentAttemptQuery } from '@clerk/shared/react/index';
import type { BillingSubscriptionItemResource } from '@clerk/shared/types';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand DownExpand Up@@ -31,28 +30,17 @@ export const PaymentAttemptPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: paymentAttempt,
isLoading,
error,
} = useSWR(
params.paymentAttemptId
? {
type: 'payment-attempt',
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getPaymentAttempt({
id: params.paymentAttemptId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_usePaymentAttemptQuery({
paymentAttemptId: params.paymentAttemptId,
for: requesterType,
enabled: Boolean(params.paymentAttemptId),
});

const subscriptionItem = paymentAttempt?.subscriptionItem;

Expand Down
20 changes: 6 additions & 14 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
import { useClerk } from '@clerk/shared/react';
import { __internal_usePlanDetailsQuery } from '@clerk/shared/react/index';
import type {
__internal_PlanDetailsProps,
BillingPlanResource,
Expand All@@ -7,7 +7,6 @@ import type {
} from '@clerk/shared/types';
import * as React from 'react';
import { useMemo, useState } from 'react';
import useSWR from 'swr';

import { Alert } from '@/ui/elements/Alert';
import { Avatar } from '@/ui/elements/Avatar';
Expand DownExpand Up@@ -79,24 +78,17 @@ const PlanDetailsInternal = ({
plan: initialPlan,
initialPlanPeriod = 'month',
}: __internal_PlanDetailsProps) => {
const clerk = useClerk();
const [planPeriod, setPlanPeriod] = useState<BillingSubscriptionPlanPeriod>(initialPlanPeriod);

const {
data: plan,
isLoading,
error,
} = useSWR<BillingPlanResource, ClerkAPIResponseError>(
planId || initialPlan ? { type: 'plan', id: planId || initialPlan?.id } : null,
// @ts-expect-error we are handling it above
() => clerk.billing.getPlan({ id: planId || initialPlan?.id }),
{
fallbackData: initialPlan,
revalidateOnFocus: false,
shouldRetryOnError: false,
keepPreviousData: true,
},
);
} = __internal_usePlanDetailsQuery({
planId,
initialPlan,
enabled: Boolean(planId || initialPlan?.id),
});

if (isLoading && !initialPlan) {
return (
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,7 @@ describe('PlanDetails', () => {
it('displays spinner when loading with planId', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockImplementation(() => new Promise(() => {}));
Expand DownExpand Up@@ -118,6 +119,7 @@ describe('PlanDetails', () => {
it('fetches and renders plan details when planId is provided', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withUser({ email_addresses: ['test@clerk.com'] });
f.withBilling();
});

fixtures.clerk.billing.getPlan.mockResolvedValue(mockPlan);
Expand Down
26 changes: 7 additions & 19 deletions packages/clerk-js/src/ui/components/Statements/StatementPage.tsx
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
import { useClerk, useOrganizationContext } from '@clerk/shared/react';
import useSWR from 'swr';
import { __internal_useStatementQuery } from '@clerk/shared/react/index';

import { Alert } from '@/ui/elements/Alert';
import { Header } from '@/ui/elements/Header';
Expand All@@ -25,28 +24,17 @@ export const StatementPage = () => {
const subscriberType = useSubscriberTypeContext();
const localizationRoot = useSubscriberTypeLocalizationRoot();
const { t, translateError } = useLocalizations();
const clerk = useClerk();
// Do not use `useOrganization` to avoid triggering the in-app enable organizations prompt in development instance
const organizationCtx = useOrganizationContext();
const requesterType = subscriberType === 'organization' ? 'organization' : 'user';

const {
data: statement,
isLoading,
error,
} = useSWR(
params.statementId
? {
type: 'statement',
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}
: null,
() =>
clerk.billing.getStatement({
id: params.statementId,
orgId: subscriberType === 'organization' ? organizationCtx?.organization?.id : undefined,
}),
);
} = __internal_useStatementQuery({
statementId: params.statementId,
for: requesterType,
enabled: Boolean(params.statementId),
});

if (isLoading) {
return (
Expand Down
Loading
Loading