fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661

Merged
tmilewski merged 2 commits into
mainfrom
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged

fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

Conversation

@tmilewski

@tmilewskitmilewski commented Jan 23, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Port of Core 2 changes: #7646

Summary

  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur

Problem

When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:

  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata

  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata

Solution

  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.

  • Tests

    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.

  • Chores

    • Added a changeset entry for this update.

✏️ Tip: You can customize this high-level summary in your review settings.

@tmilewskitmilewski self-assigned this Jan 23, 2026
@changeset-bot

changeset-botBot commented Jan 23, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: de66595

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jan 23, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Jan 23, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595

@coderabbitai

coderabbitaiBot commented Jan 23, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.

Possibly related PRs

  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

jacekradko
jacekradko reviewed Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md Outdated
jacekradko
jacekradko approved these changes Jan 23, 2026
View reviewed changes

@jacekradkojacekradko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update

@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski merged commit 06a9b97 into mainJan 23, 2026
40 checks passed
@tmilewski
tmilewski deleted the tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer branch January 23, 2026 18:18
nikosdouvlis pushed a commit that referenced this pull request Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater mentioned this pull request May 31, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661
Merged
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged
fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 23, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Port of Core 2 changes: #7646
Summary
  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur
Problem
When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:
  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata
  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata
Solution
  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.
  • Tests
    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.
  • Chores
    • Added a changeset entry for this update.
✏️ Tip: You can customize this high-level summary in your review settings.
@tmilewskitmilewski
self-assigned this
Jan 23, 2026
@changeset-bot
changeset-botBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: de66595
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595
@coderabbitai
coderabbitaiBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.
Possibly related PRs
  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
jacekradko
jacekradko
reviewed
Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md
Outdated

jacekradko
jacekradko
approved these changes
Jan 23, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update
@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski
merged commit 06a9b97
into
mainJan 23, 2026

40 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

branch
January 23, 2026 18:18
nikosdouvlis pushed a commit
that referenced
this pull request
Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater
mentioned this pull request
May 31, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661
Merged
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged
fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 23, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Port of Core 2 changes: #7646
Summary
  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur
Problem
When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:
  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata
  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata
Solution
  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.
  • Tests
    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.
  • Chores
    • Added a changeset entry for this update.
✏️ Tip: You can customize this high-level summary in your review settings.
@tmilewskitmilewski
self-assigned this
Jan 23, 2026
@changeset-bot
changeset-botBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: de66595
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595
@coderabbitai
coderabbitaiBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.
Possibly related PRs
  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
jacekradko
jacekradko
reviewed
Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md
Outdated

jacekradko
jacekradko
approved these changes
Jan 23, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update
@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski
merged commit 06a9b97
into
mainJan 23, 2026

40 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

branch
January 23, 2026 18:18
nikosdouvlis pushed a commit
that referenced
this pull request
Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater
mentioned this pull request
May 31, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661
Merged
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged
fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 23, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Port of Core 2 changes: #7646
Summary
  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur
Problem
When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:
  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata
  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata
Solution
  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.
  • Tests
    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.
  • Chores
    • Added a changeset entry for this update.
✏️ Tip: You can customize this high-level summary in your review settings.
@tmilewskitmilewski
self-assigned this
Jan 23, 2026
@changeset-bot
changeset-botBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: de66595
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595
@coderabbitai
coderabbitaiBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.
Possibly related PRs
  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
jacekradko
jacekradko
reviewed
Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md
Outdated

jacekradko
jacekradko
approved these changes
Jan 23, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update
@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski
merged commit 06a9b97
into
mainJan 23, 2026

40 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

branch
January 23, 2026 18:18
nikosdouvlis pushed a commit
that referenced
this pull request
Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater
mentioned this pull request
May 31, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661
Merged
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged
fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 23, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Port of Core 2 changes: #7646
Summary
  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur
Problem
When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:
  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata
  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata
Solution
  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.
  • Tests
    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.
  • Chores
    • Added a changeset entry for this update.
✏️ Tip: You can customize this high-level summary in your review settings.
@tmilewskitmilewski
self-assigned this
Jan 23, 2026
@changeset-bot
changeset-botBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: de66595
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595
@coderabbitai
coderabbitaiBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.
Possibly related PRs
  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
jacekradko
jacekradko
reviewed
Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md
Outdated

jacekradko
jacekradko
approved these changes
Jan 23, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update
@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski
merged commit 06a9b97
into
mainJan 23, 2026

40 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

branch
January 23, 2026 18:18
nikosdouvlis pushed a commit
that referenced
this pull request
Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater
mentioned this pull request
May 31, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661
Merged
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged
fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 23, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Port of Core 2 changes: #7646
Summary
  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur
Problem
When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:
  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata
  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata
Solution
  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.
  • Tests
    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.
  • Chores
    • Added a changeset entry for this update.
✏️ Tip: You can customize this high-level summary in your review settings.
@tmilewskitmilewski
self-assigned this
Jan 23, 2026
@changeset-bot
changeset-botBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: de66595
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595
@coderabbitai
coderabbitaiBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.
Possibly related PRs
  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
jacekradko
jacekradko
reviewed
Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md
Outdated

jacekradko
jacekradko
approved these changes
Jan 23, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update
@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski
merged commit 06a9b97
into
mainJan 23, 2026

40 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

branch
January 23, 2026 18:18
nikosdouvlis pushed a commit
that referenced
this pull request
Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater
mentioned this pull request
May 31, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661
Merged
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged
fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 23, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Port of Core 2 changes: #7646
Summary
  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur
Problem
When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:
  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata
  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata
Solution
  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.
  • Tests
    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.
  • Chores
    • Added a changeset entry for this update.
✏️ Tip: You can customize this high-level summary in your review settings.
@tmilewskitmilewski
self-assigned this
Jan 23, 2026
@changeset-bot
changeset-botBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: de66595
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595
@coderabbitai
coderabbitaiBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.
Possibly related PRs
  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
jacekradko
jacekradko
reviewed
Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md
Outdated

jacekradko
jacekradko
approved these changes
Jan 23, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update
@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski
merged commit 06a9b97
into
mainJan 23, 2026

40 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

branch
January 23, 2026 18:18
nikosdouvlis pushed a commit
that referenced
this pull request
Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater
mentioned this pull request
May 31, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(js,ui,shared): Handle unsafeMetadata in transfer flows - #7661
Merged
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Jan 23, 2026
Merged
fix(js,ui,shared): Handle unsafeMetadata in transfer flows#7661
tmilewski merged 2 commits into
mainfrom 
tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer
Conversation
@tmilewski
@tmilewskitmilewski
commented
Jan 23, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Port of Core 2 changes: #7646
Summary
  • Fixes unsafeMetadata being lost when users are transferred between sign-in and sign-up flows during OAuth/SSO authentication
  • Adds unsafeMetadata to HandleOAuthCallbackParams type and propagates it through transfer flows
  • Ensures metadata provided to <SignIn> or <SignUp> components is preserved when OAuth transfers occur
Problem
When unsafeMetadata is passed to <SignIn unsafeMetadata={{ foo: 'bar' }} /> or <SignUp unsafeMetadata={{ foo: 'bar' }} />, the metadata was lost in two scenarios:
  1. OAuth/SSO Callback Transfer: When a user signs in via OAuth but no account exists, the system transfers to sign-up by calling signUp.create({ transfer: true }) without passing unsafeMetadata
  2. Combined Flow Transfer: When the combined sign-in/sign-up flow detects a non-existent identifier and transfers to sign-up, signUp.create() was called without unsafeMetadata
Solution
  • Added unsafeMetadata field to HandleOAuthCallbackParams type
  • Pass unsafeMetadata from params to signUp.create() during OAuth transfer in clerk.ts
  • Added unsafeMetadata to HandleCombinedFlowTransferProps and pass it to signUp.create() in handleCombinedFlowTransfer.ts
  • Pass unsafeMetadata from context to SSO callback components in both SignIn and SignUp routes
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Propagates additional sign-up metadata (unsafeMetadata) through OAuth/combined-flow transfers and sign-in/sign-up callbacks.
  • Tests
    • Added tests verifying unsafeMetadata is passed through (including explicit undefined handling) during transfer flows.
  • Chores
    • Added a changeset entry for this update.
✏️ Tip: You can customize this high-level summary in your review settings.
@tmilewskitmilewski
self-assigned this
Jan 23, 2026
@changeset-bot
changeset-botBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: de66595
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentReviewUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJan 23, 2026 6:02pm
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7661

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7661

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7661

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7661

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7661

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7661

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7661

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7661

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7661

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7661

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7661

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7661

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7661

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7661

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7661

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7661

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7661

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7661

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7661

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7661

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7661

commit: de66595
@coderabbitai
coderabbitaiBot
commented
Jan 23, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
This PR propagates an optional unsafeMetadata field through OAuth transfer and combined sign-up flows. Changes: add unsafeMetadata?: SignUpUnsafeMetadata to HandleOAuthCallbackParams; include unsafeMetadata when calling signUp.create in clerk-js and in the combined-flow transfer handler; pass unsafeMetadata through relevant UI components and callbacks; add tests asserting unsafeMetadata is forwarded to signUp.create. A new changeset file with two YAML document separators (---) was added under .changeset.
Possibly related PRs
  • clerk/javascript PR 7647: Makes the same code-level changes to propagate unsafeMetadata through HandleOAuthCallbackParams, combined-flow transfer props, signUp.create invocations, and test expectations.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding support for unsafeMetadata during transfer flows across js, ui, and shared packages.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
jacekradko
jacekradko
reviewed
Jan 23, 2026
View reviewed changes
Comment thread.changeset/stale-gifts-jog.md
Outdated

jacekradko
jacekradko
approved these changes
Jan 23, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a changeset update
@tmilewski@jacekradko
Remove changeset entry
de66595
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tmilewski
tmilewski
merged commit 06a9b97
into
mainJan 23, 2026

40 checks passed

@tmilewski
tmilewski
deleted the

tom/user-4473-fix-unsafemetadata-issues-in-core-3-transfer

branch
January 23, 2026 18:18
nikosdouvlis pushed a commit
that referenced
this pull request
Jan 27, 2026
@tmilewski@jacekradko@nikosdouvlis
fix(js,ui,shared): HandleunsafeMetadataintransferflows (#7661)
1f37e8e
Co-authored-by: Jacek Radko <jacek@clerk.dev>
@tylerstillwatertylerstillwater
mentioned this pull request
May 31, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmilewskitmilewski

Labels

clerk-jscore-3

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@tmilewski@jacekradko