Skip to content

fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808

Merged
wobsoriano merged 11 commits into
mainfrom
rob/fix-keyless-e2e
Feb 10, 2026
Merged

fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom
rob/fix-keyless-e2e

Conversation

@wobsoriano

@wobsorianowobsoriano commented Feb 9, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description

Updates integration tests to handle the new framework query parameter in keyless claim URLs.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes

    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.

  • Tests

    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.

  • Chores

    • Added a release changeset entry.

@changeset-bot

changeset-botBot commented Feb 9, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 31fc985

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Feb 9, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am

Request Review

@coderabbitai

coderabbitaiBot commented Feb 9, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Feb 9, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express

npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react

npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985

github-advanced-security[bot]
github-advanced-securityAI found potential problems Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts Fixed
Comment threadintegration/tests/tanstack-start/keyless.test.ts Fixed
@wobsorianowobsoriano changed the title chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano enabled auto-merge (squash) February 10, 2026 00:37
@wobsoriano
wobsoriano merged commit cd4403d into mainFeb 10, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/fix-keyless-e2e branch February 10, 2026 00:39
wobsoriano added a commit that referenced this pull request Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit that referenced this pull request Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit that referenced this pull request Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

core-3integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(repo): Handle framework query param in keyless claim URLs integration tests by wobsoriano · Pull Request #7808 · clerk/javascript · GitHub
Skip to content
fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Feb 10, 2026
Merged
fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Updates integration tests to handle the new framework query parameter in keyless claim URLs.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests
    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores
    • Added a release changeset entry.
@changeset-bot
changeset-botBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 31fc985
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am
Request Review
@coderabbitai
coderabbitaiBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts
Fixed

Comment threadintegration/tests/tanstack-start/keyless.test.ts
Fixed

@wobsorianowobsoriano
changed the title
chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano
enabled auto-merge (squash)
February 10, 2026 00:37
@wobsoriano
wobsoriano
merged commit cd4403d
into
mainFeb 10, 2026

43 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-keyless-e2e

branch
February 10, 2026 00:39
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

core-3integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(repo): Handle framework query param in keyless claim URLs integration tests by wobsoriano · Pull Request #7808 · clerk/javascript · GitHub
Skip to content
fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Feb 10, 2026
Merged
fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Updates integration tests to handle the new framework query parameter in keyless claim URLs.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests
    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores
    • Added a release changeset entry.
@changeset-bot
changeset-botBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 31fc985
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am
Request Review
@coderabbitai
coderabbitaiBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts
Fixed

Comment threadintegration/tests/tanstack-start/keyless.test.ts
Fixed

@wobsorianowobsoriano
changed the title
chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano
enabled auto-merge (squash)
February 10, 2026 00:37
@wobsoriano
wobsoriano
merged commit cd4403d
into
mainFeb 10, 2026

43 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-keyless-e2e

branch
February 10, 2026 00:39
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

core-3integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(repo): Handle framework query param in keyless claim URLs integration tests by wobsoriano · Pull Request #7808 · clerk/javascript · GitHub
Skip to content
fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Feb 10, 2026
Merged
fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Updates integration tests to handle the new framework query parameter in keyless claim URLs.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests
    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores
    • Added a release changeset entry.
@changeset-bot
changeset-botBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 31fc985
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am
Request Review
@coderabbitai
coderabbitaiBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts
Fixed

Comment threadintegration/tests/tanstack-start/keyless.test.ts
Fixed

@wobsorianowobsoriano
changed the title
chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano
enabled auto-merge (squash)
February 10, 2026 00:37
@wobsoriano
wobsoriano
merged commit cd4403d
into
mainFeb 10, 2026

43 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-keyless-e2e

branch
February 10, 2026 00:39
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

core-3integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(repo): Handle framework query param in keyless claim URLs integration tests by wobsoriano · Pull Request #7808 · clerk/javascript · GitHub
Skip to content
fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Feb 10, 2026
Merged
fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Updates integration tests to handle the new framework query parameter in keyless claim URLs.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests
    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores
    • Added a release changeset entry.
@changeset-bot
changeset-botBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 31fc985
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am
Request Review
@coderabbitai
coderabbitaiBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts
Fixed

Comment threadintegration/tests/tanstack-start/keyless.test.ts
Fixed

@wobsorianowobsoriano
changed the title
chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano
enabled auto-merge (squash)
February 10, 2026 00:37
@wobsoriano
wobsoriano
merged commit cd4403d
into
mainFeb 10, 2026

43 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-keyless-e2e

branch
February 10, 2026 00:39
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

core-3integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(repo): Handle framework query param in keyless claim URLs integration tests by wobsoriano · Pull Request #7808 · clerk/javascript · GitHub
Skip to content
fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Feb 10, 2026
Merged
fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Updates integration tests to handle the new framework query parameter in keyless claim URLs.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests
    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores
    • Added a release changeset entry.
@changeset-bot
changeset-botBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 31fc985
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am
Request Review
@coderabbitai
coderabbitaiBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts
Fixed

Comment threadintegration/tests/tanstack-start/keyless.test.ts
Fixed

@wobsorianowobsoriano
changed the title
chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano
enabled auto-merge (squash)
February 10, 2026 00:37
@wobsoriano
wobsoriano
merged commit cd4403d
into
mainFeb 10, 2026

43 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-keyless-e2e

branch
February 10, 2026 00:39
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

core-3integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(repo): Handle framework query param in keyless claim URLs integration tests by wobsoriano · Pull Request #7808 · clerk/javascript · GitHub
Skip to content
fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Feb 10, 2026
Merged
fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Updates integration tests to handle the new framework query parameter in keyless claim URLs.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests
    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores
    • Added a release changeset entry.
@changeset-bot
changeset-botBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 31fc985
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am
Request Review
@coderabbitai
coderabbitaiBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts
Fixed

Comment threadintegration/tests/tanstack-start/keyless.test.ts
Fixed

@wobsorianowobsoriano
changed the title
chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano
enabled auto-merge (squash)
February 10, 2026 00:37
@wobsoriano
wobsoriano
merged commit cd4403d
into
mainFeb 10, 2026

43 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-keyless-e2e

branch
February 10, 2026 00:39
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

core-3integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(repo): Handle framework query param in keyless claim URLs integration tests by wobsoriano · Pull Request #7808 · clerk/javascript · GitHub
Skip to content
fix(repo): Handle framework query param in keyless claim URLs integration tests - #7808
Merged
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Feb 10, 2026
Merged
fix(repo): Handle framework query param in keyless claim URLs integration tests#7808
wobsoriano merged 11 commits into
mainfrom 
rob/fix-keyless-e2e
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description
Updates integration tests to handle the new framework query parameter in keyless claim URLs.
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Improved authentication redirect validation: replaced brittle prefix checks with explicit URL parsing and more flexible containment rules so redirect targets reliably include required claim paths.
  • Tests
    • Updated integration tests to assert redirect behavior using parsed URLs and clearer boolean checks; broadened sign-up/sign-in redirect validations and added clarifying comments.
  • Chores
    • Added a release changeset entry.
@changeset-bot
changeset-botBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 31fc985
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 0 packages
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentFeb 10, 2026 0:31am
Request Review
@coderabbitai
coderabbitaiBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds a new changeset metadata file and updates two Playwright integration tests for keyless authentication. Tests now parse sign_in_force_redirect_url and sign_up_force_redirect_url from the URL query and validate redirects by examining parsed URL components and substring/encoded-segment checks (replacing prior startsWith/prefix logic). Sign-in validation requires the redirect to include the dashboard apps/claim path. Sign-up validation accepts either a dashboard apps/claim URL or a dashboard prepare-account URL that contains an encoded apps/claim segment. Parsing is performed with try/catch.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title focuses on handling a framework query param in keyless claim URLs tests, which aligns with the commit message about testing without query params and the file changes that update redirect URL parsing logic.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Feb 9, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@7808

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@7808

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@7808

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@7808

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@7808

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@7808

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@7808

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@7808

@clerk/express
npm i https://pkg.pr.new/@clerk/express@7808

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@7808

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@7808

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@7808

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@7808

@clerk/react
npm i https://pkg.pr.new/@clerk/react@7808

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@7808

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@7808

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@7808

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@7808

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@7808

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@7808

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@7808

commit: 31fc985
github-advanced-security[bot]
github-advanced-securityAI
found potential problems
Feb 9, 2026
View reviewed changes
Comment threadintegration/tests/next-quickstart-keyless.test.ts
Fixed

Comment threadintegration/tests/tanstack-start/keyless.test.ts
Fixed

@wobsorianowobsoriano
changed the title
chore(repo): Fix keyless E2E testsfix(repo): Handle framework query param in keyless claim URLs integration testsFeb 10, 2026
@wobsoriano
wobsoriano
enabled auto-merge (squash)
February 10, 2026 00:37
@wobsoriano
wobsoriano
merged commit cd4403d
into
mainFeb 10, 2026

43 checks passed

@wobsoriano
wobsoriano
deleted the

rob/fix-keyless-e2e

branch
February 10, 2026 00:39
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
1c39d21
…tion tests (#7808)
wobsoriano added a commit
that referenced
this pull request
Feb 10, 2026
@wobsoriano
fix(repo): Handle framework query param in keyless claim URLs integra…
82a880e
…tion tests (#7808)
nikosdouvlis pushed a commit
that referenced
this pull request
Feb 12, 2026
@wobsoriano@nikosdouvlis
fix(repo): Handle framework query param in keyless claim URLs integra…
afc3fb6
…tion tests (#7808)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

core-3integration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@jacekradko@github-advanced-security