You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Auto reviews are disabled on base/target branches other than the default branch.
Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.
Use the checkbox below for a quick retry:
🔍 Trigger review
📝 Walkthrough
Walkthrough
This is a major release transitioning to the Core 2 release branch (release/core-2) that introduces Solana Web3 authentication support, organization creation defaults with gating, role set migration alerts, extensive API enhancements, and comprehensive localization updates across 40+ language variants.
Updated base branch from origin/main to origin/release/core-2; adjusted workflow triggers and changesets accordingly. Removed legacy workflows (nightly-checks, preview.retheme, release-canary).
New UI cards and button groups for Solana wallet selection and authentication across sign-in/sign-up/profile flows. Includes lazy-loaded wallet buttons with error handling and loading states.
Added Solana authentication paths via authenticateWithSolana, route handling for choose-wallet flow, and unsafeMetadata propagation through sign-up/transfer flows.
New resource class to fetch and manage organization creation defaults; UI alerts and form prefilling based on defaults; logo upload integration via OrganizationProfileAvatarUploader.
Role migration and organization gating packages/clerk-js/src/ui/components/OrganizationProfile/OrganizationMembers.tsx, packages/clerk-js/src/ui/hooks/useFetchRoles.ts, packages/clerk-js/src/ui/components/SessionTasks/tasks/TaskChooseOrganization/ChooseOrganizationScreen.tsx
Added useFetchRoles hook with hasRoleSetMigration flag; conditional UI disabling during role migration; organization creation disable state detection and UI branching.
API endpoint enhancements packages/backend/src/api/endpoints/APIKeysApi.ts, packages/backend/src/api/endpoints/UserApi.ts, packages/backend/src/api/endpoints/JwtTemplatesApi.ts, packages/backend/src/api/endpoints/InvitationApi.ts, packages/backend/src/api/endpoints/WaitlistEntryApi.ts
Resource model updates packages/backend/src/api/resources/ExternalAccount.ts, packages/backend/src/api/resources/OauthAccessToken.ts, packages/backend/src/api/resources/JSON.ts, packages/clerk-js/src/core/resources/PublicUserData.ts
Added providerUserId field to ExternalAccount (deprecating externalId); extended OauthAccessToken with constructor parameters and idToken field; added username to PublicUserData; added id_token to OauthAccessTokenJSON.
Session and token management packages/clerk-js/src/core/resources/Session.ts, packages/clerk-js/src/core/resources/Token.ts, packages/backend/src/tokens/request.ts, packages/backend/src/tokens/handshake.ts
Modified Token.create signature from skipCache boolean to search object; added expired token retry logic in Session._getToken; added OAuth JWT rejection in request authentication; added session token propagation in handshake redirect URL.
Authentication and environment handling packages/clerk-js/src/core/clerk.ts, packages/clerk-js/src/core/auth/cookies/requireSameSiteNone.ts, packages/clerk-js/src/core/auth/cookies/clientUat.ts, packages/clerk-js/src/core/auth/cookies/devBrowser.ts, packages/clerk-js/src/core/auth/cookies/session.ts
Added window.location guards for React Native environments; introduced SameSite=None cookie handling via requiresSameSiteNone utility for third-party domains; updated cookie attributes for .replit.dev origins.
UI element enhancements packages/clerk-js/src/ui/elements/Avatar.tsx, packages/clerk-js/src/ui/elements/OrganizationAvatar.tsx, packages/clerk-js/src/ui/elements/Select.tsx, packages/clerk-js/src/ui/elements/WalletInitialIcon.tsx, packages/clerk-js/src/ui/elements/Alert.tsx
Added showLoadingSpinner prop to Avatar for image loading states; simplified Select placeholder rendering; added WalletInitialIcon component; refactored Alert styling logic.
Extracted state and content resolution logic into testable functions (getCurrentState, getResolvedContent); removed Portal usage; replaced Portal-based rendering with direct JSX; added comprehensive test suite.
Replaced toggle UI with radio group for personal account settings; added dynamic default organization name fetching and interpolation; updated component return types to JSX.Element.
Test infrastructure packages/backend/src/api/__tests__/APIKeysApi.test.ts, packages/backend/src/tokens/__tests__/request.test.ts, integration/tests/astro/billingStore.test.ts, integration/tests/middleware-placement.test.ts
Added comprehensive API key CRUD tests; extended token request tests for OAuth JWT rejection and session token acceptance; added Astro billing store test; added Next.js version-dependent middleware tests.
Added Astro billing store page with custom pricing-table Web component; added prerendered page example; updated TanStack React Start packages and routes structure; added Vite alias for use-sync-external-store.
Localization across 40+ languages packages/localizations/src/en-US.ts, packages/localizations/src/es-ES.ts, packages/localizations/src/fr-FR.ts, + 37 others
Added Solana Web3 UI strings (web3Solana, web3SolanaWalletButtons, web3SelectSolanaWalletScreen) across all locales; expanded organization flow messaging (organizationCreationDisabled, organizationAlreadyExists); added role migration alerts; added new error keys; updated form field placeholders and validation messages. Extensive content additions with some locales reaching 600+ lines changed.
Package metadata and changelogs packages/*/package.json, packages/*/CHANGELOG.md, integration/presets/envs.ts, packages/clerk-js/bundlewatch.config.json
Version bumps across all major packages (clerk-js, backend, astro, etc.); changelog entries documenting dependency updates and feature additions; removed CLERK_API_URL from integration test environment config; updated bundle size thresholds for new billing/Solana components.
Utility and helper updates packages/clerk-js/src/utils/thirdPartyDomains.ts, packages/clerk-js/src/utils/injectedWeb3EthProviders.ts, packages/clerk-js/src/utils/captcha/turnstile.ts, packages/backend/src/constants.ts
New third-party domains utility for SameSite cookie handling; renamed Web3 Eth provider classes for clarity; added diagnostic logging to Turnstile captcha flow; added Session query parameter constant.
Added runtime isStatic prop detection with fallback to Astro.locals.auth; introduced before-hydration and page-load script builders with Astro View Transitions support; added protect-fallback slot handling.
Astro integration and stores packages/astro/src/stores/external.ts, packages/astro/src/integration/create-integration.ts
Added new $billingStore computed store exposing clerk.billing; refactored integration to use extracted snippet builders instead of inlined scripts.
Backend testing and utilities integration/testUtils/usersService.ts, packages/backend/src/api/__tests__/factory.test.ts, packages/backend/src/tokens/__tests__/clerkRequest.test.ts, packages/backend/src/tokens/__tests__/handshake.test.ts
Updated FakeAPIKey.revoke to accept optional reason parameter; renamed UserService.passwordCompromised to setPasswordCompromised; added duck-typing tests for ClerkRequest creation; extended factory tests for user list filtering and waitlist bulk operations.
🐰 A rabbit's tale of changes grand,
With Solana wallets across the land,
Organizations now gated with care,
Web3 threads weave everywhere!
From locales far to the UI near,
The Core 2 release draws ever clear! ✨
🚥 Pre-merge checks | ✅ 2 | ❌ 3
❌ Failed checks (1 warning, 2 inconclusive)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Linked Issues check
❓ Inconclusive
The linked issue CORE-3 provides minimal guidance with only a vague statement that the changes were intentional. The PR's substantive changes (backend API updates, Solana support, workflow modifications, localization additions) cannot be meaningfully validated against this issue.
Provide more detailed objectives or requirements in the linked issue to enable proper validation of the PR's scope and implementation.
Out of Scope Changes check
❓ Inconclusive
The PR contains numerous changes beyond the stated title, including Solana Web3 support, organization creation defaults, CI/workflow updates, and extensive localization additions. While these align with a Core 2 release branch, the title focuses narrowly on JwtTemplatesApi.list typing.
Clarify whether all included changes (Solana, organization defaults, workflows, localizations) are intentionally part of Core 2 scope or if the PR should be narrowed to focus on the titled change.
✅ Passed checks (2 passed)
Check name
Status
Explanation
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
✅ Passed
The PR title clearly summarizes the main change: fixing the type of JwtTemplatesApi.list to return PaginatedResourceResponse, which aligns with the primary changeset objective.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches🧪 Generate unit tests (beta)
Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cherry-pick/6fb0c85ba
Comment @coderabbitai help to get the list of available commands and usage tips.
thiskevinwang
changed the title
fix(backend): type JwtTemplatesApi.list as PaginatedResourceResponse (Core 2)fix(backend): Type JwtTemplatesApi.list as PaginatedResourceResponse (Core 2)Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.