Uh oh!
There was an error while loading. Please reload this page.
fix(astro): Fall back to process.env for runtime environment variables - #7889
Conversation
Add process.env as a third fallback in getContextEnvVar() so that PUBLIC_CLERK_PUBLISHABLE_KEY and other env vars set at runtime (e.g., via the Astro Node adapter) are properly read when import.meta.env.PUBLIC_* is statically replaced at build time by Vite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 6e04eba The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📝 WalkthroughWalkthroughThe PR adds a runtime fallback in the Astro integration's getContextEnvVar(): it reads import.meta.env first and, if that value is missing, falls back to process.env; returns undefined if neither is present. Tests for getSafeEnv and getClientSafeEnv were added to verify source precedence, keylessPublishableKey precedence, and fallback behavior for publishable and public env vars across runtime contexts. Possibly related issues
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Add process.env as a third fallback in getContextEnvVar() so that PUBLIC_CLERK_PUBLISHABLE_KEY and other env vars set at runtime (e.g., via the Astro Node adapter) are properly read when import.meta.env.PUBLIC_* is statically replaced at build time by Vite. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…script into ac/astro-process-env-fallback # Conflicts: # packages/astro/src/server/__tests__/get-safe-env.test.ts
Use `as unknown as App.Locals` cast in createLocals to avoid strict assignability errors from Partial<App.Locals> spreading. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@clerk/agent-toolkit@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
| return envValue; | ||
| } | ||
| // Fallback to process.env for runtime environments (e.g., Node.js adapter) |
There was a problem hiding this comment.
What do you think of having process.env have a higher precedence than import.meta.env?
My gut is that if someone defines this in their running environment that is what they intend vs. what they had it set to when they built an app. It would also make the runtime variables have higher priority like when deployed in Cloudflare Workers.
There was a problem hiding this comment.
Thanks @asdfjkalsdfla . I agree that preferring runtime over build-time values is the correct approach. Updated the PR to switch the priority and marking the change as breaking.
…olution Runtime environment variables now take precedence over build-time values statically replaced by Vite. This aligns behavior so that env vars set at runtime (e.g., Node.js adapter) override those baked in at build time. Resolution order: locals.runtime.env > process.env > import.meta.env
Uh oh!
There was an error while loading. Please reload this page.
Add initCloudflareWorkersEnv() and cloudflare:workers module env check to the shared getEnvVariable() function. This allows Clerk to read environment variables directly from the Cloudflare Workers runtime, following the same pattern used in @clerk/astro (PRs clerk#7889, clerk#8136). Needed for TanStack Start, Hono, and other frameworks on CF Workers where process.env and import.meta.env are not available at runtime.
Add process.env as a third fallback in getContextEnvVar() so that PUBLIC_CLERK_PUBLISHABLE_KEY and other env vars set at runtime (e.g., via the Astro Node adapter) are properly read when import.meta.env.PUBLIC_* is statically replaced at build time by Vite.
Description
fixes#7841
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change
Summary by CodeRabbit
Bug Fixes
Tests