fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
royanger merged 11 commits into from
Mar 10, 2026
Merged

fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk #7997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a2d370f
fix: Respect ui prop when Clerk instance is passed to ClerkProvider
royanger Mar 5, 2026
42cc094
chore: Add changeset
royanger Mar 5, 2026
3f4e299
fix: Fixed changeset formatting
royanger Mar 6, 2026
2dc46ff
fix: Updated fix
royanger Mar 6, 2026
55641a5
Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…
royanger Mar 6, 2026
6d1abce
fix: Refined fix
royanger Mar 9, 2026
8477178
Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…
royanger Mar 9, 2026
1448607
test: Added more tests for various scenarios were ui should or should…
royanger Mar 9, 2026
0e9f584
Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…
royanger Mar 10, 2026
421522c
fix: Deduped lockfile
royanger Mar 10, 2026
9ec3201
fix: Fix dep version issue after dedupe
royanger Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-apples-attend.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.
189 changes: 189 additions & 0 deletions packages/react/src/__tests__/isomorphicClerk.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
expect(result).toBe(mockClerkUI);
});
});

describe('shouldLoadUi across SDK scenarios', () => {
// Helper to run getEntryChunks and return what clerk.load was called with
async function runGetEntryChunks(options: Record<string, any>) {
const mockLoad = vi.fn().mockResolvedValue(undefined);
const mockClerkInstance = options.Clerk || {
load: mockLoad,
loaded: false,
};
if (options.Clerk) {
options.Clerk.load = mockLoad;
options.Clerk.loaded = false;
}

(global as any).Clerk = mockClerkInstance;

const clerk = new IsomorphicClerk({
publishableKey: 'pk_test_XXX',
...options,
});

await (clerk as any).getEntryChunks();

return { mockLoad };
}

// ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
// These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
// shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
// → loads UI from CDN
it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
const { mockLoad } = await runGetEntryChunks({});

expect(loadClerkUIScript).toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: (global as any).__internal_ClerkUICtor,
}),
}),
);
});

// ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
// These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
// shouldLoadUi = (true && true) || true = true
// → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
const mockClerkUI = vi.fn();
const { mockLoad } = await runGetEntryChunks({
ui: { ClerkUI: mockClerkUI },
});

expect(loadClerkUIScript).not.toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: mockClerkUI,
}),
}),
);
});

// ─── @clerk/expo (native mode) ───
// Expo native: Clerk instance, no ui prop, standardBrowser: false
// shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
// → no UI loaded (correct: native apps don't render prebuilt UI)
it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
const mockClerkInstance = {} as any;
const { mockLoad } = await runGetEntryChunks({
Clerk: mockClerkInstance,
standardBrowser: false,
});

expect(loadClerkUIScript).not.toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: undefined,
}),
}),
);
});

// ─── @clerk/expo (web mode) ───
// Expo web: Clerk is null, no ui prop, standardBrowser: true
// shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
// → loads UI from CDN (correct: web mode uses normal browser flow)
it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
const { mockLoad } = await runGetEntryChunks({
Clerk: null,
standardBrowser: true,
});

expect(loadClerkUIScript).toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: (global as any).__internal_ClerkUICtor,
}),
}),
);
});

// ─── @clerk/chrome-extension (without syncHost) ───
// No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
// shouldLoadUi = (true && !instance) || true = false || true = true
// → uses bundled ClerkUI (no CDN)
it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
const mockClerkUI = vi.fn();
const mockClerkInstance = {} as any;
const { mockLoad } = await runGetEntryChunks({
Clerk: mockClerkInstance,
ui: { ClerkUI: mockClerkUI },
standardBrowser: true,
});

expect(loadClerkUIScript).not.toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: mockClerkUI,
}),
}),
);
});

// ─── @clerk/chrome-extension (with syncHost) ───
// With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
// shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
// → uses bundled ClerkUI (no CDN)
it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
const mockClerkUI = vi.fn();
const mockClerkInstance = {} as any;
const { mockLoad } = await runGetEntryChunks({
Clerk: mockClerkInstance,
ui: { ClerkUI: mockClerkUI },
standardBrowser: false,
});

expect(loadClerkUIScript).not.toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: mockClerkUI,
}),
}),
);
});

// ─── Clerk instance provided, no ui prop, standardBrowser: true ───
// shouldLoadUi = (true && !instance) || false = false || false = false
// → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
const mockClerkInstance = {} as any;
const { mockLoad } = await runGetEntryChunks({
Clerk: mockClerkInstance,
standardBrowser: true,
});

expect(loadClerkUIScript).not.toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: undefined,
}),
}),
);
});

// ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
// RSC react-server export may provide ui without ClerkUI initially
// shouldLoadUi = (true && true) || false = true
// → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
const { mockLoad } = await runGetEntryChunks({
ui: { __brand: '__clerkUI', version: '1.0.0' },
});

expect(loadClerkUIScript).not.toHaveBeenCalled();
expect(mockLoad).toHaveBeenCalledWith(
expect.objectContaining({
ui: expect.objectContaining({
ClerkUI: undefined,
}),
}),
);
});
});
});
7 changes: 5 additions & 2 deletions packages/react/src/isomorphicClerk.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

if (!clerk.loaded) {
this.beforeLoad(clerk);
// Only load UI scripts in standard browser environments (not native/headless)
const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
// Load UI when:
// - standard browser and no pre-created Clerk instance (normal CDN path), OR
// - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
const shouldLoadUi =
(this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
}
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

royanger
merged 11 commits into

from

Mar 10, 2026
 Merged


fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk
#7997
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
a2d370f

fix: Respect ui prop when Clerk instance is passed to ClerkProvider


royanger Mar 5, 2026
42cc094

chore: Add changeset


royanger Mar 5, 2026
3f4e299

fix: Fixed changeset formatting


royanger Mar 6, 2026
2dc46ff

fix: Updated fix


royanger Mar 6, 2026
55641a5

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 6, 2026
6d1abce

fix: Refined fix


royanger Mar 9, 2026
8477178

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 9, 2026
1448607

test: Added more tests for various scenarios were ui should or should…


royanger Mar 9, 2026
0e9f584

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 10, 2026
421522c

fix: Deduped lockfile


royanger Mar 10, 2026
9ec3201

fix: Fix dep version issue after dedupe


royanger Mar 10, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tricky-apples-attend.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.

189 changes: 189 additions & 0 deletions
packages/react/src/__tests__/isomorphicClerk.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
 expect(result).toBe(mockClerkUI);
 });
 });

 describe('shouldLoadUi across SDK scenarios', () => {
 // Helper to run getEntryChunks and return what clerk.load was called with
 async function runGetEntryChunks(options: Record<string, any>) {
 const mockLoad = vi.fn().mockResolvedValue(undefined);
 const mockClerkInstance = options.Clerk || {
 load: mockLoad,
 loaded: false,
 };
 if (options.Clerk) {
 options.Clerk.load = mockLoad;
 options.Clerk.loaded = false;
 }

 (global as any).Clerk = mockClerkInstance;

 const clerk = new IsomorphicClerk({
 publishableKey: 'pk_test_XXX',
 ...options,
 });

 await (clerk as any).getEntryChunks();

 return { mockLoad };
 }

 // ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
 // These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
 // shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
 // → loads UI from CDN
 it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
 const { mockLoad } = await runGetEntryChunks({});

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
 // These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
 // shouldLoadUi = (true && true) || true = true
 // → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
 const mockClerkUI = vi.fn();
 const { mockLoad } = await runGetEntryChunks({
 ui: { ClerkUI: mockClerkUI },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/expo (native mode) ───
 // Expo native: Clerk instance, no ui prop, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
 // → no UI loaded (correct: native apps don't render prebuilt UI)
 it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── @clerk/expo (web mode) ───
 // Expo web: Clerk is null, no ui prop, standardBrowser: true
 // shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
 // → loads UI from CDN (correct: web mode uses normal browser flow)
 it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 Clerk: null,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (without syncHost) ───
 // No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
 // shouldLoadUi = (true && !instance) || true = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (with syncHost) ───
 // With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── Clerk instance provided, no ui prop, standardBrowser: true ───
 // shouldLoadUi = (true && !instance) || false = false || false = false
 // → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
 it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
 // RSC react-server export may provide ui without ClerkUI initially
 // shouldLoadUi = (true && true) || false = true
 // → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
 it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 ui: { __brand: '__clerkUI', version: '1.0.0' },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });
 });
});

7 changes: 5 additions & 2 deletions
packages/react/src/isomorphicClerk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

 if (!clerk.loaded) {
 this.beforeLoad(clerk);
 // Only load UI scripts in standard browser environments (not native/headless)
 const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
 // Load UI when:
 // - standard browser and no pre-created Clerk instance (normal CDN path), OR
 // - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
 const shouldLoadUi =
 (this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
 const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
 await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

royanger
merged 11 commits into

from

Mar 10, 2026
 Merged


fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk
#7997
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
a2d370f

fix: Respect ui prop when Clerk instance is passed to ClerkProvider


royanger Mar 5, 2026
42cc094

chore: Add changeset


royanger Mar 5, 2026
3f4e299

fix: Fixed changeset formatting


royanger Mar 6, 2026
2dc46ff

fix: Updated fix


royanger Mar 6, 2026
55641a5

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 6, 2026
6d1abce

fix: Refined fix


royanger Mar 9, 2026
8477178

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 9, 2026
1448607

test: Added more tests for various scenarios were ui should or should…


royanger Mar 9, 2026
0e9f584

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 10, 2026
421522c

fix: Deduped lockfile


royanger Mar 10, 2026
9ec3201

fix: Fix dep version issue after dedupe


royanger Mar 10, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tricky-apples-attend.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.

189 changes: 189 additions & 0 deletions
packages/react/src/__tests__/isomorphicClerk.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
 expect(result).toBe(mockClerkUI);
 });
 });

 describe('shouldLoadUi across SDK scenarios', () => {
 // Helper to run getEntryChunks and return what clerk.load was called with
 async function runGetEntryChunks(options: Record<string, any>) {
 const mockLoad = vi.fn().mockResolvedValue(undefined);
 const mockClerkInstance = options.Clerk || {
 load: mockLoad,
 loaded: false,
 };
 if (options.Clerk) {
 options.Clerk.load = mockLoad;
 options.Clerk.loaded = false;
 }

 (global as any).Clerk = mockClerkInstance;

 const clerk = new IsomorphicClerk({
 publishableKey: 'pk_test_XXX',
 ...options,
 });

 await (clerk as any).getEntryChunks();

 return { mockLoad };
 }

 // ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
 // These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
 // shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
 // → loads UI from CDN
 it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
 const { mockLoad } = await runGetEntryChunks({});

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
 // These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
 // shouldLoadUi = (true && true) || true = true
 // → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
 const mockClerkUI = vi.fn();
 const { mockLoad } = await runGetEntryChunks({
 ui: { ClerkUI: mockClerkUI },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/expo (native mode) ───
 // Expo native: Clerk instance, no ui prop, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
 // → no UI loaded (correct: native apps don't render prebuilt UI)
 it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── @clerk/expo (web mode) ───
 // Expo web: Clerk is null, no ui prop, standardBrowser: true
 // shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
 // → loads UI from CDN (correct: web mode uses normal browser flow)
 it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 Clerk: null,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (without syncHost) ───
 // No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
 // shouldLoadUi = (true && !instance) || true = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (with syncHost) ───
 // With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── Clerk instance provided, no ui prop, standardBrowser: true ───
 // shouldLoadUi = (true && !instance) || false = false || false = false
 // → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
 it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
 // RSC react-server export may provide ui without ClerkUI initially
 // shouldLoadUi = (true && true) || false = true
 // → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
 it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 ui: { __brand: '__clerkUI', version: '1.0.0' },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });
 });
});

7 changes: 5 additions & 2 deletions
packages/react/src/isomorphicClerk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

 if (!clerk.loaded) {
 this.beforeLoad(clerk);
 // Only load UI scripts in standard browser environments (not native/headless)
 const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
 // Load UI when:
 // - standard browser and no pre-created Clerk instance (normal CDN path), OR
 // - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
 const shouldLoadUi =
 (this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
 const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
 await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

royanger
merged 11 commits into

from

Mar 10, 2026
 Merged


fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk
#7997
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
a2d370f

fix: Respect ui prop when Clerk instance is passed to ClerkProvider


royanger Mar 5, 2026
42cc094

chore: Add changeset


royanger Mar 5, 2026
3f4e299

fix: Fixed changeset formatting


royanger Mar 6, 2026
2dc46ff

fix: Updated fix


royanger Mar 6, 2026
55641a5

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 6, 2026
6d1abce

fix: Refined fix


royanger Mar 9, 2026
8477178

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 9, 2026
1448607

test: Added more tests for various scenarios were ui should or should…


royanger Mar 9, 2026
0e9f584

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 10, 2026
421522c

fix: Deduped lockfile


royanger Mar 10, 2026
9ec3201

fix: Fix dep version issue after dedupe


royanger Mar 10, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tricky-apples-attend.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.

189 changes: 189 additions & 0 deletions
packages/react/src/__tests__/isomorphicClerk.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
 expect(result).toBe(mockClerkUI);
 });
 });

 describe('shouldLoadUi across SDK scenarios', () => {
 // Helper to run getEntryChunks and return what clerk.load was called with
 async function runGetEntryChunks(options: Record<string, any>) {
 const mockLoad = vi.fn().mockResolvedValue(undefined);
 const mockClerkInstance = options.Clerk || {
 load: mockLoad,
 loaded: false,
 };
 if (options.Clerk) {
 options.Clerk.load = mockLoad;
 options.Clerk.loaded = false;
 }

 (global as any).Clerk = mockClerkInstance;

 const clerk = new IsomorphicClerk({
 publishableKey: 'pk_test_XXX',
 ...options,
 });

 await (clerk as any).getEntryChunks();

 return { mockLoad };
 }

 // ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
 // These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
 // shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
 // → loads UI from CDN
 it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
 const { mockLoad } = await runGetEntryChunks({});

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
 // These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
 // shouldLoadUi = (true && true) || true = true
 // → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
 const mockClerkUI = vi.fn();
 const { mockLoad } = await runGetEntryChunks({
 ui: { ClerkUI: mockClerkUI },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/expo (native mode) ───
 // Expo native: Clerk instance, no ui prop, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
 // → no UI loaded (correct: native apps don't render prebuilt UI)
 it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── @clerk/expo (web mode) ───
 // Expo web: Clerk is null, no ui prop, standardBrowser: true
 // shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
 // → loads UI from CDN (correct: web mode uses normal browser flow)
 it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 Clerk: null,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (without syncHost) ───
 // No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
 // shouldLoadUi = (true && !instance) || true = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (with syncHost) ───
 // With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── Clerk instance provided, no ui prop, standardBrowser: true ───
 // shouldLoadUi = (true && !instance) || false = false || false = false
 // → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
 it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
 // RSC react-server export may provide ui without ClerkUI initially
 // shouldLoadUi = (true && true) || false = true
 // → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
 it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 ui: { __brand: '__clerkUI', version: '1.0.0' },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });
 });
});

7 changes: 5 additions & 2 deletions
packages/react/src/isomorphicClerk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

 if (!clerk.loaded) {
 this.beforeLoad(clerk);
 // Only load UI scripts in standard browser environments (not native/headless)
 const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
 // Load UI when:
 // - standard browser and no pre-created Clerk instance (normal CDN path), OR
 // - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
 const shouldLoadUi =
 (this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
 const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
 await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

royanger
merged 11 commits into

from

Mar 10, 2026
 Merged


fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk
#7997
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
a2d370f

fix: Respect ui prop when Clerk instance is passed to ClerkProvider


royanger Mar 5, 2026
42cc094

chore: Add changeset


royanger Mar 5, 2026
3f4e299

fix: Fixed changeset formatting


royanger Mar 6, 2026
2dc46ff

fix: Updated fix


royanger Mar 6, 2026
55641a5

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 6, 2026
6d1abce

fix: Refined fix


royanger Mar 9, 2026
8477178

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 9, 2026
1448607

test: Added more tests for various scenarios were ui should or should…


royanger Mar 9, 2026
0e9f584

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 10, 2026
421522c

fix: Deduped lockfile


royanger Mar 10, 2026
9ec3201

fix: Fix dep version issue after dedupe


royanger Mar 10, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tricky-apples-attend.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.

189 changes: 189 additions & 0 deletions
packages/react/src/__tests__/isomorphicClerk.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
 expect(result).toBe(mockClerkUI);
 });
 });

 describe('shouldLoadUi across SDK scenarios', () => {
 // Helper to run getEntryChunks and return what clerk.load was called with
 async function runGetEntryChunks(options: Record<string, any>) {
 const mockLoad = vi.fn().mockResolvedValue(undefined);
 const mockClerkInstance = options.Clerk || {
 load: mockLoad,
 loaded: false,
 };
 if (options.Clerk) {
 options.Clerk.load = mockLoad;
 options.Clerk.loaded = false;
 }

 (global as any).Clerk = mockClerkInstance;

 const clerk = new IsomorphicClerk({
 publishableKey: 'pk_test_XXX',
 ...options,
 });

 await (clerk as any).getEntryChunks();

 return { mockLoad };
 }

 // ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
 // These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
 // shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
 // → loads UI from CDN
 it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
 const { mockLoad } = await runGetEntryChunks({});

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
 // These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
 // shouldLoadUi = (true && true) || true = true
 // → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
 const mockClerkUI = vi.fn();
 const { mockLoad } = await runGetEntryChunks({
 ui: { ClerkUI: mockClerkUI },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/expo (native mode) ───
 // Expo native: Clerk instance, no ui prop, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
 // → no UI loaded (correct: native apps don't render prebuilt UI)
 it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── @clerk/expo (web mode) ───
 // Expo web: Clerk is null, no ui prop, standardBrowser: true
 // shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
 // → loads UI from CDN (correct: web mode uses normal browser flow)
 it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 Clerk: null,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (without syncHost) ───
 // No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
 // shouldLoadUi = (true && !instance) || true = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (with syncHost) ───
 // With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── Clerk instance provided, no ui prop, standardBrowser: true ───
 // shouldLoadUi = (true && !instance) || false = false || false = false
 // → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
 it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
 // RSC react-server export may provide ui without ClerkUI initially
 // shouldLoadUi = (true && true) || false = true
 // → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
 it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 ui: { __brand: '__clerkUI', version: '1.0.0' },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });
 });
});

7 changes: 5 additions & 2 deletions
packages/react/src/isomorphicClerk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

 if (!clerk.loaded) {
 this.beforeLoad(clerk);
 // Only load UI scripts in standard browser environments (not native/headless)
 const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
 // Load UI when:
 // - standard browser and no pre-created Clerk instance (normal CDN path), OR
 // - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
 const shouldLoadUi =
 (this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
 const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
 await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

royanger
merged 11 commits into

from

Mar 10, 2026
 Merged


fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk
#7997
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
a2d370f

fix: Respect ui prop when Clerk instance is passed to ClerkProvider


royanger Mar 5, 2026
42cc094

chore: Add changeset


royanger Mar 5, 2026
3f4e299

fix: Fixed changeset formatting


royanger Mar 6, 2026
2dc46ff

fix: Updated fix


royanger Mar 6, 2026
55641a5

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 6, 2026
6d1abce

fix: Refined fix


royanger Mar 9, 2026
8477178

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 9, 2026
1448607

test: Added more tests for various scenarios were ui should or should…


royanger Mar 9, 2026
0e9f584

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 10, 2026
421522c

fix: Deduped lockfile


royanger Mar 10, 2026
9ec3201

fix: Fix dep version issue after dedupe


royanger Mar 10, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tricky-apples-attend.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.

189 changes: 189 additions & 0 deletions
packages/react/src/__tests__/isomorphicClerk.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
 expect(result).toBe(mockClerkUI);
 });
 });

 describe('shouldLoadUi across SDK scenarios', () => {
 // Helper to run getEntryChunks and return what clerk.load was called with
 async function runGetEntryChunks(options: Record<string, any>) {
 const mockLoad = vi.fn().mockResolvedValue(undefined);
 const mockClerkInstance = options.Clerk || {
 load: mockLoad,
 loaded: false,
 };
 if (options.Clerk) {
 options.Clerk.load = mockLoad;
 options.Clerk.loaded = false;
 }

 (global as any).Clerk = mockClerkInstance;

 const clerk = new IsomorphicClerk({
 publishableKey: 'pk_test_XXX',
 ...options,
 });

 await (clerk as any).getEntryChunks();

 return { mockLoad };
 }

 // ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
 // These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
 // shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
 // → loads UI from CDN
 it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
 const { mockLoad } = await runGetEntryChunks({});

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
 // These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
 // shouldLoadUi = (true && true) || true = true
 // → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
 const mockClerkUI = vi.fn();
 const { mockLoad } = await runGetEntryChunks({
 ui: { ClerkUI: mockClerkUI },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/expo (native mode) ───
 // Expo native: Clerk instance, no ui prop, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
 // → no UI loaded (correct: native apps don't render prebuilt UI)
 it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── @clerk/expo (web mode) ───
 // Expo web: Clerk is null, no ui prop, standardBrowser: true
 // shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
 // → loads UI from CDN (correct: web mode uses normal browser flow)
 it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 Clerk: null,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (without syncHost) ───
 // No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
 // shouldLoadUi = (true && !instance) || true = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (with syncHost) ───
 // With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── Clerk instance provided, no ui prop, standardBrowser: true ───
 // shouldLoadUi = (true && !instance) || false = false || false = false
 // → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
 it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
 // RSC react-server export may provide ui without ClerkUI initially
 // shouldLoadUi = (true && true) || false = true
 // → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
 it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 ui: { __brand: '__clerkUI', version: '1.0.0' },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });
 });
});

7 changes: 5 additions & 2 deletions
packages/react/src/isomorphicClerk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

 if (!clerk.loaded) {
 this.beforeLoad(clerk);
 // Only load UI scripts in standard browser environments (not native/headless)
 const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
 // Load UI when:
 // - standard browser and no pre-created Clerk instance (normal CDN path), OR
 // - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
 const shouldLoadUi =
 (this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
 const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
 await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

royanger
merged 11 commits into

from

Mar 10, 2026
 Merged


fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk
#7997
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
a2d370f

fix: Respect ui prop when Clerk instance is passed to ClerkProvider


royanger Mar 5, 2026
42cc094

chore: Add changeset


royanger Mar 5, 2026
3f4e299

fix: Fixed changeset formatting


royanger Mar 6, 2026
2dc46ff

fix: Updated fix


royanger Mar 6, 2026
55641a5

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 6, 2026
6d1abce

fix: Refined fix


royanger Mar 9, 2026
8477178

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 9, 2026
1448607

test: Added more tests for various scenarios were ui should or should…


royanger Mar 9, 2026
0e9f584

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 10, 2026
421522c

fix: Deduped lockfile


royanger Mar 10, 2026
9ec3201

fix: Fix dep version issue after dedupe


royanger Mar 10, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tricky-apples-attend.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.

189 changes: 189 additions & 0 deletions
packages/react/src/__tests__/isomorphicClerk.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
 expect(result).toBe(mockClerkUI);
 });
 });

 describe('shouldLoadUi across SDK scenarios', () => {
 // Helper to run getEntryChunks and return what clerk.load was called with
 async function runGetEntryChunks(options: Record<string, any>) {
 const mockLoad = vi.fn().mockResolvedValue(undefined);
 const mockClerkInstance = options.Clerk || {
 load: mockLoad,
 loaded: false,
 };
 if (options.Clerk) {
 options.Clerk.load = mockLoad;
 options.Clerk.loaded = false;
 }

 (global as any).Clerk = mockClerkInstance;

 const clerk = new IsomorphicClerk({
 publishableKey: 'pk_test_XXX',
 ...options,
 });

 await (clerk as any).getEntryChunks();

 return { mockLoad };
 }

 // ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
 // These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
 // shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
 // → loads UI from CDN
 it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
 const { mockLoad } = await runGetEntryChunks({});

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
 // These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
 // shouldLoadUi = (true && true) || true = true
 // → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
 const mockClerkUI = vi.fn();
 const { mockLoad } = await runGetEntryChunks({
 ui: { ClerkUI: mockClerkUI },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/expo (native mode) ───
 // Expo native: Clerk instance, no ui prop, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
 // → no UI loaded (correct: native apps don't render prebuilt UI)
 it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── @clerk/expo (web mode) ───
 // Expo web: Clerk is null, no ui prop, standardBrowser: true
 // shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
 // → loads UI from CDN (correct: web mode uses normal browser flow)
 it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 Clerk: null,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (without syncHost) ───
 // No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
 // shouldLoadUi = (true && !instance) || true = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (with syncHost) ───
 // With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── Clerk instance provided, no ui prop, standardBrowser: true ───
 // shouldLoadUi = (true && !instance) || false = false || false = false
 // → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
 it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
 // RSC react-server export may provide ui without ClerkUI initially
 // shouldLoadUi = (true && true) || false = true
 // → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
 it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 ui: { __brand: '__clerkUI', version: '1.0.0' },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });
 });
});

7 changes: 5 additions & 2 deletions
packages/react/src/isomorphicClerk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

 if (!clerk.loaded) {
 this.beforeLoad(clerk);
 // Only load UI scripts in standard browser environments (not native/headless)
 const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
 // Load UI when:
 // - standard browser and no pre-created Clerk instance (normal CDN path), OR
 // - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
 const shouldLoadUi =
 (this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
 const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
 await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
 }
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk#7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

royanger
merged 11 commits into

from

Mar 10, 2026
 Merged


fix(react): Respect ui prop when Clerk instance is passed to IsomorphicClerk
#7997
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


11 commits


Select commit
Hold shift + click to select a range
a2d370f

fix: Respect ui prop when Clerk instance is passed to ClerkProvider


royanger Mar 5, 2026
42cc094

chore: Add changeset


royanger Mar 5, 2026
3f4e299

fix: Fixed changeset formatting


royanger Mar 6, 2026
2dc46ff

fix: Updated fix


royanger Mar 6, 2026
55641a5

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 6, 2026
6d1abce

fix: Refined fix


royanger Mar 9, 2026
8477178

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 9, 2026
1448607

test: Added more tests for various scenarios were ui should or should…


royanger Mar 9, 2026
0e9f584

Merge branch 'main' into roy/fix-clerk-loaded-without-ui-error-in-chr…


royanger Mar 10, 2026
421522c

fix: Deduped lockfile


royanger Mar 10, 2026
9ec3201

fix: Fix dep version issue after dedupe


royanger Mar 10, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


5 changes: 5 additions & 0 deletions
.changeset/tricky-apples-attend.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@clerk/react': minor
---

The `ui` prop is now respected if a Clerk instance is passed via the `Clerk` prop to `IsomorphicClerk`. This fixes the 'Clerk was not loaded with Ui components' error in the Chrome Extension SDK.

189 changes: 189 additions & 0 deletions
packages/react/src/__tests__/isomorphicClerk.test.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,4 +200,193 @@ describe('isomorphicClerk', () => {
 expect(result).toBe(mockClerkUI);
 });
 });

 describe('shouldLoadUi across SDK scenarios', () => {
 // Helper to run getEntryChunks and return what clerk.load was called with
 async function runGetEntryChunks(options: Record<string, any>) {
 const mockLoad = vi.fn().mockResolvedValue(undefined);
 const mockClerkInstance = options.Clerk || {
 load: mockLoad,
 loaded: false,
 };
 if (options.Clerk) {
 options.Clerk.load = mockLoad;
 options.Clerk.loaded = false;
 }

 (global as any).Clerk = mockClerkInstance;

 const clerk = new IsomorphicClerk({
 publishableKey: 'pk_test_XXX',
 ...options,
 });

 await (clerk as any).getEntryChunks();

 return { mockLoad };
 }

 // ─── @clerk/react, @clerk/nextjs, @clerk/react-router, @clerk/tanstack-react-start ───
 // These SDKs: no Clerk prop, no ui prop, standardBrowser omitted (undefined)
 // shouldLoadUi = (undefined !== false && !undefined) || !!undefined = (true && true) || false = true
 // → loads UI from CDN
 it('loads UI from CDN when no Clerk, no ui, standardBrowser omitted (nextjs/react-router/tanstack)', async () => {
 const { mockLoad } = await runGetEntryChunks({});

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/react with bundled ui prop (e.g. user passes ui={ui} from @clerk/ui) ───
 // These SDKs: no Clerk prop, ui with ClerkUI, standardBrowser omitted
 // shouldLoadUi = (true && true) || true = true
 // → getClerkUIEntryChunk returns the bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI when ui prop is passed without Clerk instance (react with ui prop)', async () => {
 const mockClerkUI = vi.fn();
 const { mockLoad } = await runGetEntryChunks({
 ui: { ClerkUI: mockClerkUI },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/expo (native mode) ───
 // Expo native: Clerk instance, no ui prop, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!undefined = false || false = false
 // → no UI loaded (correct: native apps don't render prebuilt UI)
 it('does not load UI for Expo native (Clerk instance, no ui, standardBrowser: false)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── @clerk/expo (web mode) ───
 // Expo web: Clerk is null, no ui prop, standardBrowser: true
 // shouldLoadUi = (true !== false && !null) || false = (true && true) || false = true
 // → loads UI from CDN (correct: web mode uses normal browser flow)
 it('loads UI from CDN for Expo web (Clerk: null, standardBrowser: true)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 Clerk: null,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: (global as any).__internal_ClerkUICtor,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (without syncHost) ───
 // No syncHost: Clerk instance, ui with ClerkUI, standardBrowser: true
 // shouldLoadUi = (true && !instance) || true = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension without syncHost (standardBrowser: true)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── @clerk/chrome-extension (with syncHost) ───
 // With syncHost: Clerk instance, ui with ClerkUI, standardBrowser: false
 // shouldLoadUi = (false !== false && ...) || !!ClerkUI = false || true = true
 // → uses bundled ClerkUI (no CDN)
 it('uses bundled ClerkUI for chrome-extension with syncHost (standardBrowser: false)', async () => {
 const mockClerkUI = vi.fn();
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 ui: { ClerkUI: mockClerkUI },
 standardBrowser: false,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: mockClerkUI,
 }),
 }),
 );
 });

 // ─── Clerk instance provided, no ui prop, standardBrowser: true ───
 // shouldLoadUi = (true && !instance) || false = false || false = false
 // → no UI loaded (correct: Clerk instance without bundled UI, no CDN attempt)
 it('does not load UI when Clerk instance provided without ui prop (standardBrowser: true)', async () => {
 const mockClerkInstance = {} as any;
 const { mockLoad } = await runGetEntryChunks({
 Clerk: mockClerkInstance,
 standardBrowser: true,
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });

 // ─── ui prop passed as server marker (no ClerkUI), no Clerk instance ───
 // RSC react-server export may provide ui without ClerkUI initially
 // shouldLoadUi = (true && true) || false = true
 // → getClerkUIEntryChunk is called, but uiProp exists without ClerkUI → returns undefined (skips CDN)
 it('skips CDN when ui prop exists without ClerkUI (server marker object)', async () => {
 const { mockLoad } = await runGetEntryChunks({
 ui: { __brand: '__clerkUI', version: '1.0.0' },
 });

 expect(loadClerkUIScript).not.toHaveBeenCalled();
 expect(mockLoad).toHaveBeenCalledWith(
 expect.objectContaining({
 ui: expect.objectContaining({
 ClerkUI: undefined,
 }),
 }),
 );
 });
 });
});

7 changes: 5 additions & 2 deletions
packages/react/src/isomorphicClerk.ts

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -514,8 +514,11 @@ export class IsomorphicClerk implements IsomorphicLoadedClerk {

 if (!clerk.loaded) {
 this.beforeLoad(clerk);
 // Only load UI scripts in standard browser environments (not native/headless)
 const shouldLoadUi = !this.options.Clerk && this.options.standardBrowser !== false;
 // Load UI when:
 // - standard browser and no pre-created Clerk instance (normal CDN path), OR
 // - a bundled ClerkUI was provided via the ui prop (e.g. chrome-extension, even with standardBrowser: false)
 const shouldLoadUi =
 (this.options.standardBrowser !== false && !this.options.Clerk) || !!this.options.ui?.ClerkUI;
 const ClerkUI = shouldLoadUi ? await this.getClerkUIEntryChunk() : undefined;
 await clerk.load({ ...this.options, ui: { ...this.options.ui, ClerkUI } });
 }
Expand Down
Loading