Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift by chriscanin · Pull Request #8111 · clerk/javascript · GitHub
Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift by chriscanin · Pull Request #8111 · clerk/javascript · GitHub
Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift by chriscanin · Pull Request #8111 · clerk/javascript · GitHub
Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift by chriscanin · Pull Request #8111 · clerk/javascript · GitHub
Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift by chriscanin · Pull Request #8111 · clerk/javascript · GitHub
Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift by chriscanin · Pull Request #8111 · clerk/javascript · GitHub
Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift by chriscanin · Pull Request #8111 · clerk/javascript · GitHub
Skip to content

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift - #8111

Merged
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path
Mar 23, 2026
Merged

fix(expo): use require.resolve in config plugin to locate ClerkViewFactory.swift#8111
brkalow merged 2 commits into
mainfrom
chris/fix-config-plugin-swift-path

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replaces hardcoded possiblePaths array in withClerkIOS config plugin with require.resolve('@clerk/expo/package.json') to locate ClerkViewFactory.swift
  • Node's module resolution handles arbitrary monorepo nesting depths, fixing failures in pnpm workspaces where the app is nested 2+ levels deep (e.g. apps/mobile/)

Reported in

Closes#8049

Test plan

  • Run expo prebuild in a pnpm workspace with app nested 2+ levels deep and verify no ⚠️ ClerkViewFactory.swift not found warning
  • Run expo prebuild in a standard npm/yarn project and verify it still works

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Fixed file resolution issues in the Expo config plugin for pnpm workspaces nested two or more levels deep, ensuring proper configuration setup in complex workspace structures.

@changeset-bot

changeset-botBot commented Mar 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 780acce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 20, 2026 4:17pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8111

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8111

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8111

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8111

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8111

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8111

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8111

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8111

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8111

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8111

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8111

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8111

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8111

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8111

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8111

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8111

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8111

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8111

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8111

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8111

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8111

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8111

commit: 780acce

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 403a5aab-686f-478e-accb-b756852f365f

📥 Commits

Reviewing files that changed from the base of the PR and between 4686538 and a434677.

📒 Files selected for processing (2)
  • .changeset/fix-config-plugin-swift-path.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

This pull request adds a patch-level fix to the Expo config plugin that changes how ClerkViewFactory.swift is located during iOS AppDelegate injection. The previous multi-location search approach is replaced with a require.resolve-based method that derives the package root from @clerk/expo/package.json and resolves ClerkViewFactory.swift from that location. This addresses compatibility issues in pnpm workspaces nested two or more levels deep. If the file cannot be resolved or doesn't exist, the sourceFile remains null and processing is skipped. A changeset entry documenting the fix is also included.

Possibly related issues

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and accurately describes the main change: using require.resolve in the Expo config plugin to locate ClerkViewFactory.swift, which directly matches the PR's core objective of fixing module resolution in nested monorepos.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how can we test this?

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

!snapshot

@chriscanin

Copy link
Copy Markdown
ContributorAuthor

@brkalow

  1. Install the current published version of @clerk/expo in a pnpm workspace or Turborepo where the app is nested 2+ levels deep (e.g. apps/mobile/):
my-monorepo/
├── pnpm-workspace.yaml
├── packages/
│ └── shared/
└── apps/
└── mobile/ <-- Expo app here (2 levels deep)
├── app.json <-- has "plugins": ["@clerk/expo"]
└── package.json
  1. Run npx expo prebuild --clean --platform ios from the apps/mobile/ directory.

  2. You will observe the warning: ⚠️ ClerkViewFactory.swift not found, skipping injection

  3. The file is missing from the iOS project — grep -r "ClerkViewFactory" ios/ returns nothing.

Steps to verify the fix (after the fix)

  1. Install the version from this PR.

  2. Run npx expo prebuild --clean --platform ios from the same nested apps/mobile/ directory.

  3. The warning should not appear. Instead you should see: ✅ Copied ClerkViewFactory.swift to app target

  4. Confirm the file exists: grep -r "ClerkViewFactory" ios/ should return results.

Why it broke

The config plugin used a hardcoded list of relative paths to find ClerkViewFactory.swift (e.g. ../../node_modules/@clerk/expo/ios/). In pnpm workspaces nested 2+ levels deep, none of those paths resolve. The fix uses require.resolve('@clerk/expo/package.json') which lets Node's module resolution handle arbitrary nesting depths.

@brkalow
brkalow merged commit 4146b84 into mainMar 23, 2026
42 checks passed
@brkalow
brkalow deleted the chris/fix-config-plugin-swift-path branch March 23, 2026 21:34
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkIOS: ClerkViewFactory.swift not found in pnpm workspaces nested 2+ levels deep

2 participants

@chriscanin@brkalow