Skip to content

fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112

Merged
brkalow merged 5 commits into
mainfrom
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged

fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom
chris/fix-native-clerk-module-codegen

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Summary

PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.

  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)

Reported by

Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`

Test plan

  • Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  • Web build still works without `Cannot read properties of undefined (reading 'get')` crash

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.

@changeset-bot

changeset-botBot commented Mar 18, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 93d8593

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm

Request Review

@coderabbitai

coderabbitaiBot commented Mar 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28

📥 Commits

Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.

📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough

Walkthrough

The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026
brkalow
brkalow approved these changes Mar 19, 2026
View reviewed changes

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?

@anis-rangrezanis-rangrez mentioned this pull request Mar 22, 2026
Closed
4 tasks
@chriscanin

chriscanin commented Mar 23, 2026•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

did/can we verify the web case is still fixed?

I have just verified, web is working as well! Sign-ins and sign-outs are working.
image

tmilewski
tmilewski approved these changes Mar 23, 2026
View reviewed changes

@tmilewskitmilewski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.

@chriscanin

chriscanin commented Mar 23, 2026

Copy link
Copy Markdown
ContributorAuthor

👍 Seems to fail when building in CI though.

Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.

@pkg-pr-new

pkg-pr-newBot commented Mar 23, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593

@brkalow
brkalow merged commit cabbe3a into mainMar 23, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-native-clerk-module-codegen branch March 23, 2026 17:11
@clerk-cookieclerk-cookie mentioned this pull request Mar 23, 2026
Merged
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(expo): fix Android new architecture codegen error in NativeClerkModule by chriscanin · Pull Request #8112 · clerk/javascript · GitHub
Skip to content
fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112
Merged
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Conversation
@chriscanin
@chriscaninchriscanin
commented
Mar 18, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
  •  Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  •  Web build still works without `Cannot read properties of undefined (reading 'get')` crash
🤖 Generated with Claude Code
Summary by CodeRabbit
  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.
@changeset-bot
changeset-botBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 93d8593
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28
📥 Commits
Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.
📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough
Walkthrough
The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@chriscaninchriscanin
self-assigned this
Mar 18, 2026
brkalow
brkalow
approved these changes
Mar 19, 2026
View reviewed changes
@brkalowbrkalow
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?
@anis-rangrezanis-rangrez
mentioned this pull request
Mar 22, 2026

Closed

4 tasks
@chriscanin
chriscanin
commented
Mar 23, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
did/can we verify the web case is still fixed?
I have just verified, web is working as well! Sign-ins and sign-outs are working.
image
tmilewski
tmilewski
approved these changes
Mar 23, 2026
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.
@chriscanin
chriscanin
commented
Mar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593
@brkalow
brkalow
merged commit cabbe3a
into
mainMar 23, 2026

44 checks passed

@brkalow
brkalow
deleted the

chris/fix-native-clerk-module-codegen

branch
March 23, 2026 17:11
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 23, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): fix Android new architecture codegen error in NativeClerkModule by chriscanin · Pull Request #8112 · clerk/javascript · GitHub
Skip to content
fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112
Merged
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Conversation
@chriscanin
@chriscaninchriscanin
commented
Mar 18, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
  •  Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  •  Web build still works without `Cannot read properties of undefined (reading 'get')` crash
🤖 Generated with Claude Code
Summary by CodeRabbit
  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.
@changeset-bot
changeset-botBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 93d8593
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28
📥 Commits
Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.
📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough
Walkthrough
The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@chriscaninchriscanin
self-assigned this
Mar 18, 2026
brkalow
brkalow
approved these changes
Mar 19, 2026
View reviewed changes
@brkalowbrkalow
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?
@anis-rangrezanis-rangrez
mentioned this pull request
Mar 22, 2026

Closed

4 tasks
@chriscanin
chriscanin
commented
Mar 23, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
did/can we verify the web case is still fixed?
I have just verified, web is working as well! Sign-ins and sign-outs are working.
image
tmilewski
tmilewski
approved these changes
Mar 23, 2026
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.
@chriscanin
chriscanin
commented
Mar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593
@brkalow
brkalow
merged commit cabbe3a
into
mainMar 23, 2026

44 checks passed

@brkalow
brkalow
deleted the

chris/fix-native-clerk-module-codegen

branch
March 23, 2026 17:11
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 23, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): fix Android new architecture codegen error in NativeClerkModule by chriscanin · Pull Request #8112 · clerk/javascript · GitHub
Skip to content
fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112
Merged
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Conversation
@chriscanin
@chriscaninchriscanin
commented
Mar 18, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
  •  Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  •  Web build still works without `Cannot read properties of undefined (reading 'get')` crash
🤖 Generated with Claude Code
Summary by CodeRabbit
  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.
@changeset-bot
changeset-botBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 93d8593
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28
📥 Commits
Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.
📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough
Walkthrough
The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@chriscaninchriscanin
self-assigned this
Mar 18, 2026
brkalow
brkalow
approved these changes
Mar 19, 2026
View reviewed changes
@brkalowbrkalow
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?
@anis-rangrezanis-rangrez
mentioned this pull request
Mar 22, 2026

Closed

4 tasks
@chriscanin
chriscanin
commented
Mar 23, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
did/can we verify the web case is still fixed?
I have just verified, web is working as well! Sign-ins and sign-outs are working.
image
tmilewski
tmilewski
approved these changes
Mar 23, 2026
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.
@chriscanin
chriscanin
commented
Mar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593
@brkalow
brkalow
merged commit cabbe3a
into
mainMar 23, 2026

44 checks passed

@brkalow
brkalow
deleted the

chris/fix-native-clerk-module-codegen

branch
March 23, 2026 17:11
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 23, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(expo): fix Android new architecture codegen error in NativeClerkModule by chriscanin · Pull Request #8112 · clerk/javascript · GitHub
Skip to content
fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112
Merged
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Conversation
@chriscanin
@chriscaninchriscanin
commented
Mar 18, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
  •  Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  •  Web build still works without `Cannot read properties of undefined (reading 'get')` crash
🤖 Generated with Claude Code
Summary by CodeRabbit
  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.
@changeset-bot
changeset-botBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 93d8593
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28
📥 Commits
Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.
📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough
Walkthrough
The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@chriscaninchriscanin
self-assigned this
Mar 18, 2026
brkalow
brkalow
approved these changes
Mar 19, 2026
View reviewed changes
@brkalowbrkalow
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?
@anis-rangrezanis-rangrez
mentioned this pull request
Mar 22, 2026

Closed

4 tasks
@chriscanin
chriscanin
commented
Mar 23, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
did/can we verify the web case is still fixed?
I have just verified, web is working as well! Sign-ins and sign-outs are working.
image
tmilewski
tmilewski
approved these changes
Mar 23, 2026
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.
@chriscanin
chriscanin
commented
Mar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593
@brkalow
brkalow
merged commit cabbe3a
into
mainMar 23, 2026

44 checks passed

@brkalow
brkalow
deleted the

chris/fix-native-clerk-module-codegen

branch
March 23, 2026 17:11
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 23, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): fix Android new architecture codegen error in NativeClerkModule by chriscanin · Pull Request #8112 · clerk/javascript · GitHub
Skip to content
fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112
Merged
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Conversation
@chriscanin
@chriscaninchriscanin
commented
Mar 18, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
  •  Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  •  Web build still works without `Cannot read properties of undefined (reading 'get')` crash
🤖 Generated with Claude Code
Summary by CodeRabbit
  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.
@changeset-bot
changeset-botBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 93d8593
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28
📥 Commits
Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.
📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough
Walkthrough
The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@chriscaninchriscanin
self-assigned this
Mar 18, 2026
brkalow
brkalow
approved these changes
Mar 19, 2026
View reviewed changes
@brkalowbrkalow
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?
@anis-rangrezanis-rangrez
mentioned this pull request
Mar 22, 2026

Closed

4 tasks
@chriscanin
chriscanin
commented
Mar 23, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
did/can we verify the web case is still fixed?
I have just verified, web is working as well! Sign-ins and sign-outs are working.
image
tmilewski
tmilewski
approved these changes
Mar 23, 2026
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.
@chriscanin
chriscanin
commented
Mar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593
@brkalow
brkalow
merged commit cabbe3a
into
mainMar 23, 2026

44 checks passed

@brkalow
brkalow
deleted the

chris/fix-native-clerk-module-codegen

branch
March 23, 2026 17:11
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 23, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): fix Android new architecture codegen error in NativeClerkModule by chriscanin · Pull Request #8112 · clerk/javascript · GitHub
Skip to content
fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112
Merged
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Conversation
@chriscanin
@chriscaninchriscanin
commented
Mar 18, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
  •  Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  •  Web build still works without `Cannot read properties of undefined (reading 'get')` crash
🤖 Generated with Claude Code
Summary by CodeRabbit
  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.
@changeset-bot
changeset-botBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 93d8593
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28
📥 Commits
Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.
📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough
Walkthrough
The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@chriscaninchriscanin
self-assigned this
Mar 18, 2026
brkalow
brkalow
approved these changes
Mar 19, 2026
View reviewed changes
@brkalowbrkalow
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?
@anis-rangrezanis-rangrez
mentioned this pull request
Mar 22, 2026

Closed

4 tasks
@chriscanin
chriscanin
commented
Mar 23, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
did/can we verify the web case is still fixed?
I have just verified, web is working as well! Sign-ins and sign-outs are working.
image
tmilewski
tmilewski
approved these changes
Mar 23, 2026
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.
@chriscanin
chriscanin
commented
Mar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593
@brkalow
brkalow
merged commit cabbe3a
into
mainMar 23, 2026

44 checks passed

@brkalow
brkalow
deleted the

chris/fix-native-clerk-module-codegen

branch
March 23, 2026 17:11
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 23, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(expo): fix Android new architecture codegen error in NativeClerkModule by chriscanin · Pull Request #8112 · clerk/javascript · GitHub
Skip to content
fix(expo): fix Android new architecture codegen error in NativeClerkModule - #8112
Merged
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Mar 23, 2026
Merged
fix(expo): fix Android new architecture codegen error in NativeClerkModule#8112
brkalow merged 5 commits into
mainfrom 
chris/fix-native-clerk-module-codegen
Conversation
@chriscanin
@chriscaninchriscanin
commented
Mar 18, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Summary
PR #8066 fixed a web crash by adding optional chaining to `TurboModuleRegistry?.get` in `NativeClerkModule.ts`. However, React Native's new architecture codegen requires the exact pattern `TurboModuleRegistry.get('moduleName')` — the `?.` breaks its parser with `UnusedModuleInterfaceParserError`.
  • Restores `TurboModuleRegistry.get('ClerkExpo')` in `NativeClerkModule.ts` (fixes Android codegen)
  • Adds `NativeClerkModule.web.ts` that exports `null` (Metro resolves this on web, avoiding the `TurboModuleRegistry` undefined crash)
Reported by
Bledar (internal) — Android build failure with `UnusedModuleInterfaceParserError: Module NativeClerkModule: Unused NativeModule spec`
Test plan
  •  Android new architecture build succeeds (no `generateCodegenSchemaFromJavaScript` failure)
  •  Web build still works without `Cannot read properties of undefined (reading 'get')` crash
🤖 Generated with Claude Code
Summary by CodeRabbit
  • Bug Fixes
    • Resolved Android new architecture codegen errors to restore stable native module resolution and prevent runtime failures.
    • Restored the native module registry pattern to ensure reliable module lookup across Android builds.
    • Added explicit web-side handling to avoid native registry references on web, improving cross-platform compatibility.
@changeset-bot
changeset-botBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 93d8593
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 23, 2026 3:48pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Mar 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f2505740-14ba-4c3b-ab91-5d3bf33fed28
📥 Commits
Reviewing files that changed from the base of the PR and between b00c2ed and 93d8593.
📒 Files selected for processing (1)
  • packages/expo/src/specs/NativeClerkModule.web.ts
📝 Walkthrough
Walkthrough
The PR updates the Expo NativeClerkModule specifications: packages/expo/src/specs/NativeClerkModule.ts now exports the result of TurboModuleRegistry.get<Spec>('ClerkExpo') directly (removing optional chaining and null coalescing). A new web-specific file packages/expo/src/specs/NativeClerkModule.web.ts is added and exports null as the default to avoid referencing TurboModuleRegistry on web. A patch-level changeset entry is included.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe PR title directly and specifically addresses the main change: fixing Android new architecture codegen errors in NativeClerkModule by restoring the TurboModuleRegistry.get pattern.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@chriscaninchriscanin
self-assigned this
Mar 18, 2026
brkalow
brkalow
approved these changes
Mar 19, 2026
View reviewed changes
@brkalowbrkalow
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did/can we verify the web case is still fixed?
@anis-rangrezanis-rangrez
mentioned this pull request
Mar 22, 2026

Closed

4 tasks
@chriscanin
chriscanin
commented
Mar 23, 2026•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
did/can we verify the web case is still fixed?
I have just verified, web is working as well! Sign-ins and sign-outs are working.
image
tmilewski
tmilewski
approved these changes
Mar 23, 2026
View reviewed changes
@tmilewskitmilewski
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to fail when building in CI though.
@chriscanin
chriscanin
commented
Mar 23, 2026

Copy link


Copy Markdown

ContributorAuthor
👍 Seems to fail when building in CI though.
Yeah checking this out. I think it was passing on Friday. Not sure... Fixing it up.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 23, 2026

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8112

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8112

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8112

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8112

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8112

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8112

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8112

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8112

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8112

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8112

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8112

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8112

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8112

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8112

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8112

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8112

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8112

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8112

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8112

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8112

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8112

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8112

commit: 93d8593
@brkalow
brkalow
merged commit cabbe3a
into
mainMar 23, 2026

44 checks passed

@brkalow
brkalow
deleted the

chris/fix-native-clerk-module-codegen

branch
March 23, 2026 17:11
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 23, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@chriscanin@wobsoriano
fix(expo): fix Android new architecture codegen error in NativeClerkM…
c628594
…odule (#8112)
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tmilewskitmilewskitmilewski approved these changes
@brkalowbrkalowbrkalow approved these changes

Assignees

@chriscaninchriscanin

Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@chriscanin@tmilewski@brkalow