Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(expo): add appleSignIn option to config plugin to allow opting out by chriscanin · Pull Request #8113 · clerk/javascript · GitHub
Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): add appleSignIn option to config plugin to allow opting out by chriscanin · Pull Request #8113 · clerk/javascript · GitHub
Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): add appleSignIn option to config plugin to allow opting out by chriscanin · Pull Request #8113 · clerk/javascript · GitHub
Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(expo): add appleSignIn option to config plugin to allow opting out by chriscanin · Pull Request #8113 · clerk/javascript · GitHub
Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): add appleSignIn option to config plugin to allow opting out by chriscanin · Pull Request #8113 · clerk/javascript · GitHub
Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(expo): add appleSignIn option to config plugin to allow opting out by chriscanin · Pull Request #8113 · clerk/javascript · GitHub
Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(expo): add appleSignIn option to config plugin to allow opting out by chriscanin · Pull Request #8113 · clerk/javascript · GitHub
Skip to content

fix(expo): add appleSignIn option to config plugin to allow opting out - #8113

Merged
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional
Mar 24, 2026
Merged

fix(expo): add appleSignIn option to config plugin to allow opting out#8113
brkalow merged 1 commit into
mainfrom
chris/fix-apple-signin-entitlement-unconditional

Conversation

@chriscanin

@chriscaninchriscanin commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes#8050

The withClerkExpo config plugin was unconditionally adding the com.apple.developer.applesignin entitlement to every app, even those that don't use Apple Sign In. This caused issues for apps that intentionally don't include Apple Sign In (e.g., apps targeting non-Apple platforms or apps that want to manage entitlements manually).

Change: Added an appleSignIn option to the plugin props that defaults to true for full backwards compatibility. Apps can opt out by passing appleSignIn: false.

Usage:

// app.json{"plugins": [["@clerk/expo",{"appleSignIn": false}]]}

Test plan

  • Verify existing apps (no appleSignIn option) still get the entitlement added (backwards compat)
  • Verify appleSignIn: false prevents the entitlement from being added
  • Verify appleSignIn: true explicitly still adds the entitlement

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Added an optional appleSignIn configuration option. When set to false, the Sign in with Apple entitlement will not be automatically included, enabling applications that do not use Apple Sign In to opt out from the entitlement. Defaults to true for backward compatibility.

@changeset-bot

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c7f4e21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 18, 2026 4:24pm

Request Review

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8113

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8113

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8113

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8113

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8113

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8113

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8113

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8113

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8113

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8113

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8113

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8113

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8113

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8113

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8113

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8113

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8113

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8113

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8113

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8113

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8113

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8113

commit: c7f4e21

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: e619da58-253f-41cb-8c80-f89a5dea39fc

📥 Commits

Reviewing files that changed from the base of the PR and between ce67184 and c7f4e21.

📒 Files selected for processing (2)
  • .changeset/fix-apple-signin-entitlement-opt-out.md
  • packages/expo/app.plugin.js

📝 Walkthrough

Walkthrough

The pull request introduces an appleSignIn configuration option to the Expo config plugin. When explicitly set to false, the plugin skips the automatic addition of the Sign in with Apple entitlement during the build process. The main change updates withClerkExpo in packages/expo/app.plugin.js to check the appleSignIn flag from props and conditionally apply the Apple Sign-In configuration. By default, the flag remains true to preserve existing behavior. A changeset file documents this new opt-out capability for users of the Expo config plugin.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and concisely describes the main change: adding an appleSignIn option to the config plugin for opting out, which directly addresses the core fix.
Linked Issues check✅ PassedThe PR implements the exact solution requested in #8050: adds an appleSignIn option defaulting to true, allowing opt-out via appleSignIn: false while maintaining backwards compatibility.
Out of Scope Changes check✅ PassedAll changes are directly aligned with the linked issue requirement: modifying the config plugin to support the appleSignIn option with no extraneous changes.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chriscaninchriscanin self-assigned this Mar 18, 2026

@brkalowbrkalow left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels odd that this defaults to true, but I understand the backwards compat point.

@brkalow
brkalow merged commit d27d42e into mainMar 24, 2026
44 checks passed
@brkalow
brkalow deleted the chris/fix-apple-signin-entitlement-unconditional branch March 24, 2026 16:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

withClerkAppleSignIn adds entitlement unconditionally — no opt-out

2 participants

@chriscanin@brkalow