fix(testing): add retry logic for testing token fetch on 429/5xx - #8138

Merged
jacekradko merged 11 commits into
mainfrom
jacek/retry-testing-token
Mar 31, 2026
Merged

fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom
jacek/retry-testing-token

Conversation

@jacekradko

@jacekradkojacekradko commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths

Why

fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.

Test plan

  • @clerk/testing builds successfully
  • 19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  • Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately

@changeset-bot

changeset-botBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e27ba1a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a

@coderabbitai

coderabbitaiBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot reviewed Mar 31, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86

📥 Commits

Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.

📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts

Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko merged commit 829583a into mainMar 31, 2026
42 checks passed
@jacekradko
jacekradko deleted the jacek/retry-testing-token branch March 31, 2026 14:46
@clerk-cookieclerk-cookie mentioned this pull request Mar 31, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
fix(testing): add retry logic for testing token fetch on 429/5xx - #8138
Merged
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Mar 31, 2026
Merged
fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Conversation
@jacekradko
@jacekradkojacekradko
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths
Why
fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.
Test plan
  • @clerk/testing builds successfully
  •  19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  •  Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e27ba1a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86
📥 Commits
Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.
📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts
Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko
merged commit 829583a
into
mainMar 31, 2026

42 checks passed

@jacekradko
jacekradko
deleted the

jacek/retry-testing-token

branch
March 31, 2026 14:46
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

testing

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(testing): add retry logic for testing token fetch on 429/5xx - #8138
Merged
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Mar 31, 2026
Merged
fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Conversation
@jacekradko
@jacekradkojacekradko
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths
Why
fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.
Test plan
  • @clerk/testing builds successfully
  •  19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  •  Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e27ba1a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86
📥 Commits
Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.
📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts
Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko
merged commit 829583a
into
mainMar 31, 2026

42 checks passed

@jacekradko
jacekradko
deleted the

jacek/retry-testing-token

branch
March 31, 2026 14:46
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

testing

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(testing): add retry logic for testing token fetch on 429/5xx - #8138
Merged
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Mar 31, 2026
Merged
fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Conversation
@jacekradko
@jacekradkojacekradko
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths
Why
fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.
Test plan
  • @clerk/testing builds successfully
  •  19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  •  Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e27ba1a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86
📥 Commits
Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.
📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts
Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko
merged commit 829583a
into
mainMar 31, 2026

42 checks passed

@jacekradko
jacekradko
deleted the

jacek/retry-testing-token

branch
March 31, 2026 14:46
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

testing

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
fix(testing): add retry logic for testing token fetch on 429/5xx - #8138
Merged
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Mar 31, 2026
Merged
fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Conversation
@jacekradko
@jacekradkojacekradko
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths
Why
fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.
Test plan
  • @clerk/testing builds successfully
  •  19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  •  Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e27ba1a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86
📥 Commits
Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.
📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts
Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko
merged commit 829583a
into
mainMar 31, 2026

42 checks passed

@jacekradko
jacekradko
deleted the

jacek/retry-testing-token

branch
March 31, 2026 14:46
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

testing

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(testing): add retry logic for testing token fetch on 429/5xx - #8138
Merged
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Mar 31, 2026
Merged
fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Conversation
@jacekradko
@jacekradkojacekradko
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths
Why
fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.
Test plan
  • @clerk/testing builds successfully
  •  19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  •  Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e27ba1a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86
📥 Commits
Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.
📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts
Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko
merged commit 829583a
into
mainMar 31, 2026

42 checks passed

@jacekradko
jacekradko
deleted the

jacek/retry-testing-token

branch
March 31, 2026 14:46
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

testing

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
fix(testing): add retry logic for testing token fetch on 429/5xx - #8138
Merged
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Mar 31, 2026
Merged
fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Conversation
@jacekradko
@jacekradkojacekradko
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths
Why
fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.
Test plan
  • @clerk/testing builds successfully
  •  19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  •  Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e27ba1a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86
📥 Commits
Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.
📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts
Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko
merged commit 829583a
into
mainMar 31, 2026

42 checks passed

@jacekradko
jacekradko
deleted the

jacek/retry-testing-token

branch
March 31, 2026 14:46
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

testing

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
fix(testing): add retry logic for testing token fetch on 429/5xx - #8138
Merged
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Mar 31, 2026
Merged
fix(testing): add retry logic for testing token fetch on 429/5xx#8138
jacekradko merged 11 commits into
mainfrom 
jacek/retry-testing-token
Conversation
@jacekradko
@jacekradkojacekradko
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
  • Adds retry with exponential backoff to the testing token fetch in @clerk/testing
  • Retries up to 5 times on transient HTTP errors (408, 429, 500, 502, 503, 504) with exponential backoff + jitter
  • Retries on network-level errors (ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN)
  • Respects Retry-After headers when provided, with all delays capped at 30s
  • Retry attempts emit warning logs with status/error code, attempt count, and wait time
  • Adds unit tests for the retry logic covering all retry/non-retry paths
Why
fetchEnvVars calls testingTokens.createTestingToken() without retry handling, causing E2E test failures when FAPI returns 429 (Too Many Requests) under concurrent test workers or when transient network issues occur against staging.
Test plan
  • @clerk/testing builds successfully
  •  19 unit tests covering retryable HTTP statuses, network errors, max retries, retryAfter handling, non-retryable errors, and existing token bypass
  •  Run E2E tests with concurrent workers to confirm 429s are retried instead of failing immediately
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: e27ba1a
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 31, 2026 0:39am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8138

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8138

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8138

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8138

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8138

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8138

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8138

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8138

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8138

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8138

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8138

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8138

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8138

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8138

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8138

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8138

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8138

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8138

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8138

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8138

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8138

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8138

commit: e27ba1a
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Added a generic fetchWithRetry(fn, label) wrapper and an isClerkAPIResponseError type guard. fetchWithRetry retries failed async operations up to MAX_RETRIES + 1 attempts when the error is a Clerk API response with status in {408, 429, 500, 502, 503, 504} or a network-like error with code in {ECONNREFUSED, ECONNRESET, ENOTFOUND, ETIMEDOUT, EAI_AGAIN}. Retry delay uses error.retryAfter (seconds→ms, capped) for Clerk errors or exponential backoff with jitter (capped) otherwise. Each retry logs a console.warn; non-retryable errors or exhausted attempts rethrow the error.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and specifically describes the main change: adding retry logic for testing token fetch on 429/5xx errors. It directly matches the changeset's primary objective.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@jacekradko

This comment was marked as resolved.

Sign in to view
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/testing/src/common/setup.ts`:
- Around line 8-45: Add unit tests for fetchWithRetry and isNetworkError: write
tests that assert isNetworkError returns true for errors with codes in
RETRYABLE_NETWORK_ERRORS and false otherwise; for fetchWithRetry, mock fn to
throw retryable API errors (status in RETRYABLE_STATUS_CODES) and network errors
to verify retries occur up to MAX_RETRIES and that the final error is thrown
when exhausted, verify that when an API error includes retryAfter (seconds) the
delay uses Math.min(retryAfter*1000, MAX_RETRY_DELAY_MS), and assert
non-retryable errors are rethrown immediately; also include a test to ensure
backoff increases (exponential + jitter) and that the console.warn message
includes the label and attempt info. Use mocks/timers to control setTimeout and
deterministic delays.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3001f82a-b12a-46fa-b95b-76b3b0471f86
📥 Commits
Reviewing files that changed from the base of the PR and between 058d27f and 4cf7693.
📒 Files selected for processing (1)
  • packages/testing/src/common/setup.ts
Comment threadpackages/testing/src/common/setup.ts
@jacekradko
jacekradko
merged commit 829583a
into
mainMar 31, 2026

42 checks passed

@jacekradko
jacekradko
deleted the

jacek/retry-testing-token

branch
March 31, 2026 14:46
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 31, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@tmilewskitmilewskitmilewski approved these changes

Assignees


No one assigned


Labels

testing

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@tmilewski