Skip to content

fix(ui): exclude internal Clerk classes from structural CSS detection - #8142

Merged
brkalow merged 2 commits into
mainfrom
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged

fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom
brkalow/fix-internal-css-warn

Conversation

@brkalow

@brkalowbrkalow commented Mar 20, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.

Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.

Type of change

  • 🐛 Bug fix

Summary by CodeRabbit

  • Tests

    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.

  • Bug Fixes

    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.

@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm

Request Review

@changeset-bot

changeset-botBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f676b14

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-newBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14

@coderabbitai

coderabbitaiBot commented Mar 20, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: f92fd818-e2f2-4839-bae3-251246a7b729

📥 Commits

Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.

📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough

Walkthrough

Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@brkalowbrkalow changed the title fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow merged commit 6fe4418 into mainMar 25, 2026
42 checks passed
@brkalow
brkalow deleted the brkalow/fix-internal-css-warn branch March 25, 2026 18:29
@clerk-cookieclerk-cookie mentioned this pull request Mar 25, 2026
Merged
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees

No one assigned

Labels

ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(ui): exclude internal Clerk classes from structural CSS detection by brkalow · Pull Request #8142 · clerk/javascript · GitHub
Skip to content
fix(ui): exclude internal Clerk classes from structural CSS detection - #8142
Merged
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged
fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Conversation
@brkalow
@brkalowbrkalow
commented
Mar 20, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.
Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.
Type of change
  •  🐛 Bug fix
Summary by CodeRabbit
  • Tests
    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.
  • Bug Fixes
    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.
@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f676b14
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f92fd818-e2f2-4839-bae3-251246a7b729
📥 Commits
Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.
📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough
Walkthrough
Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@brkalowbrkalow
changed the title
fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow
merged commit 6fe4418
into
mainMar 25, 2026

42 checks passed

@brkalow
brkalow
deleted the

brkalow/fix-internal-css-warn

branch
March 25, 2026 18:29
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 25, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(ui): exclude internal Clerk classes from structural CSS detection by brkalow · Pull Request #8142 · clerk/javascript · GitHub
Skip to content
fix(ui): exclude internal Clerk classes from structural CSS detection - #8142
Merged
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged
fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Conversation
@brkalow
@brkalowbrkalow
commented
Mar 20, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.
Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.
Type of change
  •  🐛 Bug fix
Summary by CodeRabbit
  • Tests
    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.
  • Bug Fixes
    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.
@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f676b14
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f92fd818-e2f2-4839-bae3-251246a7b729
📥 Commits
Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.
📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough
Walkthrough
Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@brkalowbrkalow
changed the title
fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow
merged commit 6fe4418
into
mainMar 25, 2026

42 checks passed

@brkalow
brkalow
deleted the

brkalow/fix-internal-css-warn

branch
March 25, 2026 18:29
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 25, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(ui): exclude internal Clerk classes from structural CSS detection by brkalow · Pull Request #8142 · clerk/javascript · GitHub
Skip to content
fix(ui): exclude internal Clerk classes from structural CSS detection - #8142
Merged
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged
fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Conversation
@brkalow
@brkalowbrkalow
commented
Mar 20, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.
Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.
Type of change
  •  🐛 Bug fix
Summary by CodeRabbit
  • Tests
    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.
  • Bug Fixes
    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.
@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f676b14
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f92fd818-e2f2-4839-bae3-251246a7b729
📥 Commits
Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.
📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough
Walkthrough
Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@brkalowbrkalow
changed the title
fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow
merged commit 6fe4418
into
mainMar 25, 2026

42 checks passed

@brkalow
brkalow
deleted the

brkalow/fix-internal-css-warn

branch
March 25, 2026 18:29
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 25, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(ui): exclude internal Clerk classes from structural CSS detection by brkalow · Pull Request #8142 · clerk/javascript · GitHub
Skip to content
fix(ui): exclude internal Clerk classes from structural CSS detection - #8142
Merged
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged
fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Conversation
@brkalow
@brkalowbrkalow
commented
Mar 20, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.
Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.
Type of change
  •  🐛 Bug fix
Summary by CodeRabbit
  • Tests
    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.
  • Bug Fixes
    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.
@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f676b14
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f92fd818-e2f2-4839-bae3-251246a7b729
📥 Commits
Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.
📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough
Walkthrough
Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@brkalowbrkalow
changed the title
fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow
merged commit 6fe4418
into
mainMar 25, 2026

42 checks passed

@brkalow
brkalow
deleted the

brkalow/fix-internal-css-warn

branch
March 25, 2026 18:29
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 25, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(ui): exclude internal Clerk classes from structural CSS detection by brkalow · Pull Request #8142 · clerk/javascript · GitHub
Skip to content
fix(ui): exclude internal Clerk classes from structural CSS detection - #8142
Merged
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged
fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Conversation
@brkalow
@brkalowbrkalow
commented
Mar 20, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.
Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.
Type of change
  •  🐛 Bug fix
Summary by CodeRabbit
  • Tests
    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.
  • Bug Fixes
    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.
@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f676b14
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f92fd818-e2f2-4839-bae3-251246a7b729
📥 Commits
Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.
📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough
Walkthrough
Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@brkalowbrkalow
changed the title
fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow
merged commit 6fe4418
into
mainMar 25, 2026

42 checks passed

@brkalow
brkalow
deleted the

brkalow/fix-internal-css-warn

branch
March 25, 2026 18:29
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 25, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(ui): exclude internal Clerk classes from structural CSS detection by brkalow · Pull Request #8142 · clerk/javascript · GitHub
Skip to content
fix(ui): exclude internal Clerk classes from structural CSS detection - #8142
Merged
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged
fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Conversation
@brkalow
@brkalowbrkalow
commented
Mar 20, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.
Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.
Type of change
  •  🐛 Bug fix
Summary by CodeRabbit
  • Tests
    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.
  • Bug Fixes
    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.
@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f676b14
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f92fd818-e2f2-4839-bae3-251246a7b729
📥 Commits
Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.
📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough
Walkthrough
Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@brkalowbrkalow
changed the title
fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow
merged commit 6fe4418
into
mainMar 25, 2026

42 checks passed

@brkalow
brkalow
deleted the

brkalow/fix-internal-css-warn

branch
March 25, 2026 18:29
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 25, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(ui): exclude internal Clerk classes from structural CSS detection by brkalow · Pull Request #8142 · clerk/javascript · GitHub
Skip to content
fix(ui): exclude internal Clerk classes from structural CSS detection - #8142
Merged
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Mar 25, 2026
Merged
fix(ui): exclude internal Clerk classes from structural CSS detection#8142
brkalow merged 2 commits into
mainfrom 
brkalow/fix-internal-css-warn
Conversation
@brkalow
@brkalowbrkalow
commented
Mar 20, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes false positives in the structural CSS warning where Clerk's own internal classes (generated by Emotion with .cl-internal-* selectors) were triggering warnings on fresh installs without any custom CSS.
Only user-authored customization targeting Clerk's public APIs should trigger the warning. Internal classes are implementation details and shouldn't be flagged. If users explicitly reference .cl-internal-* in their appearance.elements configuration, that's still warned about since it's a stability risk.
Type of change
  •  🐛 Bug fix
Summary by CodeRabbit
  • Tests
    • Added tests to ensure internal CSS class patterns (e.g., .cl-internal-*) in nested, combined, or stateful selectors are ignored by analysis.
  • Bug Fixes
    • Improved stylesheet detection to filter out internal Clerk-generated classes, preventing false-positive customization warnings on fresh installs.
@brkalow@claude
fix: exclude internal Clerk classes from structural CSS detection
73c2f22
Only user-authored customization targeting Clerk's public APIs should trigger
the structural CSS warning. Internal classes (e.g., .cl-internal-*) generated
by Emotion are implementation details and shouldn't be flagged.
However, if a user explicitly references .cl-internal-* in their
appearance.elements configuration, that's still a stability risk and will
be warned about.
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
@vercel
vercelBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 25, 2026 2:48pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f676b14
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@pkg-pr-new
pkg-pr-newBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8142

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8142

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8142

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8142

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8142

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8142

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8142

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8142

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8142

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8142

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8142

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8142

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8142

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8142

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8142

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8142

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8142

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8142

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8142

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8142

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8142

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8142

commit: f676b14
@coderabbitai
coderabbitaiBot
commented
Mar 20, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: f92fd818-e2f2-4839-bae3-251246a7b729
📥 Commits
Reviewing files that changed from the base of the PR and between 73c2f22 and f676b14.
📒 Files selected for processing (1)
  • .changeset/fix-internal-css-warn.md
📝 Walkthrough
Walkthrough
Selectors containing Clerk internal classes (.cl-internal-*) are now recognized and stripped before stylesheet analysis. A new exported regex CLERK_INTERNAL_CLASS_RE was added, and detection logic (isProbablyClerkSelector) now runs against selectors with internal-class fragments removed. Tests were added to ensure .cl-internal-* occurrences (including nested and stateful selectors) do not produce structural CSS hits or customization warnings.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately and specifically describes the main change: excluding internal Clerk classes from structural CSS detection, which is the core fix across all modified files.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@brkalowbrkalow
changed the title
fix: exclude internal Clerk classes from structural CSS detectionfix(ui): exclude internal Clerk classes from structural CSS detectionMar 25, 2026
@brkalow@claude
chore: add changeset for internal CSS warning fix
f676b14
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@brkalow
brkalow
merged commit 6fe4418
into
mainMar 25, 2026

42 checks passed

@brkalow
brkalow
deleted the

brkalow/fix-internal-css-warn

branch
March 25, 2026 18:29
@clerk-cookieclerk-cookie
mentioned this pull request
Mar 25, 2026
 Merged

wobsoriano pushed a commit
that referenced
this pull request
Mar 26, 2026
@brkalow@claude@wobsoriano
fix(ui): exclude internal Clerk classes from structural CSS detection (…
9c74957
…#8142)
Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@EphemEphemEphem approved these changes

Assignees


No one assigned


Labels

ui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@Ephem