Skip to content

Add integration test for single-session multi-tab session refresh deduplication - #8157

Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged

Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

Conversation

@Ephem

@EphemEphem commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Member

This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.

This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).

@changeset-bot

changeset-botBot commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 5daf6a8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercelBot commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am

Request Review

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7

@coderabbitai

coderabbitaiBot commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ephem
Ephemforce-pushed the fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single branch from a4d112c to e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem changed the base branch from main to jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem changed the title fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem requested a review from jacekradkoMarch 24, 2026 11:43
@EphemEphem closed this Mar 24, 2026
@EphemEphem reopened this Mar 24, 2026
jacekradko
jacekradko approved these changes Mar 24, 2026
View reviewed changes

@jacekradkojacekradko left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacekradko
jacekradko merged commit e3d0472 into jacek/fix-token-cache-timer-leakMar 24, 2026
6 of 7 checks passed
@jacekradko
jacekradko deleted the fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single branch March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

clerk-jsintegration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Add integration test for single-session multi-tab session refresh deduplication by Ephem · Pull Request #8157 · clerk/javascript · GitHub
Skip to content
Add integration test for single-session multi-tab session refresh deduplication - #8157
Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged
Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Conversation
@Ephem
@EphemEphem
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.
This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).
@changeset-bot
changeset-botBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 5daf6a8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@Ephem
Ephemforce-pushed
the
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
branch
from
a4d112c to
e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem
changed the base branch from
main
to
jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem
changed the title
fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem
requested a review
from jacekradkoMarch 24, 2026 11:43
@EphemEphem
closed this
Mar 24, 2026
@EphemEphem
reopened this
Mar 24, 2026
jacekradko
jacekradko
approved these changes
Mar 24, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@jacekradko
jacekradko
merged commit e3d0472
into
jacek/fix-token-cache-timer-leakMar 24, 2026

6 of 7 checks passed

@jacekradko
jacekradko
deleted the

fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

branch
March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsintegration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add integration test for single-session multi-tab session refresh deduplication by Ephem · Pull Request #8157 · clerk/javascript · GitHub
Skip to content
Add integration test for single-session multi-tab session refresh deduplication - #8157
Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged
Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Conversation
@Ephem
@EphemEphem
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.
This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).
@changeset-bot
changeset-botBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 5daf6a8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@Ephem
Ephemforce-pushed
the
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
branch
from
a4d112c to
e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem
changed the base branch from
main
to
jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem
changed the title
fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem
requested a review
from jacekradkoMarch 24, 2026 11:43
@EphemEphem
closed this
Mar 24, 2026
@EphemEphem
reopened this
Mar 24, 2026
jacekradko
jacekradko
approved these changes
Mar 24, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@jacekradko
jacekradko
merged commit e3d0472
into
jacek/fix-token-cache-timer-leakMar 24, 2026

6 of 7 checks passed

@jacekradko
jacekradko
deleted the

fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

branch
March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsintegration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add integration test for single-session multi-tab session refresh deduplication by Ephem · Pull Request #8157 · clerk/javascript · GitHub
Skip to content
Add integration test for single-session multi-tab session refresh deduplication - #8157
Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged
Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Conversation
@Ephem
@EphemEphem
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.
This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).
@changeset-bot
changeset-botBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 5daf6a8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@Ephem
Ephemforce-pushed
the
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
branch
from
a4d112c to
e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem
changed the base branch from
main
to
jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem
changed the title
fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem
requested a review
from jacekradkoMarch 24, 2026 11:43
@EphemEphem
closed this
Mar 24, 2026
@EphemEphem
reopened this
Mar 24, 2026
jacekradko
jacekradko
approved these changes
Mar 24, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@jacekradko
jacekradko
merged commit e3d0472
into
jacek/fix-token-cache-timer-leakMar 24, 2026

6 of 7 checks passed

@jacekradko
jacekradko
deleted the

fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

branch
March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsintegration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Add integration test for single-session multi-tab session refresh deduplication by Ephem · Pull Request #8157 · clerk/javascript · GitHub
Skip to content
Add integration test for single-session multi-tab session refresh deduplication - #8157
Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged
Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Conversation
@Ephem
@EphemEphem
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.
This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).
@changeset-bot
changeset-botBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 5daf6a8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@Ephem
Ephemforce-pushed
the
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
branch
from
a4d112c to
e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem
changed the base branch from
main
to
jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem
changed the title
fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem
requested a review
from jacekradkoMarch 24, 2026 11:43
@EphemEphem
closed this
Mar 24, 2026
@EphemEphem
reopened this
Mar 24, 2026
jacekradko
jacekradko
approved these changes
Mar 24, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@jacekradko
jacekradko
merged commit e3d0472
into
jacek/fix-token-cache-timer-leakMar 24, 2026

6 of 7 checks passed

@jacekradko
jacekradko
deleted the

fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

branch
March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsintegration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add integration test for single-session multi-tab session refresh deduplication by Ephem · Pull Request #8157 · clerk/javascript · GitHub
Skip to content
Add integration test for single-session multi-tab session refresh deduplication - #8157
Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged
Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Conversation
@Ephem
@EphemEphem
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.
This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).
@changeset-bot
changeset-botBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 5daf6a8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@Ephem
Ephemforce-pushed
the
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
branch
from
a4d112c to
e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem
changed the base branch from
main
to
jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem
changed the title
fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem
requested a review
from jacekradkoMarch 24, 2026 11:43
@EphemEphem
closed this
Mar 24, 2026
@EphemEphem
reopened this
Mar 24, 2026
jacekradko
jacekradko
approved these changes
Mar 24, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@jacekradko
jacekradko
merged commit e3d0472
into
jacek/fix-token-cache-timer-leakMar 24, 2026

6 of 7 checks passed

@jacekradko
jacekradko
deleted the

fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

branch
March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsintegration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Add integration test for single-session multi-tab session refresh deduplication by Ephem · Pull Request #8157 · clerk/javascript · GitHub
Skip to content
Add integration test for single-session multi-tab session refresh deduplication - #8157
Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged
Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Conversation
@Ephem
@EphemEphem
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.
This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).
@changeset-bot
changeset-botBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 5daf6a8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@Ephem
Ephemforce-pushed
the
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
branch
from
a4d112c to
e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem
changed the base branch from
main
to
jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem
changed the title
fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem
requested a review
from jacekradkoMarch 24, 2026 11:43
@EphemEphem
closed this
Mar 24, 2026
@EphemEphem
reopened this
Mar 24, 2026
jacekradko
jacekradko
approved these changes
Mar 24, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@jacekradko
jacekradko
merged commit e3d0472
into
jacek/fix-token-cache-timer-leakMar 24, 2026

6 of 7 checks passed

@jacekradko
jacekradko
deleted the

fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

branch
March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsintegration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Add integration test for single-session multi-tab session refresh deduplication by Ephem · Pull Request #8157 · clerk/javascript · GitHub
Skip to content
Add integration test for single-session multi-tab session refresh deduplication - #8157
Merged
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Mar 24, 2026
Merged
Add integration test for single-session multi-tab session refresh deduplication#8157
jacekradko merged 3 commits into
jacek/fix-token-cache-timer-leakfrom 
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
Conversation
@Ephem
@EphemEphem
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Member
This started as a branch to fix single-session multi-tab session refresh deduplication, but it turns out #8098 seems to fix this already.
This PR now targets the above PR-branch instead and simply adds a previously failing test that now passes (see previous e2e-run to see the failure).
@changeset-bot
changeset-botBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 5daf6a8
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
@vercel
vercelBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 0:34am
Request Review
@pkg-pr-new
pkg-pr-newBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8157

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8157

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8157

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8157

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8157

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8157

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8157

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8157

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8157

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8157

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8157

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8157

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8157

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8157

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8157

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8157

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8157

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8157

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8157

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8157

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8157

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8157

commit: e7bb3b7
@coderabbitai
coderabbitaiBot
commented
Mar 24, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
📝 Walkthrough
Walkthrough
Updates include fixes to the in-memory session token cache timer management and accompanying unit and integration tests. MemoryTokenCache.setInternal was changed to clear stale timers and avoid installing timers for overwritten entries. New and updated Playwright integration tests exercise multi-tab token refresh deduplication and timer cleanup; core unit tests verify timer cancellation on overwrite. A changeset documents a patch release and a TypeDoc link-rewrite target was adjusted.
🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: adding integration tests for multi-tab session refresh deduplication, which is the primary focus of the file changes.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@Ephem
Ephemforce-pushed
the
fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single
branch
from
a4d112c to
e7bb3b7CompareMarch 24, 2026 11:39
@Ephem
Ephem
changed the base branch from
main
to
jacek/fix-token-cache-timer-leakMarch 24, 2026 11:40
@EphemEphem
changed the title
fix(clerk-js): dedupe token refresh requests in single-session multi-tab scenariosAdd integration test for single-session multi-tab session refresh deduplicationMar 24, 2026
@Ephem
Ephem
requested a review
from jacekradkoMarch 24, 2026 11:43
@EphemEphem
closed this
Mar 24, 2026
@EphemEphem
reopened this
Mar 24, 2026
jacekradko
jacekradko
approved these changes
Mar 24, 2026
View reviewed changes
@jacekradkojacekradko
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
@jacekradko
jacekradko
merged commit e3d0472
into
jacek/fix-token-cache-timer-leakMar 24, 2026

6 of 7 checks passed

@jacekradko
jacekradko
deleted the

fredrik/sdk-19-fix-tokens-being-called-in-multiple-tabs-for-a-single

branch
March 24, 2026 14:09
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

clerk-jsintegration

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@Ephem@jacekradko@SarahSoutoul