Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(backend): prevent Content-Encoding mismatch in proxy responses by brkalow · Pull Request #8159 · clerk/javascript · GitHub
Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(backend): prevent Content-Encoding mismatch in proxy responses by brkalow · Pull Request #8159 · clerk/javascript · GitHub
Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(backend): prevent Content-Encoding mismatch in proxy responses by brkalow · Pull Request #8159 · clerk/javascript · GitHub
Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(backend): prevent Content-Encoding mismatch in proxy responses by brkalow · Pull Request #8159 · clerk/javascript · GitHub
Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(backend): prevent Content-Encoding mismatch in proxy responses by brkalow · Pull Request #8159 · clerk/javascript · GitHub
Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(backend): prevent Content-Encoding mismatch in proxy responses by brkalow · Pull Request #8159 · clerk/javascript · GitHub
Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(backend): prevent Content-Encoding mismatch in proxy responses by brkalow · Pull Request #8159 · clerk/javascript · GitHub
Skip to content

fix(backend): prevent Content-Encoding mismatch in proxy responses - #8159

Merged
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding
Mar 25, 2026
Merged

fix(backend): prevent Content-Encoding mismatch in proxy responses#8159
brkalow merged 4 commits into
mainfrom
brkalow/fix-proxy-content-encoding

Conversation

@brkalow

@brkalowbrkalow commented Mar 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Accept-Encoding: identity on outbound proxy requests to avoid a double compression pass (FAPI compresses → fetch decompresses → edge re-compresses)
  • Defensively strips Content-Encoding and Content-Length from proxied responses since fetch() auto-decompresses the body, making those headers inaccurate
  • Fixes ERR_CONTENT_DECODING_FAILED errors when loading proxied assets like clerk.browser.js

Test plan

  • Verify proxied JS assets (e.g. /__clerk/npm/@clerk/clerk-js/.../clerk.browser.js) load without ERR_CONTENT_DECODING_FAILED
  • Verify proxy still works for API requests (/__clerk/v1/client, etc.)
  • Verify OAuth redirect flows still work through the proxy (Location header rewriting)
  • Run @clerk/backend unit tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes

    • Prevented content-decoding errors by requesting uncompressed upstream responses and stripping Content-Encoding and Content-Length from proxied responses.
  • Tests

    • Added tests ensuring outgoing requests request uncompressed content and that compression/length headers are removed from proxied responses.
  • Chores

    • Added a patch release entry describing the fix.

fetch() auto-decompresses response bodies but may leave Content-Encoding
and Content-Length headers intact, causing ERR_CONTENT_DECODING_FAILED
in the browser. Fix with two layers:
1. Request `Accept-Encoding: identity` upstream to avoid a double
compression pass (FAPI → fetch decompresses → edge re-compresses)
2. Defensively strip Content-Encoding and Content-Length from responses
since servers may ignore the identity hint
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel

vercelBot commented Mar 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMar 24, 2026 4:58pm

Request Review

@changeset-bot

changeset-botBot commented Mar 24, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8889621

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
NameType
@clerk/backendPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Mar 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: bf197657-634c-4d7a-8ded-47a493974bf2

📥 Commits

Reviewing files that changed from the base of the PR and between 17bd235 and 8889621.

📒 Files selected for processing (1)
  • packages/backend/src/proxy.ts

📝 Walkthrough

Walkthrough

The PR sets Accept-Encoding: identity on upstream requests, adds RESPONSE_HEADERS_TO_STRIP to drop content-encoding and content-length from proxied responses, and extends hop-by-hop header filtering to include those headers. The proxy now constructs a Response object and explicitly deletes content-encoding and content-length from its headers before returning. Two tests were added: one asserting the outgoing request uses Accept-Encoding: identity, and another asserting Content-Encoding and Content-Length are removed from upstream responses. A changeset for a patch release was added.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately summarizes the main change: preventing Content-Encoding mismatches in proxy responses by requesting uncompressed responses and stripping encoding headers.
Docstring Coverage✅ PassedDocstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 24, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8159

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8159

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8159

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8159

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8159

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8159

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8159

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8159

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8159

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8159

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8159

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8159

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8159

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8159

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8159

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8159

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8159

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8159

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8159

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8159

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8159

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8159

commit: 8889621

…ruction
Some runtimes (e.g. Node 20) may re-add Content-Length when constructing
a Response from a ReadableStream body. Delete Content-Encoding and
Content-Length explicitly after construction to ensure they're stripped.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Comment threadpackages/backend/src/proxy.ts Outdated
@brkalow
brkalow merged commit 0288931 into mainMar 25, 2026
44 checks passed
@brkalow
brkalow deleted the brkalow/fix-proxy-content-encoding branch March 25, 2026 02:32
wobsoriano pushed a commit that referenced this pull request Mar 26, 2026
…8159)
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brkalow@wobsoriano