Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(clerk-js): static QueryClient import in native entry point by jacekradko · Pull Request #8170 · clerk/javascript · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(clerk-js): static QueryClient import in native entry point by jacekradko · Pull Request #8170 · clerk/javascript · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(clerk-js): static QueryClient import in native entry point by jacekradko · Pull Request #8170 · clerk/javascript · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(clerk-js): static QueryClient import in native entry point by jacekradko · Pull Request #8170 · clerk/javascript · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(clerk-js): static QueryClient import in native entry point by jacekradko · Pull Request #8170 · clerk/javascript · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(clerk-js): static QueryClient import in native entry point by jacekradko · Pull Request #8170 · clerk/javascript · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(clerk-js): static QueryClient import in native entry point by jacekradko · Pull Request #8170 · clerk/javascript · GitHub
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .changeset/fix-query-client-rn.md
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
---
"@clerk/expo": patch
"@clerk/clerk-js": patch
---

Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by synchronously providing a `QueryClient` instance
Fix `useOrganizationList` and other query-based hooks returning empty data on React Native by statically importing `QueryClient` in the native bundle entry point
2 changes: 1 addition & 1 deletion packages/clerk-js/rspack.config.js
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,7 +22,7 @@ const variantToSourceFile = {
[variants.clerk]: './src/index.ts',
[variants.clerkNoRHC]: './src/index.ts',
[variants.clerkBrowser]: './src/index.browser.ts',
[variants.clerkNative]: './src/index.ts',
[variants.clerkNative]: './src/index.native.ts',
[variants.clerkLegacyBrowser]: './src/index.legacy.browser.ts',
};

Expand Down
53 changes: 53 additions & 0 deletions packages/clerk-js/src/__tests__/index.native.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
import { QueryClient } from '@tanstack/query-core';
import { beforeEach, describe, expect, it, vi } from 'vitest';

vi.mock('../core/resources/Client');
vi.mock('../core/resources/Environment');

describe('index.native', () => {
beforeEach(() => {
vi.resetModules();
});

it('overrides __internal_queryClient to return synchronously', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const result = clerk.__internal_queryClient;

expect(result).toBeDefined();
expect(result?.__tag).toBe('clerk-rq-client');
expect(result?.client).toBeInstanceOf(QueryClient);
});

it('returns the same QueryClient instance on subsequent accesses', async () => {
const { Clerk } = await import('../index.native');
const clerk = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const first = clerk.__internal_queryClient;
const second = clerk.__internal_queryClient;

expect(first?.client).toBe(second?.client);
});

it('returns different QueryClient instances for different Clerk instances', async () => {
const { Clerk } = await import('../index.native');
const clerk1 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');
const clerk2 = new Clerk('pk_test_Y2xlcmsuZXhhbXBsZS5jb20k');

const client1 = clerk1.__internal_queryClient;
const client2 = clerk2.__internal_queryClient;

expect(client1?.client).not.toBe(client2?.client);
});

it('exports the same public API as the base entry point', async () => {
const nativeExports = await import('../index.native');
const baseExports = await import('../index');

const nativeKeys = Object.keys(nativeExports).sort();
const baseKeys = Object.keys(baseExports).sort();

expect(nativeKeys).toEqual(baseKeys);
});
});
27 changes: 27 additions & 0 deletions packages/clerk-js/src/index.native.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
import { QueryClient } from '@tanstack/query-core';

import { Clerk } from './core/clerk';

// The default Clerk class lazily loads QueryClient via a dynamic import.
// In React Native, rspack's chunk loading doesn't work (Metro bundles into
// a single file), so the dynamic import never resolves and
// __internal_queryClient stays undefined — breaking hooks that depend on it.
// Override the getter to synchronously create a QueryClient on first access.
const originalDescriptor = Object.getOwnPropertyDescriptor(Clerk.prototype, '__internal_queryClient');
if (originalDescriptor) {
const queryClientMap = new WeakMap<InstanceType<typeof Clerk>, QueryClient>();
Object.defineProperty(Clerk.prototype, '__internal_queryClient', {
get(this: InstanceType<typeof Clerk>) {
let client = queryClientMap.get(this);
if (!client) {
client = new QueryClient();
queryClientMap.set(this, client);
}
return { __tag: 'clerk-rq-client', client };
},
configurable: true,
});
}

// Re-export everything from the base entry point to avoid duplicating exports.
export * from './index';
1 change: 0 additions & 1 deletion packages/expo/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -114,7 +114,6 @@
"@clerk/clerk-js": "workspace:^",
"@clerk/react": "workspace:^",
"@clerk/shared": "workspace:^",
"@tanstack/query-core": "5.90.16",
"base-64": "^1.0.0",
"react-native-url-polyfill": "2.0.0",
"tslib": "catalog:repo"
Expand Down
20 changes: 0 additions & 20 deletions packages/expo/src/provider/singleton/createClerkInstance.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -112,26 +112,6 @@ export function createClerkInstance(ClerkClass: typeof Clerk) {
__internal_clerkOptions = { publishableKey, proxyUrl, domain };
__internal_clerk = new ClerkClass(publishableKey, { proxyUrl, domain }) as unknown as BrowserClerk;

// The clerk-js native bundle uses rspack code-splitting for the internal QueryClient.
// On React Native, rspack's chunk loading doesn't work (Metro bundles into a single file),
// so the dynamic import never resolves and __internal_queryClient stays undefined.
// This breaks hooks that depend on the query client (useOrganizationList, etc.).
// Override the getter to synchronously create a QueryClient on first access.
{
// eslint-disable-next-line @typescript-eslint/no-require-imports
const { QueryClient } = require('@tanstack/query-core');
let queryClient: InstanceType<typeof QueryClient> | undefined;
Object.defineProperty(__internal_clerk, '__internal_queryClient', {
get() {
if (!queryClient) {
queryClient = new QueryClient();
}
return { __tag: 'clerk-rq-client', client: queryClient };
},
configurable: true,
});
}

if (Platform.OS === 'ios' || Platform.OS === 'android') {
// @ts-expect-error - This is an internal API
__internal_clerk.__internal_createPublicCredentials = (
Expand Down
3 changes: 0 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading