Skip to content

fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203

Merged
LauraBeatris merged 4 commits into
mainfrom
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged

fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom
laura/fix-enterprise-account-connect-dropdown-2

Conversation

@LauraBeatris

@LauraBeatrisLauraBeatris commented Mar 30, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.

  • Updates

    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.

  • Tests

    • Updated tests to reflect the revised enterprise connection payload shape.

@LauraBeatrisLauraBeatris self-assigned this Mar 30, 2026
@vercel

vercelBot commented Mar 30, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm

Request Review

@changeset-bot

changeset-botBot commented Mar 30, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 70f5273

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-enterprise-account-connect-dropdown-2 branch from c1ab77b to 3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-enterprise-account-connect-dropdown-2 branch from 8310f2b to 62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris changed the title fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-enterprise-account-connect-dropdown-2 branch from 62d4812 to fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris marked this pull request as ready for review March 31, 2026 21:22
@LauraBeatris
LauraBeatris requested a review from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-enterprise-account-connect-dropdown-2 branch from fcf8917 to dee595eCompareMarch 31, 2026 21:23
@coderabbitai

coderabbitaiBot commented Mar 31, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Mar 31, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273

coderabbitai[bot]
coderabbitaiBot reviewed Mar 31, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8

📥 Commits

Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.

📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment on lines +54 to +55
const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
const providerIconUrl = connection.logoPublicUrl?.trim() || '';

@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Add regression tests for the new enterprise icon resolution path before merge.

This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.

As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."

Also applies to: 76-83

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris enabled auto-merge (squash) April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-enterprise-account-connect-dropdown-2 branch from 5f41aa2 to ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed the laura/fix-enterprise-account-connect-dropdown-2 branch from ef9d201 to 70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris merged commit b289566 into mainApr 1, 2026
43 of 44 checks passed
@LauraBeatris
LauraBeatris deleted the laura/fix-enterprise-account-connect-dropdown-2 branch April 1, 2026 13:31
@clerk-cookieclerk-cookie mentioned this pull request Apr 1, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
+2 more reviewers
@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown by LauraBeatris · Pull Request #8203 · clerk/javascript · GitHub
Skip to content
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203
Merged
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Mar 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.
  • Updates
    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.
  • Tests
    • Updated tests to reflect the revised enterprise connection payload shape.
@LauraBeatrisLauraBeatris
self-assigned this
Mar 30, 2026
@vercel
vercelBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 70f5273
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
c1ab77b to
3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
8310f2b to
62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris
changed the title
fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
62d4812 to
fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
March 31, 2026 21:22
@LauraBeatris
LauraBeatris
requested a review
from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
fcf8917 to
dee595eCompareMarch 31, 2026 21:23
@coderabbitai
coderabbitaiBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
Pull request was closed or merged during review
📝 Walkthrough
Walkthrough
The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8
📥 Commits
Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.
📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment on lines

+54
 to 
+55

 const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
 const providerIconUrl = connection.logoPublicUrl?.trim() || '';
@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
Add regression tests for the new enterprise icon resolution path before merge.
This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.
As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
Also applies to: 76-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris
enabled auto-merge (squash)
April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
5f41aa2 to
ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
ef9d201 to
70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris
merged commit b289566
into
mainApr 1, 2026

43 of 44 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-enterprise-account-connect-dropdown-2

branch
April 1, 2026 13:31
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown by LauraBeatris · Pull Request #8203 · clerk/javascript · GitHub
Skip to content
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203
Merged
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Mar 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.
  • Updates
    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.
  • Tests
    • Updated tests to reflect the revised enterprise connection payload shape.
@LauraBeatrisLauraBeatris
self-assigned this
Mar 30, 2026
@vercel
vercelBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 70f5273
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
c1ab77b to
3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
8310f2b to
62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris
changed the title
fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
62d4812 to
fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
March 31, 2026 21:22
@LauraBeatris
LauraBeatris
requested a review
from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
fcf8917 to
dee595eCompareMarch 31, 2026 21:23
@coderabbitai
coderabbitaiBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
Pull request was closed or merged during review
📝 Walkthrough
Walkthrough
The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8
📥 Commits
Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.
📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment on lines

+54
 to 
+55

 const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
 const providerIconUrl = connection.logoPublicUrl?.trim() || '';
@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
Add regression tests for the new enterprise icon resolution path before merge.
This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.
As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
Also applies to: 76-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris
enabled auto-merge (squash)
April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
5f41aa2 to
ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
ef9d201 to
70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris
merged commit b289566
into
mainApr 1, 2026

43 of 44 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-enterprise-account-connect-dropdown-2

branch
April 1, 2026 13:31
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown by LauraBeatris · Pull Request #8203 · clerk/javascript · GitHub
Skip to content
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203
Merged
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Mar 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.
  • Updates
    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.
  • Tests
    • Updated tests to reflect the revised enterprise connection payload shape.
@LauraBeatrisLauraBeatris
self-assigned this
Mar 30, 2026
@vercel
vercelBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 70f5273
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
c1ab77b to
3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
8310f2b to
62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris
changed the title
fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
62d4812 to
fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
March 31, 2026 21:22
@LauraBeatris
LauraBeatris
requested a review
from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
fcf8917 to
dee595eCompareMarch 31, 2026 21:23
@coderabbitai
coderabbitaiBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
Pull request was closed or merged during review
📝 Walkthrough
Walkthrough
The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8
📥 Commits
Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.
📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment on lines

+54
 to 
+55

 const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
 const providerIconUrl = connection.logoPublicUrl?.trim() || '';
@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
Add regression tests for the new enterprise icon resolution path before merge.
This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.
As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
Also applies to: 76-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris
enabled auto-merge (squash)
April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
5f41aa2 to
ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
ef9d201 to
70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris
merged commit b289566
into
mainApr 1, 2026

43 of 44 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-enterprise-account-connect-dropdown-2

branch
April 1, 2026 13:31
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown by LauraBeatris · Pull Request #8203 · clerk/javascript · GitHub
Skip to content
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203
Merged
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Mar 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.
  • Updates
    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.
  • Tests
    • Updated tests to reflect the revised enterprise connection payload shape.
@LauraBeatrisLauraBeatris
self-assigned this
Mar 30, 2026
@vercel
vercelBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 70f5273
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
c1ab77b to
3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
8310f2b to
62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris
changed the title
fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
62d4812 to
fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
March 31, 2026 21:22
@LauraBeatris
LauraBeatris
requested a review
from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
fcf8917 to
dee595eCompareMarch 31, 2026 21:23
@coderabbitai
coderabbitaiBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
Pull request was closed or merged during review
📝 Walkthrough
Walkthrough
The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8
📥 Commits
Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.
📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment on lines

+54
 to 
+55

 const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
 const providerIconUrl = connection.logoPublicUrl?.trim() || '';
@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
Add regression tests for the new enterprise icon resolution path before merge.
This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.
As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
Also applies to: 76-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris
enabled auto-merge (squash)
April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
5f41aa2 to
ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
ef9d201 to
70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris
merged commit b289566
into
mainApr 1, 2026

43 of 44 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-enterprise-account-connect-dropdown-2

branch
April 1, 2026 13:31
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown by LauraBeatris · Pull Request #8203 · clerk/javascript · GitHub
Skip to content
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203
Merged
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Mar 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.
  • Updates
    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.
  • Tests
    • Updated tests to reflect the revised enterprise connection payload shape.
@LauraBeatrisLauraBeatris
self-assigned this
Mar 30, 2026
@vercel
vercelBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 70f5273
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
c1ab77b to
3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
8310f2b to
62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris
changed the title
fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
62d4812 to
fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
March 31, 2026 21:22
@LauraBeatris
LauraBeatris
requested a review
from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
fcf8917 to
dee595eCompareMarch 31, 2026 21:23
@coderabbitai
coderabbitaiBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
Pull request was closed or merged during review
📝 Walkthrough
Walkthrough
The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8
📥 Commits
Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.
📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment on lines

+54
 to 
+55

 const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
 const providerIconUrl = connection.logoPublicUrl?.trim() || '';
@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
Add regression tests for the new enterprise icon resolution path before merge.
This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.
As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
Also applies to: 76-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris
enabled auto-merge (squash)
April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
5f41aa2 to
ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
ef9d201 to
70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris
merged commit b289566
into
mainApr 1, 2026

43 of 44 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-enterprise-account-connect-dropdown-2

branch
April 1, 2026 13:31
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown by LauraBeatris · Pull Request #8203 · clerk/javascript · GitHub
Skip to content
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203
Merged
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Mar 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.
  • Updates
    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.
  • Tests
    • Updated tests to reflect the revised enterprise connection payload shape.
@LauraBeatrisLauraBeatris
self-assigned this
Mar 30, 2026
@vercel
vercelBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 70f5273
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
c1ab77b to
3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
8310f2b to
62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris
changed the title
fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
62d4812 to
fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
March 31, 2026 21:22
@LauraBeatris
LauraBeatris
requested a review
from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
fcf8917 to
dee595eCompareMarch 31, 2026 21:23
@coderabbitai
coderabbitaiBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
Pull request was closed or merged during review
📝 Walkthrough
Walkthrough
The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8
📥 Commits
Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.
📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment on lines

+54
 to 
+55

 const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
 const providerIconUrl = connection.logoPublicUrl?.trim() || '';
@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
Add regression tests for the new enterprise icon resolution path before merge.
This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.
As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
Also applies to: 76-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris
enabled auto-merge (squash)
April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
5f41aa2 to
ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
ef9d201 to
70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris
merged commit b289566
into
mainApr 1, 2026

43 of 44 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-enterprise-account-connect-dropdown-2

branch
April 1, 2026 13:31
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown by LauraBeatris · Pull Request #8203 · clerk/javascript · GitHub
Skip to content
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown - #8203
Merged
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Apr 1, 2026
Merged
fix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdown#8203
LauraBeatris merged 4 commits into
mainfrom 
laura/fix-enterprise-account-connect-dropdown-2
Conversation
@LauraBeatris
@LauraBeatrisLauraBeatris
commented
Mar 30, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Contributor
Description
This PR adds provider and logoPublicUrl to EnterpriseConnection resource and uses it on the enterprise connections dropdown within UserProfile
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • New Features
    • Enterprise connection icons with provider logos now appear in the account linking dropdown inside UserProfile.
  • Updates
    • Enterprise connections now include provider names and logo URLs so provider identity and logos are available in the UI.
  • Tests
    • Updated tests to reflect the revised enterprise connection payload shape.
@LauraBeatrisLauraBeatris
self-assigned this
Mar 30, 2026
@vercel
vercelBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 1:23pm
Request Review
@changeset-bot
changeset-botBot
commented
Mar 30, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 70f5273
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 21 packages
NameType
@clerk/clerk-jsPatch
@clerk/sharedPatch
@clerk/uiPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch
@clerk/agent-toolkitPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/expo-passkeysPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
c1ab77b to
3786999CompareMarch 30, 2026 17:50
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
8310f2b to
62d4812CompareMarch 31, 2026 21:20
@LauraBeatrisLauraBeatris
changed the title
fix(clerk-js,ui): Display enterprise connection icon on account linking dropdownfix(clerk-js,ui,shared): Display enterprise connection icon on account linking dropdownMar 31, 2026
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
62d4812 to
fcf8917CompareMarch 31, 2026 21:22
@LauraBeatris
LauraBeatris
marked this pull request as ready for review
March 31, 2026 21:22
@LauraBeatris
LauraBeatris
requested a review
from a teamMarch 31, 2026 21:22
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
fcf8917 to
dee595eCompareMarch 31, 2026 21:23
@coderabbitai
coderabbitaiBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Caution
Review failed
Pull request was closed or merged during review
📝 Walkthrough
Walkthrough
The pull request adds provider and logoPublicUrl to the EnterpriseConnection resource (shared types and clerk-js class), includes JSON deserialization and snapshot serialization for those fields, and updates the UI Account Linking component to derive provider icon id from provider and use logoPublicUrl for the icon URL. Changesets for patch releases were added for the affected packages.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly identifies the main change: adding provider and logoPublicUrl fields to EnterpriseConnection to display enterprise connection icons in the account linking dropdown UI.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Mar 31, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/agent-toolkit
npm i https://pkg.pr.new/@clerk/agent-toolkit@8203

@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8203

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8203

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8203

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8203

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8203

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8203

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8203

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8203

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8203

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8203

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8203

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8203

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8203

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8203

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8203

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8203

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8203

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8203

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8203

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8203

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8203

commit: 70f5273
coderabbitai[bot]
coderabbitaiBot
reviewed
Mar 31, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx`:
- Around line 54-55: Add regression tests for EnterpriseAccountsSection to cover
the new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: ASSERTIVE
Plan: Pro
Run ID: cf45c294-5e82-4ab4-882e-e20b33e3b2d8
📥 Commits
Reviewing files that changed from the base of the PR and between cfb8cbe and dee595e.
📒 Files selected for processing (5)
  • .changeset/cozy-lands-grow.md
  • .changeset/polite-camels-chew.md
  • packages/clerk-js/src/core/resources/EnterpriseConnection.ts
  • packages/shared/src/types/enterpriseConnection.ts
  • packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx
Comment threadpackages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx

Comment on lines

+54
 to 
+55

 const providerIconId = connection.provider.replace(/(oauth_|saml_)/, '').trim() as OAuthProvider;
 const providerIconUrl = connection.logoPublicUrl?.trim() || '';
@coderabbitaicoderabbitaiBotMar 31, 2026

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major
Add regression tests for the new enterprise icon resolution path before merge.
This introduces new runtime behavior (connection.provider normalization + connection.logoPublicUrl icon source) but no tests were added/updated to cover OAuth/SAML provider values and empty-logo fallback, which leaves this UI path unprotected against regressions.
As per coding guidelines, "**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."
Also applies to: 76-83
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/ui/src/components/UserProfile/EnterpriseAccountsSection.tsx` around
lines 54 - 55, Add regression tests for EnterpriseAccountsSection to cover the
new provider normalization and logo fallback behavior: write unit/tests that
render the component (or call the helper logic) with connection.provider values
like "oauth_google", "saml_okta", and bare provider names to assert
providerIconId is normalized correctly, and tests that provide
connection.logoPublicUrl as a non-empty string and as empty/undefined to assert
providerIconUrl falls back to the expected empty string or default path; target
the code paths referenced by providerIconId and providerIconUrl (and the similar
logic around lines 76-83) so OAuth/SAML normalization and empty-logo fallback
are covered.

@LauraBeatris
LauraBeatris
enabled auto-merge (squash)
April 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
5f41aa2 to
ef9d201CompareApril 1, 2026 13:16
@LauraBeatris
LauraBeatrisforce-pushed
the
laura/fix-enterprise-account-connect-dropdown-2
branch
from
ef9d201 to
70f5273CompareApril 1, 2026 13:23
@LauraBeatris
LauraBeatris
merged commit b289566
into
mainApr 1, 2026

43 of 44 checks passed

@LauraBeatris
LauraBeatris
deleted the

laura/fix-enterprise-account-connect-dropdown-2

branch
April 1, 2026 13:31
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 1, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+2 more reviewers

@iagodahlemiagodahlemiagodahlem approved these changes
@anagstefanagstefanagstef approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LauraBeatrisLauraBeatris

Labels

clerk-jsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@LauraBeatris@iagodahlem@anagstef