Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
352 changes: 352 additions & 0 deletions integration/tests/express/machine.test.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,352 @@
import type { User } from '@clerk/backend';
import { createClerkClient } from '@clerk/backend';
import { TokenType } from '@clerk/backend/internal';
import { expect, test } from '@playwright/test';

import type { Application } from '../../models/application';
import { appConfigs } from '../../presets';
import { instanceKeys } from '../../presets/envs';
import type { FakeAPIKey, FakeMachineNetwork, FakeOAuthApp, FakeUser } from '../../testUtils';
import {
createFakeMachineNetwork,
createFakeOAuthApp,
createJwtM2MToken,
createTestUtils,
obtainOAuthAccessToken,
} from '../../testUtils';

test.describe('Express machine authentication @machine', () => {
test.describe('API key auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeBapiUser: User;
let fakeAPIKey: FakeAPIKey;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/me', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'api_key' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
fakeBapiUser = await u.services.users.createBapiUser(fakeUser);
fakeAPIKey = await u.services.users.createFakeAPIKey(fakeBapiUser.id);
});

test.afterAll(async () => {
await fakeAPIKey.revoke();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('should return 401 if no API key is provided', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('should return 401 if API key is invalid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_key' },
});
expect(res.status()).toBe(401);
});

test('should return 200 with auth object if API key is valid', async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: {
Authorization: `Bearer ${fakeAPIKey.secret}`,
},
});
const apiKeyData = await res.json();
expect(res.status()).toBe(200);
expect(apiKeyData.userId).toBe(fakeBapiUser.id);
expect(apiKeyData.tokenType).toBe(TokenType.ApiKey);
});

for (const [tokenType, token] of [
['M2M', 'mt_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on API key route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/me', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
Comment on lines +99 to +110

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Use real cross-type tokens in these mismatch assertions.

These cases only send hard-coded placeholder strings, so they re-test the existing invalid-token path instead of proving that acceptsToken rejects a valid token of the wrong kind. If type enforcement regressed but verification still rejected unknown strings, this suite would stay green. Please use real API key, M2M, and OAuth tokens across these tables.

Also applies to: 230-240, 339-350

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@integration/tests/express/machine.test.ts` around lines 99 - 110, The tests
iterate over token types but use hard-coded placeholder strings (e.g.,
'mt_test_mismatch', 'oat_test_mismatch'), so they only exercise invalid-token
behavior instead of verifying that acceptsToken rejects a valid token of the
wrong kind; update the table loop in the tests named `rejects ${tokenType} token
on API key route (token type mismatch)` to supply real, valid tokens of the
other types (generate a real M2M token, OAuth token, and API key token using
your existing test helpers such as
createM2MToken/createOAuthToken/createApiKeyToken or the project’s token fixture
functions) and assert 401 for /api/me; apply the same fix to the other two
mismatch tables referenced in the comment (lines ~230-240 and ~339-350) so each
mismatch case uses a valid token of the wrong type rather than a placeholder
string.

});

test.describe('M2M auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let network: FakeMachineNetwork;

test.beforeAll(async () => {
test.setTimeout(120_000);

const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
network = await createFakeMachineNetwork(client);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/m2m', (req, res) => {
const { subject, tokenType, isAuthenticated } = getAuth(req, { acceptsToken: 'm2m_token' });
if (!isAuthenticated) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ subject, tokenType });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();

const env = appConfigs.envs.withAPIKeys
.clone()
.setEnvVariable('private', 'CLERK_MACHINE_SECRET_KEY', network.primaryServer.secretKey);
await app.withEnv(env);
await app.dev();
});

test.afterAll(async () => {
await network.cleanup();
await app.teardown();
});

test('rejects requests with invalid M2M tokens', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m');
expect(res.status()).toBe(401);

const res2 = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: 'Bearer mt_xxx' },
});
expect(res2.status()).toBe(401);
});

test('rejects M2M requests when sender machine lacks access to receiver machine', async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.unscopedSenderToken.token}` },
});
expect(res.status()).toBe(401);
});

test('authorizes M2M requests when sender machine has proper access', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${network.scopedSenderToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

test('authorizes after dynamically granting scope', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

await u.services.clerk.machines.createScope(network.unscopedSender.id, network.primaryServer.id);
const m2mToken = await u.services.clerk.m2m.createToken({
machineSecretKey: network.unscopedSender.secretKey,
secondsUntilExpiration: 60 * 30,
});

const res = await u.page.request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${m2mToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.unscopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
await u.services.clerk.m2m.revokeToken({ m2mTokenId: m2mToken.id });
});

test('verifies JWT format M2M token via local verification', async ({ request }) => {
const client = createClerkClient({
secretKey: instanceKeys.get('with-api-keys').sk,
});
const jwtToken = await createJwtM2MToken(client, network.scopedSender.secretKey);

const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${jwtToken.token}` },
});
expect(res.status()).toBe(200);
const body = await res.json();
expect(body.subject).toBe(network.scopedSender.id);
expect(body.tokenType).toBe(TokenType.M2MToken);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['OAuth', 'oat_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on M2M route (token type mismatch)`, async ({ request }) => {
const res = await request.get(app.serverUrl + '/api/m2m', {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});

test.describe('OAuth auth', () => {
test.describe.configure({ mode: 'parallel' });
let app: Application;
let fakeUser: FakeUser;
let fakeOAuth: FakeOAuthApp;

test.beforeAll(async () => {
test.setTimeout(120_000);

app = await appConfigs.express.vite
.clone()
.addFile(
'src/server/main.ts',
() => `
import 'dotenv/config';
import { clerkMiddleware, getAuth } from '@clerk/express';
import express from 'express';
import ViteExpress from 'vite-express';

const app = express();
app.use(clerkMiddleware({ publishableKey: process.env.VITE_CLERK_PUBLISHABLE_KEY }));

app.get('/api/oauth-verify', (req, res) => {
const { userId, tokenType } = getAuth(req, { acceptsToken: 'oauth_token' });
if (!userId) {
return res.status(401).json({ error: 'Unauthorized' });
}
return res.json({ userId, tokenType });
});

app.get('/api/oauth/callback', (req, res) => {
return res.json({ message: 'OAuth callback received' });
});

const port = parseInt(process.env.PORT) || 3002;
ViteExpress.listen(app, port, () => console.log('Server is listening on port ' + port));
`,
)
.commit();

await app.setup();
await app.withEnv(appConfigs.envs.withAPIKeys);
await app.dev();

const u = createTestUtils({ app });
fakeUser = u.services.users.createFakeUser();
await u.services.users.createBapiUser(fakeUser);

const clerkClient = createClerkClient({
secretKey: app.env.privateVariables.get('CLERK_SECRET_KEY'),
publishableKey: app.env.publicVariables.get('CLERK_PUBLISHABLE_KEY'),
});

fakeOAuth = await createFakeOAuthApp(clerkClient, `${app.serverUrl}/api/oauth/callback`);
});

test.afterAll(async () => {
await fakeOAuth.cleanup();
await fakeUser.deleteIfExists();
await app.teardown();
});

test('verifies valid OAuth access token obtained through authorization flow', async ({ page, context }) => {
const u = createTestUtils({ app, page, context });

const accessToken = await obtainOAuthAccessToken({
page: u.page,
oAuthApp: fakeOAuth.oAuthApp,
redirectUri: `${app.serverUrl}/api/oauth/callback`,
fakeUser,
signIn: u.po.signIn,
});

const res = await u.page.request.get(new URL('/api/oauth-verify', app.serverUrl).toString(), {
headers: { Authorization: `Bearer ${accessToken}` },
});
expect(res.status()).toBe(200);
const authData = await res.json();
expect(authData.userId).toBeDefined();
expect(authData.tokenType).toBe(TokenType.OAuthToken);
});

test('rejects request without OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString());
expect(res.status()).toBe(401);
});

test('rejects request with invalid OAuth token', async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: 'Bearer invalid_oauth_token' },
});
expect(res.status()).toBe(401);
});

for (const [tokenType, token] of [
['API key', 'ak_test_mismatch'],
['M2M', 'mt_test_mismatch'],
] as const) {
test(`rejects ${tokenType} token on OAuth route (token type mismatch)`, async ({ request }) => {
const url = new URL('/api/oauth-verify', app.serverUrl);
const res = await request.get(url.toString(), {
headers: { Authorization: `Bearer ${token}` },
});
expect(res.status()).toBe(401);
});
}
});
});
Loading
Loading