Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
chore(express,hono): Add machine auth integration tests by wobsoriano · Pull Request #8222 · clerk/javascript · GitHub
Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(express,hono): Add machine auth integration tests by wobsoriano · Pull Request #8222 · clerk/javascript · GitHub
Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(express,hono): Add machine auth integration tests by wobsoriano · Pull Request #8222 · clerk/javascript · GitHub
Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' chore(express,hono): Add machine auth integration tests by wobsoriano · Pull Request #8222 · clerk/javascript · GitHub
Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(express,hono): Add machine auth integration tests by wobsoriano · Pull Request #8222 · clerk/javascript · GitHub
Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' chore(express,hono): Add machine auth integration tests by wobsoriano · Pull Request #8222 · clerk/javascript · GitHub
Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); chore(express,hono): Add machine auth integration tests by wobsoriano · Pull Request #8222 · clerk/javascript · GitHub
Skip to content

chore(express,hono): Add machine auth integration tests - #8222

Merged
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono
Apr 2, 2026
Merged

chore(express,hono): Add machine auth integration tests#8222
wobsoriano merged 8 commits into
mainfrom
rob/machine-auth-e2e-express-hono

Conversation

@wobsoriano

@wobsorianowobsoriano commented Apr 1, 2026

Copy link
Copy Markdown
Member

Description

Adding complete machine auth (API keys, M2M, OAuth) integration tests to our SDKs:

  • Next.js (ref)
  • Astro (ref)
  • Nuxt (ref)
  • TanStack Start (ref)
  • React Router (ref)
  • Express (this PR)
  • Hono (this PR)
  • Fastify

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Added machine-to-machine (M2M) authentication support with automatic token scope verification via environment configuration.
    • Enhanced authentication middleware to accept configurable token types (API key, M2M, OAuth, session).
    • Exposed the client instance on the global window for external test utilities.
  • Tests

    • Added comprehensive integration tests for machine authentication on Express and Hono, covering API key, M2M, and OAuth scenarios.

@changeset-bot

changeset-botBot commented Apr 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fc1ebeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/honoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 1, 2026 6:49pm

Request Review

@pkg-pr-new

pkg-pr-newBot commented Apr 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/agent-toolkit

npm i https://pkg.pr.new/@clerk/agent-toolkit@8222

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8222

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8222

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8222

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8222

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8222

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8222

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8222

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8222

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8222

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8222

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8222

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8222

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8222

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8222

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8222

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8222

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8222

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8222

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8222

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8222

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8222

commit: fc1ebeb

@coderabbitai

coderabbitaiBot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 46b7a549-5766-4c60-bf92-39d26ff2d0c8

📥 Commits

Reviewing files that changed from the base of the PR and between 13eb3ab and fc1ebeb.

📒 Files selected for processing (2)
  • .changeset/fix-hono-getauth-accepts-token.md
  • packages/hono/src/clerkMiddleware.ts

📝 Walkthrough

Walkthrough

Added Playwright integration tests for Express and Hono that provision temporary servers with API key, M2M, and OAuth authenticated routes using Clerk middleware. Updated client entry points to assign the instantiated Clerk client to window.Clerk. Extended Hono clerkMiddleware to read CLERK_MACHINE_SECRET_KEY from the environment, forward machineSecretKey into client and authentication calls, and honor acceptsToken passed to getAuth. Added a changeset documenting the Hono patch.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title accurately describes the main change: adding machine authentication integration tests for Express and Hono frameworks, which comprise the majority of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

…_SECRET_KEY support
getAuth() was hardcoding acceptsToken to 'any' in the middleware closure,
causing it to accept any token type regardless of the route-level filter.
Move getAuthObjectForAcceptedToken to getAuth() to match the Express SDK
pattern.
Also read CLERK_MACHINE_SECRET_KEY from env vars and pass machineSecretKey
to createClerkClient and authenticateRequest, enabling M2M token scope
verification without explicit middleware configuration.
@wobsoriano
wobsoriano merged commit b80eafb into mainApr 2, 2026
46 checks passed
@wobsoriano
wobsoriano deleted the rob/machine-auth-e2e-express-hono branch April 2, 2026 15:15
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wobsoriano@tmilewski@dstaley