chore(repo): upgrade monorepo to Node.js 24 - #8351

Merged
jacekradko merged 23 commits into
mainfrom
jacek/upgrade-to-node-24
Apr 29, 2026
Merged

chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom
jacek/upgrade-to-node-24

Conversation

@jacekradko

@jacekradkojacekradko commented Apr 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20

Changes

  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24

Test plan

  • Build passes with Node 24
  • Tests pass with Node 24
  • Published packages still work with Node 20 (with expected engine warnings)
  • CI configuration updated to test both versions

@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot

changeset-botBot commented Apr 18, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f2d0a4f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 18, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm

Request Review

@coderabbitai

coderabbitaiBot commented Apr 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Apr 18, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f

@vercel

vercelBot commented Apr 20, 2026

Copy link
Copy Markdown

Deployment failed with the following error:

You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication

@jacekradkojacekradko changed the title chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot reviewed Apr 22, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc

📥 Commits

Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.

📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts

Comment thread.github/workflows/ci.yml Outdated
bratsos
bratsos reviewed Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock Outdated
bratsos
bratsos reviewed Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano requested changes Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
Comment on lines +29 to +47
// When cloning a Request by passing it as init, hide its `signal`. Undici's
// Request constructor in Node 24 performs a strict instanceof check on the
// signal and rejects ones from a different realm (e.g. NextRequest). Using a
// Proxy keeps property access lazy so environments that don't implement
// optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
let cloneInit: RequestInit | undefined;
if (init) {
cloneInit = init;
} else if (typeof input !== 'string') {
cloneInit = new Proxy(input as Request, {
get(target, prop) {
if (prop === 'signal') {
return undefined;
}
return Reflect.get(target, prop, target);
},
}) as unknown as RequestInit;
}
super(url, cloneInit);

@wobsorianowobsorianoApr 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects

https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085

Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos reviewed Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano approved these changes Apr 25, 2026
View reviewed changes

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko merged commit e0a63f9 into mainApr 29, 2026
73 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/upgrade-to-node-24 branch April 29, 2026 00:11
@clerk-cookieclerk-cookie mentioned this pull request Apr 28, 2026
Merged
@jacekradkojacekradko mentioned this pull request Apr 30, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes
+1 more reviewer
@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

actionsbackendreact-routertanstack

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
chore(repo): upgrade monorepo to Node.js 24 - #8351
Merged
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Apr 29, 2026
Merged
chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Conversation
@jacekradko
@jacekradkojacekradko
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20
Changes
  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24
Test plan
  •  Build passes with Node 24
  •  Tests pass with Node 24
  •  Published packages still work with Node 20 (with expected engine warnings)
  •  CI configuration updated to test both versions
@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot
changeset-botBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f2d0a4f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f
@vercel
vercelBot
commented
Apr 20, 2026

Copy link


Copy Markdown

Deployment failed with the following error:
You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication
@jacekradkojacekradko
changed the title
chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc
📥 Commits
Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.
📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts
Comment thread.github/workflows/ci.yml
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano
requested changes
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts

Comment on lines

+29
 to 
+47

 // When cloning a Request by passing it as init, hide its `signal`. Undici's
 // Request constructor in Node 24 performs a strict instanceof check on the
 // signal and rejects ones from a different realm (e.g. NextRequest). Using a
 // Proxy keeps property access lazy so environments that don't implement
 // optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
 let cloneInit: RequestInit | undefined;
 if (init) {
 cloneInit = init;
 } else if (typeof input !== 'string') {
 cloneInit = new Proxy(input as Request, {
 get(target, prop) {
 if (prop === 'signal') {
 return undefined;
 }
 return Reflect.get(target, prop, target);
 },
 }) as unknown as RequestInit;
 }
 super(url, cloneInit);
@wobsorianowobsorianoApr 24, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects
https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085
Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano
approved these changes
Apr 25, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko
merged commit e0a63f9
into
mainApr 29, 2026

73 of 74 checks passed

@jacekradko
jacekradko
deleted the

jacek/upgrade-to-node-24

branch
April 29, 2026 00:11
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 28, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes

+1 more reviewer

@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

actionsbackendreact-routertanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(repo): upgrade monorepo to Node.js 24 - #8351
Merged
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Apr 29, 2026
Merged
chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Conversation
@jacekradko
@jacekradkojacekradko
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20
Changes
  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24
Test plan
  •  Build passes with Node 24
  •  Tests pass with Node 24
  •  Published packages still work with Node 20 (with expected engine warnings)
  •  CI configuration updated to test both versions
@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot
changeset-botBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f2d0a4f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f
@vercel
vercelBot
commented
Apr 20, 2026

Copy link


Copy Markdown

Deployment failed with the following error:
You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication
@jacekradkojacekradko
changed the title
chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc
📥 Commits
Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.
📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts
Comment thread.github/workflows/ci.yml
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano
requested changes
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts

Comment on lines

+29
 to 
+47

 // When cloning a Request by passing it as init, hide its `signal`. Undici's
 // Request constructor in Node 24 performs a strict instanceof check on the
 // signal and rejects ones from a different realm (e.g. NextRequest). Using a
 // Proxy keeps property access lazy so environments that don't implement
 // optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
 let cloneInit: RequestInit | undefined;
 if (init) {
 cloneInit = init;
 } else if (typeof input !== 'string') {
 cloneInit = new Proxy(input as Request, {
 get(target, prop) {
 if (prop === 'signal') {
 return undefined;
 }
 return Reflect.get(target, prop, target);
 },
 }) as unknown as RequestInit;
 }
 super(url, cloneInit);
@wobsorianowobsorianoApr 24, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects
https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085
Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano
approved these changes
Apr 25, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko
merged commit e0a63f9
into
mainApr 29, 2026

73 of 74 checks passed

@jacekradko
jacekradko
deleted the

jacek/upgrade-to-node-24

branch
April 29, 2026 00:11
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 28, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes

+1 more reviewer

@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

actionsbackendreact-routertanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(repo): upgrade monorepo to Node.js 24 - #8351
Merged
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Apr 29, 2026
Merged
chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Conversation
@jacekradko
@jacekradkojacekradko
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20
Changes
  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24
Test plan
  •  Build passes with Node 24
  •  Tests pass with Node 24
  •  Published packages still work with Node 20 (with expected engine warnings)
  •  CI configuration updated to test both versions
@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot
changeset-botBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f2d0a4f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f
@vercel
vercelBot
commented
Apr 20, 2026

Copy link


Copy Markdown

Deployment failed with the following error:
You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication
@jacekradkojacekradko
changed the title
chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc
📥 Commits
Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.
📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts
Comment thread.github/workflows/ci.yml
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano
requested changes
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts

Comment on lines

+29
 to 
+47

 // When cloning a Request by passing it as init, hide its `signal`. Undici's
 // Request constructor in Node 24 performs a strict instanceof check on the
 // signal and rejects ones from a different realm (e.g. NextRequest). Using a
 // Proxy keeps property access lazy so environments that don't implement
 // optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
 let cloneInit: RequestInit | undefined;
 if (init) {
 cloneInit = init;
 } else if (typeof input !== 'string') {
 cloneInit = new Proxy(input as Request, {
 get(target, prop) {
 if (prop === 'signal') {
 return undefined;
 }
 return Reflect.get(target, prop, target);
 },
 }) as unknown as RequestInit;
 }
 super(url, cloneInit);
@wobsorianowobsorianoApr 24, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects
https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085
Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano
approved these changes
Apr 25, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko
merged commit e0a63f9
into
mainApr 29, 2026

73 of 74 checks passed

@jacekradko
jacekradko
deleted the

jacek/upgrade-to-node-24

branch
April 29, 2026 00:11
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 28, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes

+1 more reviewer

@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

actionsbackendreact-routertanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
chore(repo): upgrade monorepo to Node.js 24 - #8351
Merged
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Apr 29, 2026
Merged
chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Conversation
@jacekradko
@jacekradkojacekradko
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20
Changes
  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24
Test plan
  •  Build passes with Node 24
  •  Tests pass with Node 24
  •  Published packages still work with Node 20 (with expected engine warnings)
  •  CI configuration updated to test both versions
@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot
changeset-botBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f2d0a4f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f
@vercel
vercelBot
commented
Apr 20, 2026

Copy link


Copy Markdown

Deployment failed with the following error:
You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication
@jacekradkojacekradko
changed the title
chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc
📥 Commits
Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.
📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts
Comment thread.github/workflows/ci.yml
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano
requested changes
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts

Comment on lines

+29
 to 
+47

 // When cloning a Request by passing it as init, hide its `signal`. Undici's
 // Request constructor in Node 24 performs a strict instanceof check on the
 // signal and rejects ones from a different realm (e.g. NextRequest). Using a
 // Proxy keeps property access lazy so environments that don't implement
 // optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
 let cloneInit: RequestInit | undefined;
 if (init) {
 cloneInit = init;
 } else if (typeof input !== 'string') {
 cloneInit = new Proxy(input as Request, {
 get(target, prop) {
 if (prop === 'signal') {
 return undefined;
 }
 return Reflect.get(target, prop, target);
 },
 }) as unknown as RequestInit;
 }
 super(url, cloneInit);
@wobsorianowobsorianoApr 24, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects
https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085
Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano
approved these changes
Apr 25, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko
merged commit e0a63f9
into
mainApr 29, 2026

73 of 74 checks passed

@jacekradko
jacekradko
deleted the

jacek/upgrade-to-node-24

branch
April 29, 2026 00:11
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 28, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes

+1 more reviewer

@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

actionsbackendreact-routertanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(repo): upgrade monorepo to Node.js 24 - #8351
Merged
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Apr 29, 2026
Merged
chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Conversation
@jacekradko
@jacekradkojacekradko
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20
Changes
  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24
Test plan
  •  Build passes with Node 24
  •  Tests pass with Node 24
  •  Published packages still work with Node 20 (with expected engine warnings)
  •  CI configuration updated to test both versions
@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot
changeset-botBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f2d0a4f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f
@vercel
vercelBot
commented
Apr 20, 2026

Copy link


Copy Markdown

Deployment failed with the following error:
You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication
@jacekradkojacekradko
changed the title
chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc
📥 Commits
Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.
📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts
Comment thread.github/workflows/ci.yml
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano
requested changes
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts

Comment on lines

+29
 to 
+47

 // When cloning a Request by passing it as init, hide its `signal`. Undici's
 // Request constructor in Node 24 performs a strict instanceof check on the
 // signal and rejects ones from a different realm (e.g. NextRequest). Using a
 // Proxy keeps property access lazy so environments that don't implement
 // optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
 let cloneInit: RequestInit | undefined;
 if (init) {
 cloneInit = init;
 } else if (typeof input !== 'string') {
 cloneInit = new Proxy(input as Request, {
 get(target, prop) {
 if (prop === 'signal') {
 return undefined;
 }
 return Reflect.get(target, prop, target);
 },
 }) as unknown as RequestInit;
 }
 super(url, cloneInit);
@wobsorianowobsorianoApr 24, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects
https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085
Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano
approved these changes
Apr 25, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko
merged commit e0a63f9
into
mainApr 29, 2026

73 of 74 checks passed

@jacekradko
jacekradko
deleted the

jacek/upgrade-to-node-24

branch
April 29, 2026 00:11
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 28, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes

+1 more reviewer

@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

actionsbackendreact-routertanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
chore(repo): upgrade monorepo to Node.js 24 - #8351
Merged
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Apr 29, 2026
Merged
chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Conversation
@jacekradko
@jacekradkojacekradko
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20
Changes
  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24
Test plan
  •  Build passes with Node 24
  •  Tests pass with Node 24
  •  Published packages still work with Node 20 (with expected engine warnings)
  •  CI configuration updated to test both versions
@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot
changeset-botBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f2d0a4f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f
@vercel
vercelBot
commented
Apr 20, 2026

Copy link


Copy Markdown

Deployment failed with the following error:
You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication
@jacekradkojacekradko
changed the title
chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc
📥 Commits
Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.
📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts
Comment thread.github/workflows/ci.yml
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano
requested changes
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts

Comment on lines

+29
 to 
+47

 // When cloning a Request by passing it as init, hide its `signal`. Undici's
 // Request constructor in Node 24 performs a strict instanceof check on the
 // signal and rejects ones from a different realm (e.g. NextRequest). Using a
 // Proxy keeps property access lazy so environments that don't implement
 // optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
 let cloneInit: RequestInit | undefined;
 if (init) {
 cloneInit = init;
 } else if (typeof input !== 'string') {
 cloneInit = new Proxy(input as Request, {
 get(target, prop) {
 if (prop === 'signal') {
 return undefined;
 }
 return Reflect.get(target, prop, target);
 },
 }) as unknown as RequestInit;
 }
 super(url, cloneInit);
@wobsorianowobsorianoApr 24, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects
https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085
Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano
approved these changes
Apr 25, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko
merged commit e0a63f9
into
mainApr 29, 2026

73 of 74 checks passed

@jacekradko
jacekradko
deleted the

jacek/upgrade-to-node-24

branch
April 29, 2026 00:11
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 28, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes

+1 more reviewer

@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

actionsbackendreact-routertanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
chore(repo): upgrade monorepo to Node.js 24 - #8351
Merged
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Apr 29, 2026
Merged
chore(repo): upgrade monorepo to Node.js 24#8351
jacekradko merged 23 commits into
mainfrom 
jacek/upgrade-to-node-24
Conversation
@jacekradko
@jacekradkojacekradko
commented
Apr 18, 2026

Copy link


Copy Markdown

Contributor
Summary
  • Upgrades the monorepo development environment to Node.js 24
  • Maintains Node ≥20.9.0 compatibility for published packages
  • Updates CI workflows to test both Node 24 and Node 20
Changes
  • Updated root package.json engines to require Node ≥24.15.0
  • Updated .nvmrc to Node 24.15.0
  • Updated CI workflows to use Node 24 as primary version
  • Added Node 20 to CI test matrix for published package compatibility
  • Updated release workflow caching to Node 24
Test plan
  •  Build passes with Node 24
  •  Tests pass with Node 24
  •  Published packages still work with Node 20 (with expected engine warnings)
  •  CI configuration updated to test both versions
@jacekradko
chore: upgrade monorepo to Node.js 24
9fcc619
- Update root package.json engines to require Node >=24.15.0
- Update .nvmrc to Node 24.15.0
- Update CI workflows to use Node 24 as primary version
- Add Node 20 to CI test matrix for published package compatibility
- Update release workflow caching to Node 24
Published packages maintain Node >=20.9.0 compatibility as specified
in their individual engines fields. This change only affects the
monorepo development environment and CI/CD pipelines.
@jacekradko
chore: add changeset for Node 24 upgrade
d50f674
@changeset-bot
changeset-botBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: f2d0a4f
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 10 packages
NameType
@clerk/backendPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/testingPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 28, 2026 11:43pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Note
Reviews paused
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
  • ▶️ Resume reviews
  •  🔍 Trigger review
📝 Walkthrough
Walkthrough
Updated Node.js target from 22.x to 24.15.0 across project configs and CI: .nvmrc, package.jsonengines.node, GitHub Actions composite defaults (.github/actions/init*.yml), CI matrix and gating (.github/workflows/ci.yml), and release cache matrix (.github/workflows/release.yml). Added two changeset files (.changeset/giant-mirrors-find.md, .changeset/node24-clerk-request-signal.md). Modified request-cloning behavior: packages/backend/src/tokens/clerkRequest.ts now constructs a RequestInit (using a Proxy for non-string input) that omits the original request’s signal, and packages/react-router/src/server/utils.ts no longer copies request.signal when patching requests. No public exported signatures changed.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main objective of the pull request: upgrading the monorepo to Node.js 24.
Description check✅ PassedThe description is directly related to the changeset, providing a clear summary of changes, test plan results, and alignment with the PR objectives.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
@pkg-pr-new
pkg-pr-newBot
commented
Apr 18, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8351

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8351

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8351

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8351

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8351

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8351

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8351

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8351

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8351

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8351

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8351

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8351

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8351

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8351

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8351

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8351

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8351

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8351

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8351

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8351

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8351

commit: f2d0a4f
@vercel
vercelBot
commented
Apr 20, 2026

Copy link


Copy Markdown

Deployment failed with the following error:
You must set up Two-Factor Authentication before accessing this team.

View Documentation: https://vercel.com/docs/two-factor-authentication
@jacekradkojacekradko
changed the title
chore: upgrade monorepo to Node.js 24chore(repo): upgrade monorepo to Node.js 24Apr 22, 2026
@jacekradko
fix(backend): clone Request without cross-realm AbortSignal on Node 24
d70ee79
- Bump default node-version in init actions from 22 to 24 so integration-tests run on the version required by engines.node
- In ClerkRequest, build init explicitly when cloning a Request to avoid undici extracting a cross-realm signal (e.g. from NextRequest), which Node 24's stricter instanceof check rejects
- Also fixes a latent precedence bug where a provided init was silently dropped
@jacekradko
fix: pin Node to 24.15.0 and use Proxy to hide signal in clone
e9f8d1a
- Pin node-version to 24.15.0 in init actions, matrix, and pkg-pr-new step so the engines.node check (>=24.15.0) is satisfied
- Use a Proxy to intercept the 'signal' read when cloning a Request, instead of eagerly reading individual properties (which broke in environments like Cloudflare Workers where Request.cache is not implemented)
coderabbitai[bot]
coderabbitaiBot
reviewed
Apr 22, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 221-224: CI matrix includes an unsupported "node-version: 20"
entry; remove that entry so the matrix only contains the supported
"node-version: 24.15.0". Edit the matrix block that lists the node-version
values (the YAML key "node-version" in the job matrix) and delete the line with
"20", leaving the existing "24.15.0" (and keep "test-filter" and "filter-label"
entries unchanged); verify no other job or matrix elsewhere still references
node 20.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 4d516f8e-f4a5-4b0a-a1fa-a36126cee8dc
📥 Commits
Reviewing files that changed from the base of the PR and between d70ee79 and e9f8d1a.
📒 Files selected for processing (4)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • .github/workflows/ci.yml
  • packages/backend/src/tokens/clerkRequest.ts
🚧 Files skipped from review as they are similar to previous changes (3)
  • .github/actions/init-blacksmith/action.yml
  • .github/actions/init/action.yml
  • packages/backend/src/tokens/clerkRequest.ts
Comment thread.github/workflows/ci.yml
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.claude/scheduled_tasks.lock
Outdated

bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment thread.changeset/giant-mirrors-find.md
wobsoriano
wobsoriano
requested changes
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts

Comment on lines

+29
 to 
+47

 // When cloning a Request by passing it as init, hide its `signal`. Undici's
 // Request constructor in Node 24 performs a strict instanceof check on the
 // signal and rejects ones from a different realm (e.g. NextRequest). Using a
 // Proxy keeps property access lazy so environments that don't implement
 // optional getters (e.g. Cloudflare Workers' Request lacks `cache`) still work.
 let cloneInit: RequestInit | undefined;
 if (init) {
 cloneInit = init;
 } else if (typeof input !== 'string') {
 cloneInit = new Proxy(input as Request, {
 get(target, prop) {
 if (prop === 'signal') {
 return undefined;
 }
 return Reflect.get(target, prop, target);
 },
 }) as unknown as RequestInit;
 }
 super(url, cloneInit);
@wobsorianowobsorianoApr 24, 2026

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this makes sense. Undici validates init.signal when constructing a Request, and that can reject signals coming from framework-specific request objects
https://github.com/nodejs/undici/blob/main/lib/web/fetch/request.js#L1077-L1085
Comment threadpackages/react-router/src/server/utils.ts
bratsos
bratsos
reviewed
Apr 24, 2026
View reviewed changes
Comment threadpackages/backend/src/tokens/clerkRequest.ts
wobsoriano
wobsoriano
approved these changes
Apr 25, 2026
View reviewed changes
@wobsorianowobsoriano
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀
@jacekradko
fix(tanstack-react-start): bridge AbortSignal in patchRequest via loc…
02b5a08
…al controller
Node 24's bundled undici rejects cross-realm AbortSignal on RequestInit.signal.
Use an in-realm AbortController and forward aborts from the original signal.
@jacekradko
fix(tanstack-react-start): keep signal omitted in patchRequest under …
b24182f
…Node 24
Reverts the AbortController bridge attempt: undici's instanceof AbortSignal
check rejects in-realm AbortSignals as well in this environment, so any
RequestInit.signal triggers a TypeError. Restore the signal-less clone and
update the regression test to assert the intentional non-forwarding behavior.
@jacekradko
test(tanstack-react-start): drop unworkable signal-forward regression…
302a2ae
… test
Constructing new Request(url, { signal }) with any AbortSignal throws under
Node 24 + jsdom + undici due to the tightened cross-realm instanceof check.
patchRequest already omits the signal to dodge this; the regression test
cannot exercise the path in this environment.
@jacekradko
jacekradko
merged commit e0a63f9
into
mainApr 29, 2026

73 of 74 checks passed

@jacekradko
jacekradko
deleted the

jacek/upgrade-to-node-24

branch
April 29, 2026 00:11
@clerk-cookieclerk-cookie
mentioned this pull request
Apr 28, 2026
 Merged

@jacekradkojacekradko
mentioned this pull request
Apr 30, 2026
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@wobsorianowobsorianowobsoriano approved these changes

+1 more reviewer

@bratsosbratsosbratsos left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

actionsbackendreact-routertanstack

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@bratsos@wobsoriano