Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tests for the new endpoint wrapper before merge.
Line 94 adds a new backend call path, but this PR has no test changes. Please add at least one test asserting method/path wiring for
getOrganizationSettings().As per coding guidelines: "
**/*: If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."🤖 Prompt for AI Agents
🧩 Analysis chain
🏁 Script executed:
Repository: clerk/javascript
Length of output: 343
🏁 Script executed:
Repository: clerk/javascript
Length of output: 895
🏁 Script executed:
Repository: clerk/javascript
Length of output: 1421
🏁 Script executed:
Repository: clerk/javascript
Length of output: 176
🏁 Script executed:
rg -t ts 'class AbstractAPI' -lRepository: clerk/javascript
Length of output: 109
🏁 Script executed:
Repository: clerk/javascript
Length of output: 323
🏁 Script executed:
Repository: clerk/javascript
Length of output: 8919
Add explicit return type to this public API method.
The
getOrganizationSettings()method at line 94 is missing an explicit return type annotation. Per the coding guidelines, all public APIs must have explicit return types.Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents