Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range by jacekradko · Pull Request #8417 · clerk/javascript · GitHub
Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range by jacekradko · Pull Request #8417 · clerk/javascript · GitHub
Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range by jacekradko · Pull Request #8417 · clerk/javascript · GitHub
Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range by jacekradko · Pull Request #8417 · clerk/javascript · GitHub
Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range by jacekradko · Pull Request #8417 · clerk/javascript · GitHub
Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range by jacekradko · Pull Request #8417 · clerk/javascript · GitHub
Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range by jacekradko · Pull Request #8417 · clerk/javascript · GitHub
Skip to content

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range - #8417

Merged
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin
Apr 29, 2026
Merged

fix(shared,clerk-js): loosen @tanstack/query-core pin to caret range#8417
jacekradko merged 2 commits into
mainfrom
jacek/loosen-query-core-pin

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

  • Bumps @tanstack/query-core from an exact pin (5.90.16) to ^5.90.16 in @clerk/shared and @clerk/clerk-js
  • Lets the dependency dedupe with consumer-installed @tanstack/react-query versions, which pin query-core to their exact same patch version

Motivation

Vite's resolve.dedupe resolves modules from the project root's node_modules/ only. Under Bun's content-addressable layout, transitive deps are hoisted to root only when they can be deduped to a single version across the dep graph. With our exact pin, any consumer whose react-query resolved to a different query-core patch (e.g. 5.100.x) ended up with two nested copies, neither hoisted to root, so Vite's dedupe failed to resolve @tanstack/query-core and the app crashed.

This was reproducing intermittently in Lovable apps (TanStack Start + Bun, no lockfile). Each fresh install pulled the latest react-query@5.x, which pulled a query-core that didn't satisfy our exact 5.90.16. The caret allows dedupe to land on whichever 5.x the consumer's react-query brings.

Test plan

  • CI green
  • Reproduction in a Lovable-style app (TanStack Start + Bun, saveTextLockfile = false) resolves @tanstack/query-core cleanly under Vite resolve.dedupe

@vercel

vercelBot commented Apr 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentApr 29, 2026 6:40am

Request Review

@changeset-bot

changeset-botBot commented Apr 29, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9a09c53

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/clerk-jsPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 50248a5b-0ccb-449a-87f1-44003b6a3f55

📥 Commits

Reviewing files that changed from the base of the PR and between e0a63f9 and a2fe92a.

📒 Files selected for processing (3)
  • .changeset/loosen-query-core-pin.md
  • packages/clerk-js/package.json
  • packages/shared/package.json

📝 Walkthrough

Walkthrough

This pull request updates the dependency constraint for @tanstack/query-core from exact pinned versions to caret ranges across two packages. Changes include modifying packages/clerk-js/package.json and packages/shared/package.json to use ^5.90.16 instead of 5.90.16, and adding a corresponding Changesets metadata entry documenting the patch-level release for both packages.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: loosening the @tanstack/query-core dependency from an exact pin to a caret range in shared and clerk-js packages.
Description check✅ PassedThe description is directly related to the changeset, clearly explaining the motivation behind loosening the dependency pin and how it resolves Bun/Vite deduplication issues.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@pkg-pr-new

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8417

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8417

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8417

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8417

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8417

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8417

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8417

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8417

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8417

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8417

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8417

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8417

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8417

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8417

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8417

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8417

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8417

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8417

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8417

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8417

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8417

commit: 9a09c53

@jacekradko
jacekradko merged commit a9f9b29 into mainApr 29, 2026
62 of 74 checks passed
@jacekradko
jacekradko deleted the jacek/loosen-query-core-pin branch April 29, 2026 07:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jacekradko@wobsoriano