Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(shared): guard auto-proxy env lookup by jacekradko · Pull Request #8466 · clerk/javascript · GitHub
Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared): guard auto-proxy env lookup by jacekradko · Pull Request #8466 · clerk/javascript · GitHub
Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared): guard auto-proxy env lookup by jacekradko · Pull Request #8466 · clerk/javascript · GitHub
Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(shared): guard auto-proxy env lookup by jacekradko · Pull Request #8466 · clerk/javascript · GitHub
Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared): guard auto-proxy env lookup by jacekradko · Pull Request #8466 · clerk/javascript · GitHub
Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(shared): guard auto-proxy env lookup by jacekradko · Pull Request #8466 · clerk/javascript · GitHub
Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(shared): guard auto-proxy env lookup by jacekradko · Pull Request #8466 · clerk/javascript · GitHub
Skip to content

fix(shared): guard auto-proxy env lookup - #8466

Merged
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy
May 5, 2026
Merged

fix(shared): guard auto-proxy env lookup#8466
jacekradko merged 4 commits into
mainfrom
jacek/fix-cloudflare-process-proxy

Conversation

@jacekradko

Copy link
Copy Markdown
Contributor

Summary

Fixes#8459 by avoiding an unconditional process.env default parameter in shared auto-proxy detection. Worker-style runtimes without process now fall back to an empty environment instead of throwing before the function body runs.

Changes

  • Add a guarded default environment helper for getAutoProxyUrlFromEnvironment.
  • Add a regression test that deletes globalThis.process while calling auto-proxy detection.
  • Add a patch changeset for @clerk/shared.

Testing

  • pnpm --filter @clerk/shared exec vitest run src/__tests__/proxy.spec.ts

@changeset-bot

changeset-botBot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d6456fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedPatch
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 5, 2026 0:53am

Request Review

@jacekradkojacekradko changed the title fix: guard auto-proxy env lookupfix(shared): guard auto-proxy env lookupMay 4, 2026
@jacekradko
jacekradko marked this pull request as ready for review May 4, 2026 17:41
@coderabbitai

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7ad48c33-09c1-4b93-8424-3b185df76985

📥 Commits

Reviewing files that changed from the base of the PR and between 7ea8a0b and 53b7ee1.

📒 Files selected for processing (3)
  • .changeset/fix-cloudflare-process-proxy.md
  • packages/shared/src/__tests__/proxy.spec.ts
  • packages/shared/src/proxy.ts

📝 Walkthrough

Walkthrough

The pull request adds a getDefaultEnvironment() helper function that safely accesses process.env when available, returning an empty object otherwise. The getAutoProxyUrlFromEnvironment function's environment parameter default is updated to use this helper instead of directly referencing process.env. A test case was added to verify the function handles environments where process is unavailable. These changes are documented in a changeset entry for a patch version bump to @clerk/shared.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: guarding auto-proxy environment lookup to prevent errors in environments without process.
Description check✅ PassedThe description is well-related to the changeset, explaining the fix for issue #8459 with detailed changes and testing instructions.
Linked Issues check✅ PassedThe PR directly addresses issue #8459 by implementing guarded access to process.env through a helper function and adding regression tests.
Out of Scope Changes check✅ PassedAll changes are directly related to fixing the process.env guard issue: the helper function, test coverage, and changeset entry are all in-scope.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Review rate limit: 4/5 reviews remaining, refill in 12 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 4, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8466

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8466

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8466

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8466

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8466

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8466

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8466

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8466

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8466

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8466

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8466

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8466

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8466

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8466

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8466

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8466

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8466

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8466

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8466

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8466

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8466

commit: d6456fa

@jacekradko
jacekradko merged commit 68d32df into mainMay 5, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-cloudflare-process-proxy branch May 5, 2026 15:33
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

process is undefined in @clerk/shared in cloudflare workers

2 participants

@jacekradko@wobsoriano