Uh oh!
There was an error while loading. Please reload this page.
chore(ui): Add wizard steps to <ConfigureSSO /> - #8468
Conversation
🦋 Changeset detectedLatest commit: a7f1340 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
67fbe0d to
bcc4254Compareff61174 to
e8b8f9aComparee8b8f9a to
18f5bfdCompare7d5575c to
24fadadCompare24fadad to
e4b796eComparee4b796e to
541f9aaCompare541f9aa to
b5e2c1aCompareb5e2c1a to
0caf48eCompare0caf48e to
1db042bCompare1db042b to
265c4b1Compareaa04cf0 to
8c7e926Compare8c7e926 to
551b23aCompare| return; | ||
| } | ||
| if (noUserExists(this)) { |
There was a problem hiding this comment.
Added this one that got missed on the first PR
8ff7711 to
17a34d2Compare17a34d2 to
a52fec0Comparea52fec0 to
bb1e4e2Comparebb1e4e2 to
a7f1340Compare
iagodahlem
left a comment
There was a problem hiding this comment.
The declarative shape is great 👏 — I think we still need some improvements to better structure it and separate the wizard responsibilities into more layers, so we can easily extract those components for reuse later, but I think it's good enough as it is for now and we can follow up. Just two small alignment items I'd flag for this PR before the bigger refactor lands as a follow-up:
Flow.Part part=naming convention.isLoadingflowing throughConfigureSSOFlowContext.
| label='Configure' | ||
| > | ||
| <ConfigureSSOWizard> | ||
| {/* TODO: Implement configure steps */} |
There was a problem hiding this comment.
| {/* TODO: Implement configure steps */} |
| > | ||
| <ConfigureSSOFlowProvider | ||
| enterpriseConnection={enterpriseConnection} | ||
| isLoading={isLoadingEnterpriseConnections} |
There was a problem hiding this comment.
I think passing the initial isLoading down to the context and rendering it on the wizard might lead us to issues when invalidating the query, and also for instance, when we start determining the current step after a refresh I think it would be good to have the loading before the wizard even renders, so what do you think of lifting the initial loading state here to ConfigureSSO root? Something like:
constAuthenticatedContent=withCoreUserGuard(()=>{const{ data, isLoading }=__internal_useUserEnterpriseConnections({enabled: true});if(isLoading&&!data){return<FullSpinner/>;}return(// …existing layout…<ConfigureSSOFlowProviderenterpriseConnection={data?.[0]}><ConfigureSSOSteps/></ConfigureSSOFlowProvider>);});Happy to take this as a separate PR if you'd rather keep this one tight.
| export const TestConfigurationStep = (): JSX.Element => { | ||
| return ( | ||
| <Flow.Part part='test-sso'> |
There was a problem hiding this comment.
I think the convention for Flow.Part part= is camelCase across Sign-In / Sign-Up / SessionTasks / UserVerification (phoneCode2Fa, alternativeMethods, enterpriseConnections, chooseOrganization, etc.). The four other ConfigureSSO steps already follow that — only test-sso here and sso-confirmation in ConfirmationStep are kebab-case.
Description
Flow.Partper step typeTo be handled in next PRs:
CleanShot.2026-05-05.at.00.18.48.mp4
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change