Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(headless): add Popover primitive by alexcarpenter · Pull Request #8478 · clerk/javascript · GitHub
Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(headless): add Popover primitive by alexcarpenter · Pull Request #8478 · clerk/javascript · GitHub
Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(headless): add Popover primitive by alexcarpenter · Pull Request #8478 · clerk/javascript · GitHub
Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(headless): add Popover primitive by alexcarpenter · Pull Request #8478 · clerk/javascript · GitHub
Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(headless): add Popover primitive by alexcarpenter · Pull Request #8478 · clerk/javascript · GitHub
Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(headless): add Popover primitive by alexcarpenter · Pull Request #8478 · clerk/javascript · GitHub
Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(headless): add Popover primitive by alexcarpenter · Pull Request #8478 · clerk/javascript · GitHub
Skip to content

feat(headless): add Popover primitive - #8478

Closed
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover
Closed

feat(headless): add Popover primitive#8478
alexcarpenter wants to merge 8 commits into
carp/headless-tooltipfrom
carp/headless-popover

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented May 5, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds Popover primitive: click-triggered positioned floating content
  • Optional modal mode with focus trapping
  • FloatingArrow support, cssVars middleware for layout measurements

Review Stack

Review order — start at #8474 (foundation) and work up. Each PR adds one primitive on top of the previous.

#PRWhat it addsBase
1#8474Foundation (infra + hooks + utils + Dialog)main
2#8475Accordion#8474
3#8476Tabs#8475
4#8477cssVars + Tooltip#8476
5#8478Popover#8477
6#8479Select#8478
7#8480Menu#8479
8#8481Autocomplete + integration tests#8480
9#8764Collapsible#8481

Test plan

  • pnpm build succeeds
  • pnpm test passes (+24 popover tests)
  • CI passes

🤖 Generated with Claude Code

@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxErrorErrorJun 3, 2026 5:33pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9cc0903

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 032b0f0 to 24adffaCompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 2316ca7 to 144f752CompareMay 5, 2026 15:26
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 144f752 to 8c0b810CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 24adffa to 38c58e6CompareMay 5, 2026 15:39
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 38c58e6 to 8136289CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 8c0b810 to 6a80c95CompareMay 5, 2026 15:49
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from 6a80c95 to c190d6fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 8136289 to 3b5f83fCompareMay 5, 2026 18:38
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 3b5f83f to e6b05b8CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from c190d6f to db49302CompareJune 3, 2026 17:09
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from e6b05b8 to 97e0dbdCompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from db49302 to a01dab9CompareJune 3, 2026 17:19
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-popover branch from 97e0dbd to 7bc3787CompareJune 3, 2026 17:23
@alexcarpenter
alexcarpenterforce-pushed the carp/headless-tooltip branch from a01dab9 to 64c21e3CompareJune 3, 2026 17:23
alexcarpenterand others added 8 commits June 3, 2026 13:32
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Introduces the @clerk/headless package — a zero-style React component
library providing accessible headless UI primitives. This first PR
establishes the core infrastructure and patterns:
- Package scaffold: Vite build, Vitest browser tests (Chromium), TypeScript config
- Core utils: renderElement (polymorphic rendering with render prop support),
mergeProps (event handler chaining, style/className merging)
- Hooks: useControllableState, useTransitionStatus, useAnimationsFinished, useTransition
- First primitive: Dialog (modal with focus trapping, scroll lock, portal support)
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@alexcarpenter

Copy link
Copy Markdown
MemberAuthor

Superseded by #8790, which consolidates the remaining headless primitive stack (Tabs → Collapsible) into a single PR for one review pass. Closing in favor of that.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@alexcarpenter