docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

docs(repo): Add additional typedoc outputs - #8483

Merged
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs
May 6, 2026
Merged

docs(repo): Add additional typedoc outputs#8483
jacekradko merged 16 commits into
mainfrom
ss/more-typedoc-outputs

Conversation

@SarahSoutoul

@SarahSoutoulSarahSoutoul commented May 5, 2026

Copy link
Copy Markdown
Contributor

Description

This PR is two fold:

  1. It adds changes to bring in Typedoc outputs to help with this PR. The changes are the following:

    • Removed @internal from useOAuthConsent() and its params/return types so Typedoc generates outputs for them that can be used in the docs.
    • Tightened the hook typing so oauthClientId is explicitly required.
    • Added JSDoc comments for OAuthConsentInfo, OAuthConsentScope, and related OAuth consent fields that can be used as types in the docs.
    • Updated .typedoc/custom-plugin.mjs so new generated params/returns/types link correctly in docs.
  2. It adds changes to resolve the issue raised here related to creating a page for enterprise-connection-oauth-config.

    • Updated .typedoc/custom-plugin.mjs so new generated enterprise types link correctly in docs.
    • Improved JSDoc comment for EnterpriseAccountConnection and EnterpriseConnectionSamlConnection backend resource types used in the generated output.

Apart from these two objectives, I also made sure that ClerkAPIResponseError and ClerkAPIError were correctly linked through updates in the .typedoc/custom-plugin.mjs file.

When this is released, I will generate a Typedoc PR in clerk-docs and will add the docs specific changes that are needed to bring all of this together. Once that Typedoc PR is released, we will then be able to modify this PR from @wobsoriano to be using typedoc rather than manual input.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@SarahSoutoulSarahSoutoul self-assigned this May 5, 2026
@vercel

vercelBot commented May 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 6, 2026 9:44pm

Request Review

@changeset-bot

changeset-botBot commented May 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0b998a6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/backendPatch
@clerk/sharedPatch
@clerk/astroPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/chrome-extensionPatch
@clerk/clerk-jsPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/reactPatch
@clerk/uiPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SarahSoutoulSarahSoutoul changed the title Add additional typedoc outputs docs(repo): Add additional typedoc outputs May 5, 2026
@SarahSoutoulSarahSoutoul changed the title docs(repo): Add additional typedoc outputs docs(repo): Add additional typedoc outputsMay 5, 2026
@coderabbitai

coderabbitaiBot commented May 5, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: a2f207c6-b093-4627-b179-e17fb8a7e161

📥 Commits

Reviewing files that changed from the base of the PR and between 1e27689 and 6671fb1.

📒 Files selected for processing (1)
  • packages/shared/src/types/oauthApplication.ts

📝 Walkthrough

Walkthrough

Adds SAML and OAuth nested types and JSON mapping to Backend EnterpriseConnection; tightens the shared React hook useOAuthConsent by requiring its params type and making oauthClientId/scope required in its params type; introduces camelCase public OAuth consent types and removes the optional scope from GetOAuthConsentInfoParams (now only oauthClientId); updates a JSDoc line for EnterpriseAccountConnection; and extends the TypeDoc custom plugin with additional files-to-strip and link-replacement rules (o-auth-consent entries, enterprise-connection variants, clerk-api-error, and a catch-all for ClerkAPIResponseError).

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check nameStatusExplanationResolution
Title check⚠️ WarningThe title 'docs(repo): Add additional typedoc outputs' is misleading. The PR actually adds functional type changes and JSDoc updates, not just documentation.Revise title to reflect the main changes: e.g., 'fix: Tighten OAuth consent hook typing and add JSDoc for Typedoc generation'.
Docstring Coverage⚠️ WarningDocstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check nameStatusExplanation
Description check✅ PassedThe description comprehensively explains the PR's two-fold objectives, changes made, and future workflow plans, clearly relating to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8483

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8483

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8483

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8483

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8483

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8483

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8483

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8483

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8483

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8483

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8483

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8483

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8483

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8483

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8483

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8483

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8483

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8483

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8483

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8483

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8483

commit: 0b998a6

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/shared/src/react/hooks/useOAuthConsent.tsx`:
- Around line 27-30: The hook useOAuthConsent currently destructures params
immediately which crashes when callers omit params; make it runtime-safe by
defaulting params to an empty object (or provide a default in the destructuring)
so the destructuring of oauthClientIdParam, scope, keepPreviousData, and enabled
succeeds even when params is undefined; update the function signature or the
const line that extracts oauthClientId: oauthClientIdParam, scope,
keepPreviousData = true, enabled = true to use a safe default (e.g., params = {}
or ({ ... } = params || {})) and keep the existing empty-client-id fallback
logic intact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 0e5af9cc-d8af-4adf-892a-9cfd9f16aea4

📥 Commits

Reviewing files that changed from the base of the PR and between cd6c4b7 and 86427f3.

📒 Files selected for processing (6)
  • .typedoc/custom-plugin.mjs
  • packages/backend/src/api/resources/EnterpriseAccount.ts
  • packages/backend/src/api/resources/EnterpriseConnection.ts
  • packages/shared/src/react/hooks/useOAuthConsent.tsx
  • packages/shared/src/react/hooks/useOAuthConsent.types.ts
  • packages/shared/src/types/oauthApplication.ts

Comment threadpackages/shared/src/react/hooks/useOAuthConsent.tsx

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.changeset/dry-mice-begin.md (1)

6-6: ⚡ Quick win

Consider a more detailed summary for the changelog.

The current summary "Fix OAuth consent component and hook related types" is quite vague. Based on the PR objectives and AI summary, the changes include:

  • Making oauthClientId required in useOAuthConsent params (was optional)
  • Adding new backend enterprise connection types (EnterpriseConnectionSamlConnection, EnterpriseConnectionOauthConfig)
  • Exposing previously internal OAuth consent types for TypeDoc

A more descriptive summary would help users understand the impact when reading the changelog. For example:

Expose OAuth consent types and enterprise connection nested types for documentation. Make `oauthClientId` required in `useOAuthConsent` to align types with runtime behavior.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog summary to be
more descriptive: replace the vague line "Fix OAuth consent component and hook
related types" with a concise explanation reflecting the actual changes (e.g.,
"Expose OAuth consent types and enterprise connection nested types for
documentation; make `oauthClientId` required in `useOAuthConsent` to align types
with runtime behavior"), and mention the added types
`EnterpriseConnectionSamlConnection` and `EnterpriseConnectionOauthConfig` plus
the exposure of previously internal OAuth consent types for TypeDoc so users
immediately see scope and impact.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog sentence "Fix OAuth consent component and hook
related types." to hyphenate the compound modifier by changing it to "Fix OAuth
consent component and hook-related types." Locate the exact string in the
.changeset entry and replace only the phrase "hook related" with "hook-related"
so punctuation and capitalization remain consistent.
---
Nitpick comments:
In @.changeset/dry-mice-begin.md:
- Line 6: Update the changelog summary to be more descriptive: replace the vague
line "Fix OAuth consent component and hook related types" with a concise
explanation reflecting the actual changes (e.g., "Expose OAuth consent types and
enterprise connection nested types for documentation; make `oauthClientId`
required in `useOAuthConsent` to align types with runtime behavior"), and
mention the added types `EnterpriseConnectionSamlConnection` and
`EnterpriseConnectionOauthConfig` plus the exposure of previously internal OAuth
consent types for TypeDoc so users immediately see scope and impact.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b385e1f5-cab1-4173-b00c-64c623024721

📥 Commits

Reviewing files that changed from the base of the PR and between 86427f3 and 1e27689.

📒 Files selected for processing (1)
  • .changeset/dry-mice-begin.md

"@clerk/shared": patch
---

Fix OAuth consent component and hook related types.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix grammar: hyphenate compound modifier.

"hook related types" should be "hook-related types" (hyphenated compound modifier).

📝 Proposed fix
-Fix OAuth consent component and hook related types.+Fix OAuth consent component and hook-related types.
📝 Committable suggestion

‼️IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Fix OAuth consent component and hookrelated types.
Fix OAuth consent component and hook-related types.
🧰 Tools
🪛 LanguageTool

[grammar] ~6-~6: Use a hyphen to join words.
Context: ...-- Fix OAuth consent component and hook related types.

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.changeset/dry-mice-begin.md at line 6, Update the changelog sentence "Fix
OAuth consent component and hook related types." to hyphenate the compound
modifier by changing it to "Fix OAuth consent component and hook-related types."
Locate the exact string in the .changeset entry and replace only the phrase
"hook related" with "hook-related" so punctuation and capitalization remain
consistent.

@wobsorianowobsoriano left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@SarahSoutoul

Copy link
Copy Markdown
ContributorAuthor

@alexisintech Rob and I just finished wrapping up this PR if we could get your eyes on it! Thank you!

@SarahSoutoul
SarahSoutoul requested a review from NWylynkoMay 6, 2026 15:16

@alexisintechalexisintech left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files are generating as expected 👍

Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Comment threadpackages/shared/src/types/oauthApplication.ts Outdated
Co-authored-by: Alexis Aguilar <98043211+alexisintech@users.noreply.github.com>
@jacekradko
jacekradko merged commit 7a5892f into mainMay 6, 2026
43 checks passed
@jacekradko
jacekradko deleted the ss/more-typedoc-outputs branch May 6, 2026 21:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@SarahSoutoul@wobsoriano@alexisintech@jacekradko