fix(ui): Add missing noop methods to unsafeMetadata field in SignUpStart by wobsoriano · Pull Request #8500 · clerk/javascript

wobsoriano · 2026-05-07T16:49:31Z

Description

Fixes TypeError: e.clearFeedback is not a function when <SignUp unsafeMetadata={...} /> is used and a Clerk API error is thrown. The unsafeMetadata synthetic field pushed to fieldsToSubmit was missing clearFeedback and setError stubs, unlike every other synthetic field in the same function.

Fixes#8496 #3996

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

vercel · 2026-05-07T16:49:36Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 7, 2026 6:06pm

changeset-bot · 2026-05-07T16:49:38Z

🦋 Changeset detected

Latest commit: 1f95f07

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-07T16:52:31Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7d30a8f4-902c-436a-a391-adbba08873dd

📥 Commits

Reviewing files that changed from the base of the PR and between d2fb45b and 1f95f07.

📒 Files selected for processing (1)

packages/ui/src/components/SignUp/__tests__/SignUpStart.test.tsx

📝 Walkthrough

Walkthrough

The SignUpStartInternal code now constructs unsafeMetadata as a FormControlState-shaped object (id, value, and no-op clearFeedback, setValue, onChange, setError) before appending it to fieldsToSubmit and calling buildRequest. A regression test was added that injects unsafeMetadata, mocks signUp.create to reject with a ClerkAPIResponseError, renders SignUpStart with a ticket URL, and asserts signUp.create is called without the component throwing. A .changeset patch entry was added for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main fix: adding missing noop methods (clearFeedback, setError) to the unsafeMetadata field in SignUpStart to resolve a TypeError.
Description check	✅ Passed	The description clearly explains the bug, root cause, and fix, directly relating to the code changes which add missing methods to the unsafeMetadata field.
Linked Issues check	✅ Passed	The changes address the core requirement from issue `#8496` by ensuring the unsafeMetadata field includes all necessary noop methods (clearFeedback, setError) that field-controller objects need, eliminating the TypeError when errors occur.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the unsafeMetadata field issue: updates to SignUpStart.tsx, addition of a regression test, and a changeset entry. No unrelated modifications are present.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/SignUp/__tests__/SignUpStart.test.tsx`:
- Line 492: The test uses a weak assertion
(expect(fixtures.signUp.create).toHaveBeenCalled()) which can pass before the
CardStateProvider's async error-handling (and the clearFeedback TypeError) runs;
update the test to assert a post-error side effect instead—either waitFor a
rendered error state that only appears after clearFeedback runs, or spy on
CardStateProvider's noop clearFeedback and assert that spy was called (and did
not throw); alternatively wrap the render in a helper that surfaces unhandled
promise rejections so failures in the async effect fail the test. Use
identifiers fixtures.signUp.create, CardStateProvider, and clearFeedback to
locate the code to change.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 5e794e81-be7a-4db1-832e-ebbee8ca8ac1

📥 Commits

Reviewing files that changed from the base of the PR and between 18b0964 and d2fb45b.

📒 Files selected for processing (2)

.changeset/wild-insects-design.md
packages/ui/src/components/SignUp/__tests__/SignUpStart.test.tsx

✅ Files skipped from review due to trivial changes (1)

.changeset/wild-insects-design.md

pkg-pr-new · 2026-05-07T17:03:22Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8500

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8500

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8500

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8500

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8500

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8500

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8500

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8500

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8500

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8500

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8500

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8500

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8500

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8500

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8500

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8500

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8500

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8500

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8500

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8500

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8500

commit: 1f95f07

bratsos

LGTM, even though 🐰 comment looks valid. Can you verify that removing your fix causes the tests to fail?

wobsoriano · 2026-05-07T18:06:25Z

LGTM, even though 🐰 comment looks valid. Can you verify that removing your fix causes the tests to fail?

Addressed CR's comment 👍🏼 Added a commit that verifies removing the fix causes the test to fail

fix(ui): Add missing noop methods to unsafeMetadata field in SignUpStart
18b0964

github-actionsBot added the ui label May 7, 2026

wobsoriano added 2 commits May 7, 2026 09:53

chore: add test
d14c415

chore: add changeset
d2fb45b

vercelBotdeployed to Preview May 7, 2026 16:54 View deployment

coderabbitaiBot reviewed May 7, 2026
View reviewed changes

Comment threadpackages/ui/src/components/SignUp/__tests__/SignUpStart.test.tsx Outdated

bratsos approved these changes May 7, 2026
View reviewed changes

tmilewski approved these changes May 7, 2026
View reviewed changes

chore: address comments and verify test fails when fix is removed
1f95f07

vercelBotdeployed to Preview May 7, 2026 18:06 View deployment

wobsoriano enabled auto-merge (squash) May 7, 2026 18:07

wobsoriano merged commit db3f1a9 into mainMay 7, 2026
73 of 74 checks passed

wobsoriano deleted the rob/fix-8496 branch May 7, 2026 18:22

clerk-cookie mentioned this pull request May 7, 2026
ci(repo): Version packages #8501
Merged

jacekradko mentioned this pull request May 7, 2026
test(ui): bump timeout on SignUpStart unsafeMetadata test #8504
Merged

wobsoriano mentioned this pull request May 12, 2026
test(ui): Drop low-signal flaky SignUpStart unsafeMetadata test #8529
Merged
9 tasks

Navigation Menu

Uh oh!

fix(ui): Add missing noop methods to unsafeMetadata field in SignUpStart - #8500

fix(ui): Add missing noop methods to unsafeMetadata field in SignUpStart#8500
wobsoriano merged 4 commits into
mainfrom
rob/fix-8496

wobsoriano commented May 7, 2026

Uh oh!

vercelBot commented May 7, 2026•
edited
Loading

Uh oh!

changeset-botBot commented May 7, 2026•
edited
Loading

Uh oh!

coderabbitaiBot commented May 7, 2026•
edited
Loading

Walkthrough

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

pkg-pr-newBot commented May 7, 2026•
edited
Loading

Uh oh!

bratsos left a comment

Uh oh!

wobsoriano commented May 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wobsoriano commented May 7, 2026

Description

Checklist

Type of change

Uh oh!

vercelBot commented May 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-botBot commented May 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitaiBot commented May 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

❌ Failed checks (1 warning)

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pkg-pr-newBot commented May 7, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bratsos left a comment

Choose a reason for hiding this comment

Uh oh!

wobsoriano commented May 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercelBot commented May 7, 2026•
edited
Loading

changeset-botBot commented May 7, 2026•
edited
Loading

coderabbitaiBot commented May 7, 2026•
edited
Loading

pkg-pr-newBot commented May 7, 2026•
edited
Loading