You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Introduce new elevation appearance option that allows rendering components "flush" on the page vs being wrapped in a card. Options include raised|flush with raised being the default for backwards compat.
Note this only applies to page-mounted components modals/popovers always use raised.
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
Use the following commands to manage reviews:
@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.
Use the checkboxes below for quick actions:
▶️ Resume reviews
🔍 Trigger review
📝 Walkthrough
Walkthrough
Adds an elevation appearance option for card-based UI with values 'raised' (default) and 'flush'. CardRoot reads modal context, an explicit prop, or parsed appearance options to determine elevation; flush injects element overrides and sets data-elevation="flush". Popover and profile cards (and modals) are forced to raised. The shadcn theme uses the attribute to drop shadow/border. The sandbox gets elevation and devWarnings controls with sessionStorage persistence and applies appearance updates during init.
Estimated code review effort
🎯 4 (Complex) | ⏱️ ~45 minutes
Possibly related PRs
clerk/javascript#8521: Adds another appearance option (autoFocus) and updates internal/appearance.ts and customizables/parseAppearance.ts, touching similar appearance-system code.
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check name
Status
Explanation
Resolution
Docstring Coverage
⚠️ Warning
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.
Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name
Status
Explanation
Title check
✅ Passed
The title 'feat(ui): Add flush appearance option' directly and clearly summarizes the main feature addition: introducing a new flush elevation appearance option for UI components.
Description check
✅ Passed
The description is well-related to the changeset, explaining the elevation appearance option, its raised/flush values, backwards compatibility, scope of application, and includes visual comparisons.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce new
elevationappearance option that allows rendering components "flush" on the page vs being wrapped in a card. Options includeraised|flushwithraisedbeing the default for backwards compat.Note this only applies to page-mounted components modals/popovers always use
raised.Docs: clerk/clerk-docs#3355
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change