Skip to content

feat(clerk-js,shared,ui): Add seats info to payment attempts page - #8527

Merged
aeliox merged 6 commits into
feat/per-seat-costsfrom
keiran/BILL-1752
May 19, 2026
Merged

feat(clerk-js,shared,ui): Add seats info to payment attempts page#8527
aeliox merged 6 commits into
feat/per-seat-costsfrom
keiran/BILL-1752

Conversation

@aeliox

@aelioxaeliox commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds seat info (limits, usage, and costs) to the payment attempts page of an OrganizationProfile's billing section.

Screenshot 2026-05-15 at 1 43 27 PM

@vercel

vercelBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 9:05pm

Request Review

@changeset-bot

changeset-botBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0dac161

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
NameType
@clerk/sharedMinor
@clerk/clerk-jsMinor
@clerk/uiMinor
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aeliox
aeliox marked this pull request as draft May 12, 2026 04:28
@coderabbitai

coderabbitaiBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

This PR introduces seat-based billing totals to payment attempts. It adds BillingPaymentTotals JSON and typed contracts, implements billingPaymentTotalsFromJSON with tests, extends the BillingPayment resource to include a totals field, adds utilities to extract and summarize seat charges (with tests), refactors the payment-attempt UI to render a conditional "Seats" line item, and adds a localization string and changeset note.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: adding seat information to the payment attempts page, directly corresponding to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description accurately describes the changeset, which adds seat information (limits, usage, and costs) to the payment attempts page.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot]
coderabbitaiBot reviewed May 12, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx`:
- Around line 232-243: The seats description currently always renders a
quantity×rate string; update the JSX in the PaymentAttemptPage component so that
when seatSummary.paidTier.quantity === null (an unlimited paid tier) you do not
render the "× {feePerBlock}" piece and instead only show the tier total,
otherwise keep the existing "{used} × {feePerBlock}" behavior; specifically
adjust the LineItems.Title description expression (using seatSummary,
seatSummary.paidTier.quantity, seatSummary.paidTier.feePerBlock and
seatSummary.paidTier.total) to branch on paidTier.quantity and produce the
appropriate string for unlimited vs. limited tiers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 1cd96259-918b-49c3-9ce0-6aa6a4195339

📥 Commits

Reviewing files that changed from the base of the PR and between c5fd14c and 454faa6.

📒 Files selected for processing (9)
  • .changeset/billing-seat-tier-rows-payment-attempt.md
  • packages/clerk-js/src/core/resources/BillingPayment.ts
  • packages/clerk-js/src/utils/__tests__/billing.test.ts
  • packages/clerk-js/src/utils/billing.ts
  • packages/shared/src/types/billing.ts
  • packages/shared/src/types/json.ts
  • packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
  • packages/ui/src/utils/__tests__/billingPlanSeats.test.ts
  • packages/ui/src/utils/billingPlanSeats.ts

Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
@pkg-pr-new

pkg-pr-newBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8527

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8527

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8527

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8527

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8527

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8527

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8527

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8527

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8527

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8527

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8527

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8527

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8527

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8527

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8527

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8527

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8527

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8527

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8527

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8527

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8527

commit: caaf316

@aeliox
aeliox marked this pull request as ready for review May 13, 2026 22:27
@aelioxaeliox changed the title feat(billing): Add seats info to payment attempts pagefeat(clerk-js): Add seats info to payment attempts pageMay 14, 2026
@aelioxaeliox changed the title feat(clerk-js): Add seats info to payment attempts pagefeat(clerk-js,shared,ui): Add seats info to payment attempts pageMay 14, 2026
@dstaley
dstaley changed the base branch from main to feat/per-seat-costsMay 14, 2026 14:28
dstaley
dstaley reviewed May 14, 2026
View reviewed changes
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx Outdated
Comment threadpackages/ui/src/utils/billingPlanSeats.ts Outdated
Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx Outdated
Comment threadpackages/shared/src/types/json.ts
Comment threadpackages/localizations/src/en-US.ts Outdated
@aeliox
aeliox requested a review from dstaleyMay 15, 2026 21:42
@aeliox
aeliox merged commit c4675c2 into feat/per-seat-costsMay 19, 2026
9 checks passed
@aeliox
aeliox deleted the keiran/BILL-1752 branch May 19, 2026 21:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@dstaleydstaleyAwaiting requested review from dstaley

Assignees

No one assigned

Labels

clerk-jslocalizationsui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aeliox@dstaley
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(clerk-js,shared,ui): Add seats info to payment attempts page by aeliox · Pull Request #8527 · clerk/javascript · GitHub
Skip to content
feat(clerk-js,shared,ui): Add seats info to payment attempts page - #8527
Merged
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
May 19, 2026
Merged
feat(clerk-js,shared,ui): Add seats info to payment attempts page#8527
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
Conversation
@aeliox
@aelioxaeliox
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Adds seat info (limits, usage, and costs) to the payment attempts page of an OrganizationProfile's billing section.
Screenshot 2026-05-15 at 1 43 27 PM
@vercel
vercelBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 9:05pm
Request Review
@changeset-bot
changeset-botBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0dac161
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/sharedMinor
@clerk/clerk-jsMinor
@clerk/uiMinor
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@aeliox
aeliox
marked this pull request as draft
May 12, 2026 04:28
@coderabbitai
coderabbitaiBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
This PR introduces seat-based billing totals to payment attempts. It adds BillingPaymentTotals JSON and typed contracts, implements billingPaymentTotalsFromJSON with tests, extends the BillingPayment resource to include a totals field, adds utilities to extract and summarize seat charges (with tests), refactors the payment-attempt UI to render a conditional "Seats" line item, and adds a localization string and changeset note.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: adding seat information to the payment attempts page, directly corresponding to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description accurately describes the changeset, which adds seat information (limits, usage, and costs) to the payment attempts page.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
May 12, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx`:
- Around line 232-243: The seats description currently always renders a
quantity×rate string; update the JSX in the PaymentAttemptPage component so that
when seatSummary.paidTier.quantity === null (an unlimited paid tier) you do not
render the "× {feePerBlock}" piece and instead only show the tier total,
otherwise keep the existing "{used} × {feePerBlock}" behavior; specifically
adjust the LineItems.Title description expression (using seatSummary,
seatSummary.paidTier.quantity, seatSummary.paidTier.feePerBlock and
seatSummary.paidTier.total) to branch on paidTier.quantity and produce the
appropriate string for unlimited vs. limited tiers.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1cd96259-918b-49c3-9ce0-6aa6a4195339
📥 Commits
Reviewing files that changed from the base of the PR and between c5fd14c and 454faa6.
📒 Files selected for processing (9)
  • .changeset/billing-seat-tier-rows-payment-attempt.md
  • packages/clerk-js/src/core/resources/BillingPayment.ts
  • packages/clerk-js/src/utils/__tests__/billing.test.ts
  • packages/clerk-js/src/utils/billing.ts
  • packages/shared/src/types/billing.ts
  • packages/shared/src/types/json.ts
  • packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
  • packages/ui/src/utils/__tests__/billingPlanSeats.test.ts
  • packages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
@pkg-pr-new
pkg-pr-newBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8527

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8527

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8527

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8527

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8527

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8527

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8527

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8527

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8527

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8527

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8527

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8527

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8527

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8527

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8527

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8527

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8527

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8527

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8527

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8527

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8527

commit: caaf316
@aeliox
aeliox
marked this pull request as ready for review
May 13, 2026 22:27
@aelioxaeliox
changed the title
feat(billing): Add seats info to payment attempts pagefeat(clerk-js): Add seats info to payment attempts pageMay 14, 2026
@aelioxaeliox
changed the title
feat(clerk-js): Add seats info to payment attempts pagefeat(clerk-js,shared,ui): Add seats info to payment attempts pageMay 14, 2026
@dstaley
dstaley
changed the base branch from
main
to
feat/per-seat-costsMay 14, 2026 14:28
dstaley
dstaley
reviewed
May 14, 2026
View reviewed changes
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/shared/src/types/json.ts
Comment threadpackages/localizations/src/en-US.ts
Outdated

@aeliox
aeliox
requested a review
from dstaleyMay 15, 2026 21:42
@aeliox
aeliox
merged commit c4675c2
into
feat/per-seat-costsMay 19, 2026

9 checks passed

@aeliox
aeliox
deleted the

keiran/BILL-1752

branch
May 19, 2026 21:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels

clerk-jslocalizationsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aeliox@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(clerk-js,shared,ui): Add seats info to payment attempts page by aeliox · Pull Request #8527 · clerk/javascript · GitHub
Skip to content
feat(clerk-js,shared,ui): Add seats info to payment attempts page - #8527
Merged
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
May 19, 2026
Merged
feat(clerk-js,shared,ui): Add seats info to payment attempts page#8527
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
Conversation
@aeliox
@aelioxaeliox
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Adds seat info (limits, usage, and costs) to the payment attempts page of an OrganizationProfile's billing section.
Screenshot 2026-05-15 at 1 43 27 PM
@vercel
vercelBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 9:05pm
Request Review
@changeset-bot
changeset-botBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0dac161
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/sharedMinor
@clerk/clerk-jsMinor
@clerk/uiMinor
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@aeliox
aeliox
marked this pull request as draft
May 12, 2026 04:28
@coderabbitai
coderabbitaiBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
This PR introduces seat-based billing totals to payment attempts. It adds BillingPaymentTotals JSON and typed contracts, implements billingPaymentTotalsFromJSON with tests, extends the BillingPayment resource to include a totals field, adds utilities to extract and summarize seat charges (with tests), refactors the payment-attempt UI to render a conditional "Seats" line item, and adds a localization string and changeset note.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: adding seat information to the payment attempts page, directly corresponding to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description accurately describes the changeset, which adds seat information (limits, usage, and costs) to the payment attempts page.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
May 12, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx`:
- Around line 232-243: The seats description currently always renders a
quantity×rate string; update the JSX in the PaymentAttemptPage component so that
when seatSummary.paidTier.quantity === null (an unlimited paid tier) you do not
render the "× {feePerBlock}" piece and instead only show the tier total,
otherwise keep the existing "{used} × {feePerBlock}" behavior; specifically
adjust the LineItems.Title description expression (using seatSummary,
seatSummary.paidTier.quantity, seatSummary.paidTier.feePerBlock and
seatSummary.paidTier.total) to branch on paidTier.quantity and produce the
appropriate string for unlimited vs. limited tiers.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1cd96259-918b-49c3-9ce0-6aa6a4195339
📥 Commits
Reviewing files that changed from the base of the PR and between c5fd14c and 454faa6.
📒 Files selected for processing (9)
  • .changeset/billing-seat-tier-rows-payment-attempt.md
  • packages/clerk-js/src/core/resources/BillingPayment.ts
  • packages/clerk-js/src/utils/__tests__/billing.test.ts
  • packages/clerk-js/src/utils/billing.ts
  • packages/shared/src/types/billing.ts
  • packages/shared/src/types/json.ts
  • packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
  • packages/ui/src/utils/__tests__/billingPlanSeats.test.ts
  • packages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
@pkg-pr-new
pkg-pr-newBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8527

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8527

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8527

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8527

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8527

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8527

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8527

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8527

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8527

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8527

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8527

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8527

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8527

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8527

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8527

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8527

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8527

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8527

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8527

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8527

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8527

commit: caaf316
@aeliox
aeliox
marked this pull request as ready for review
May 13, 2026 22:27
@aelioxaeliox
changed the title
feat(billing): Add seats info to payment attempts pagefeat(clerk-js): Add seats info to payment attempts pageMay 14, 2026
@aelioxaeliox
changed the title
feat(clerk-js): Add seats info to payment attempts pagefeat(clerk-js,shared,ui): Add seats info to payment attempts pageMay 14, 2026
@dstaley
dstaley
changed the base branch from
main
to
feat/per-seat-costsMay 14, 2026 14:28
dstaley
dstaley
reviewed
May 14, 2026
View reviewed changes
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/shared/src/types/json.ts
Comment threadpackages/localizations/src/en-US.ts
Outdated

@aeliox
aeliox
requested a review
from dstaleyMay 15, 2026 21:42
@aeliox
aeliox
merged commit c4675c2
into
feat/per-seat-costsMay 19, 2026

9 checks passed

@aeliox
aeliox
deleted the

keiran/BILL-1752

branch
May 19, 2026 21:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels

clerk-jslocalizationsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aeliox@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(clerk-js,shared,ui): Add seats info to payment attempts page by aeliox · Pull Request #8527 · clerk/javascript · GitHub
Skip to content
feat(clerk-js,shared,ui): Add seats info to payment attempts page - #8527
Merged
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
May 19, 2026
Merged
feat(clerk-js,shared,ui): Add seats info to payment attempts page#8527
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
Conversation
@aeliox
@aelioxaeliox
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Adds seat info (limits, usage, and costs) to the payment attempts page of an OrganizationProfile's billing section.
Screenshot 2026-05-15 at 1 43 27 PM
@vercel
vercelBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 9:05pm
Request Review
@changeset-bot
changeset-botBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0dac161
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/sharedMinor
@clerk/clerk-jsMinor
@clerk/uiMinor
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@aeliox
aeliox
marked this pull request as draft
May 12, 2026 04:28
@coderabbitai
coderabbitaiBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
This PR introduces seat-based billing totals to payment attempts. It adds BillingPaymentTotals JSON and typed contracts, implements billingPaymentTotalsFromJSON with tests, extends the BillingPayment resource to include a totals field, adds utilities to extract and summarize seat charges (with tests), refactors the payment-attempt UI to render a conditional "Seats" line item, and adds a localization string and changeset note.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: adding seat information to the payment attempts page, directly corresponding to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description accurately describes the changeset, which adds seat information (limits, usage, and costs) to the payment attempts page.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
May 12, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx`:
- Around line 232-243: The seats description currently always renders a
quantity×rate string; update the JSX in the PaymentAttemptPage component so that
when seatSummary.paidTier.quantity === null (an unlimited paid tier) you do not
render the "× {feePerBlock}" piece and instead only show the tier total,
otherwise keep the existing "{used} × {feePerBlock}" behavior; specifically
adjust the LineItems.Title description expression (using seatSummary,
seatSummary.paidTier.quantity, seatSummary.paidTier.feePerBlock and
seatSummary.paidTier.total) to branch on paidTier.quantity and produce the
appropriate string for unlimited vs. limited tiers.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1cd96259-918b-49c3-9ce0-6aa6a4195339
📥 Commits
Reviewing files that changed from the base of the PR and between c5fd14c and 454faa6.
📒 Files selected for processing (9)
  • .changeset/billing-seat-tier-rows-payment-attempt.md
  • packages/clerk-js/src/core/resources/BillingPayment.ts
  • packages/clerk-js/src/utils/__tests__/billing.test.ts
  • packages/clerk-js/src/utils/billing.ts
  • packages/shared/src/types/billing.ts
  • packages/shared/src/types/json.ts
  • packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
  • packages/ui/src/utils/__tests__/billingPlanSeats.test.ts
  • packages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
@pkg-pr-new
pkg-pr-newBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8527

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8527

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8527

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8527

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8527

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8527

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8527

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8527

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8527

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8527

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8527

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8527

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8527

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8527

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8527

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8527

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8527

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8527

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8527

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8527

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8527

commit: caaf316
@aeliox
aeliox
marked this pull request as ready for review
May 13, 2026 22:27
@aelioxaeliox
changed the title
feat(billing): Add seats info to payment attempts pagefeat(clerk-js): Add seats info to payment attempts pageMay 14, 2026
@aelioxaeliox
changed the title
feat(clerk-js): Add seats info to payment attempts pagefeat(clerk-js,shared,ui): Add seats info to payment attempts pageMay 14, 2026
@dstaley
dstaley
changed the base branch from
main
to
feat/per-seat-costsMay 14, 2026 14:28
dstaley
dstaley
reviewed
May 14, 2026
View reviewed changes
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/shared/src/types/json.ts
Comment threadpackages/localizations/src/en-US.ts
Outdated

@aeliox
aeliox
requested a review
from dstaleyMay 15, 2026 21:42
@aeliox
aeliox
merged commit c4675c2
into
feat/per-seat-costsMay 19, 2026

9 checks passed

@aeliox
aeliox
deleted the

keiran/BILL-1752

branch
May 19, 2026 21:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels

clerk-jslocalizationsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aeliox@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
feat(clerk-js,shared,ui): Add seats info to payment attempts page by aeliox · Pull Request #8527 · clerk/javascript · GitHub
Skip to content
feat(clerk-js,shared,ui): Add seats info to payment attempts page - #8527
Merged
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
May 19, 2026
Merged
feat(clerk-js,shared,ui): Add seats info to payment attempts page#8527
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
Conversation
@aeliox
@aelioxaeliox
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Adds seat info (limits, usage, and costs) to the payment attempts page of an OrganizationProfile's billing section.
Screenshot 2026-05-15 at 1 43 27 PM
@vercel
vercelBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 9:05pm
Request Review
@changeset-bot
changeset-botBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0dac161
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/sharedMinor
@clerk/clerk-jsMinor
@clerk/uiMinor
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@aeliox
aeliox
marked this pull request as draft
May 12, 2026 04:28
@coderabbitai
coderabbitaiBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
This PR introduces seat-based billing totals to payment attempts. It adds BillingPaymentTotals JSON and typed contracts, implements billingPaymentTotalsFromJSON with tests, extends the BillingPayment resource to include a totals field, adds utilities to extract and summarize seat charges (with tests), refactors the payment-attempt UI to render a conditional "Seats" line item, and adds a localization string and changeset note.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: adding seat information to the payment attempts page, directly corresponding to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description accurately describes the changeset, which adds seat information (limits, usage, and costs) to the payment attempts page.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
May 12, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx`:
- Around line 232-243: The seats description currently always renders a
quantity×rate string; update the JSX in the PaymentAttemptPage component so that
when seatSummary.paidTier.quantity === null (an unlimited paid tier) you do not
render the "× {feePerBlock}" piece and instead only show the tier total,
otherwise keep the existing "{used} × {feePerBlock}" behavior; specifically
adjust the LineItems.Title description expression (using seatSummary,
seatSummary.paidTier.quantity, seatSummary.paidTier.feePerBlock and
seatSummary.paidTier.total) to branch on paidTier.quantity and produce the
appropriate string for unlimited vs. limited tiers.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1cd96259-918b-49c3-9ce0-6aa6a4195339
📥 Commits
Reviewing files that changed from the base of the PR and between c5fd14c and 454faa6.
📒 Files selected for processing (9)
  • .changeset/billing-seat-tier-rows-payment-attempt.md
  • packages/clerk-js/src/core/resources/BillingPayment.ts
  • packages/clerk-js/src/utils/__tests__/billing.test.ts
  • packages/clerk-js/src/utils/billing.ts
  • packages/shared/src/types/billing.ts
  • packages/shared/src/types/json.ts
  • packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
  • packages/ui/src/utils/__tests__/billingPlanSeats.test.ts
  • packages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
@pkg-pr-new
pkg-pr-newBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8527

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8527

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8527

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8527

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8527

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8527

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8527

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8527

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8527

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8527

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8527

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8527

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8527

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8527

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8527

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8527

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8527

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8527

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8527

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8527

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8527

commit: caaf316
@aeliox
aeliox
marked this pull request as ready for review
May 13, 2026 22:27
@aelioxaeliox
changed the title
feat(billing): Add seats info to payment attempts pagefeat(clerk-js): Add seats info to payment attempts pageMay 14, 2026
@aelioxaeliox
changed the title
feat(clerk-js): Add seats info to payment attempts pagefeat(clerk-js,shared,ui): Add seats info to payment attempts pageMay 14, 2026
@dstaley
dstaley
changed the base branch from
main
to
feat/per-seat-costsMay 14, 2026 14:28
dstaley
dstaley
reviewed
May 14, 2026
View reviewed changes
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/shared/src/types/json.ts
Comment threadpackages/localizations/src/en-US.ts
Outdated

@aeliox
aeliox
requested a review
from dstaleyMay 15, 2026 21:42
@aeliox
aeliox
merged commit c4675c2
into
feat/per-seat-costsMay 19, 2026

9 checks passed

@aeliox
aeliox
deleted the

keiran/BILL-1752

branch
May 19, 2026 21:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels

clerk-jslocalizationsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aeliox@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
feat(clerk-js,shared,ui): Add seats info to payment attempts page by aeliox · Pull Request #8527 · clerk/javascript · GitHub
Skip to content
feat(clerk-js,shared,ui): Add seats info to payment attempts page - #8527
Merged
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
May 19, 2026
Merged
feat(clerk-js,shared,ui): Add seats info to payment attempts page#8527
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
Conversation
@aeliox
@aelioxaeliox
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Adds seat info (limits, usage, and costs) to the payment attempts page of an OrganizationProfile's billing section.
Screenshot 2026-05-15 at 1 43 27 PM
@vercel
vercelBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 9:05pm
Request Review
@changeset-bot
changeset-botBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0dac161
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/sharedMinor
@clerk/clerk-jsMinor
@clerk/uiMinor
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@aeliox
aeliox
marked this pull request as draft
May 12, 2026 04:28
@coderabbitai
coderabbitaiBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
This PR introduces seat-based billing totals to payment attempts. It adds BillingPaymentTotals JSON and typed contracts, implements billingPaymentTotalsFromJSON with tests, extends the BillingPayment resource to include a totals field, adds utilities to extract and summarize seat charges (with tests), refactors the payment-attempt UI to render a conditional "Seats" line item, and adds a localization string and changeset note.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: adding seat information to the payment attempts page, directly corresponding to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description accurately describes the changeset, which adds seat information (limits, usage, and costs) to the payment attempts page.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
May 12, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx`:
- Around line 232-243: The seats description currently always renders a
quantity×rate string; update the JSX in the PaymentAttemptPage component so that
when seatSummary.paidTier.quantity === null (an unlimited paid tier) you do not
render the "× {feePerBlock}" piece and instead only show the tier total,
otherwise keep the existing "{used} × {feePerBlock}" behavior; specifically
adjust the LineItems.Title description expression (using seatSummary,
seatSummary.paidTier.quantity, seatSummary.paidTier.feePerBlock and
seatSummary.paidTier.total) to branch on paidTier.quantity and produce the
appropriate string for unlimited vs. limited tiers.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1cd96259-918b-49c3-9ce0-6aa6a4195339
📥 Commits
Reviewing files that changed from the base of the PR and between c5fd14c and 454faa6.
📒 Files selected for processing (9)
  • .changeset/billing-seat-tier-rows-payment-attempt.md
  • packages/clerk-js/src/core/resources/BillingPayment.ts
  • packages/clerk-js/src/utils/__tests__/billing.test.ts
  • packages/clerk-js/src/utils/billing.ts
  • packages/shared/src/types/billing.ts
  • packages/shared/src/types/json.ts
  • packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
  • packages/ui/src/utils/__tests__/billingPlanSeats.test.ts
  • packages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
@pkg-pr-new
pkg-pr-newBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8527

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8527

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8527

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8527

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8527

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8527

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8527

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8527

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8527

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8527

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8527

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8527

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8527

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8527

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8527

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8527

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8527

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8527

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8527

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8527

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8527

commit: caaf316
@aeliox
aeliox
marked this pull request as ready for review
May 13, 2026 22:27
@aelioxaeliox
changed the title
feat(billing): Add seats info to payment attempts pagefeat(clerk-js): Add seats info to payment attempts pageMay 14, 2026
@aelioxaeliox
changed the title
feat(clerk-js): Add seats info to payment attempts pagefeat(clerk-js,shared,ui): Add seats info to payment attempts pageMay 14, 2026
@dstaley
dstaley
changed the base branch from
main
to
feat/per-seat-costsMay 14, 2026 14:28
dstaley
dstaley
reviewed
May 14, 2026
View reviewed changes
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/shared/src/types/json.ts
Comment threadpackages/localizations/src/en-US.ts
Outdated

@aeliox
aeliox
requested a review
from dstaleyMay 15, 2026 21:42
@aeliox
aeliox
merged commit c4675c2
into
feat/per-seat-costsMay 19, 2026

9 checks passed

@aeliox
aeliox
deleted the

keiran/BILL-1752

branch
May 19, 2026 21:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels

clerk-jslocalizationsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aeliox@dstaley

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
feat(clerk-js,shared,ui): Add seats info to payment attempts page by aeliox · Pull Request #8527 · clerk/javascript · GitHub
Skip to content
feat(clerk-js,shared,ui): Add seats info to payment attempts page - #8527
Merged
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
May 19, 2026
Merged
feat(clerk-js,shared,ui): Add seats info to payment attempts page#8527
aeliox merged 6 commits into
feat/per-seat-costsfrom 
keiran/BILL-1752
Conversation
@aeliox
@aelioxaeliox
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Adds seat info (limits, usage, and costs) to the payment attempts page of an OrganizationProfile's billing section.
Screenshot 2026-05-15 at 1 43 27 PM
@vercel
vercelBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 9:05pm
Request Review
@changeset-bot
changeset-botBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 0dac161
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 20 packages
NameType
@clerk/sharedMinor
@clerk/clerk-jsMinor
@clerk/uiMinor
@clerk/astroPatch
@clerk/backendPatch
@clerk/chrome-extensionPatch
@clerk/expo-passkeysPatch
@clerk/expoPatch
@clerk/expressPatch
@clerk/fastifyPatch
@clerk/honoPatch
@clerk/localizationsPatch
@clerk/mswPatch
@clerk/nextjsPatch
@clerk/nuxtPatch
@clerk/react-routerPatch
@clerk/reactPatch
@clerk/tanstack-react-startPatch
@clerk/testingPatch
@clerk/vuePatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@aeliox
aeliox
marked this pull request as draft
May 12, 2026 04:28
@coderabbitai
coderabbitaiBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
This PR introduces seat-based billing totals to payment attempts. It adds BillingPaymentTotals JSON and typed contracts, implements billingPaymentTotalsFromJSON with tests, extends the BillingPayment resource to include a totals field, adds utilities to extract and summarize seat charges (with tests), refactors the payment-attempt UI to render a conditional "Seats" line item, and adds a localization string and changeset note.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~20 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately summarizes the main change: adding seat information to the payment attempts page, directly corresponding to the changeset.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description accurately describes the changeset, which adds seat information (limits, usage, and costs) to the payment attempts page.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
coderabbitai[bot]
coderabbitaiBot
reviewed
May 12, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx`:
- Around line 232-243: The seats description currently always renders a
quantity×rate string; update the JSX in the PaymentAttemptPage component so that
when seatSummary.paidTier.quantity === null (an unlimited paid tier) you do not
render the "× {feePerBlock}" piece and instead only show the tier total,
otherwise keep the existing "{used} × {feePerBlock}" behavior; specifically
adjust the LineItems.Title description expression (using seatSummary,
seatSummary.paidTier.quantity, seatSummary.paidTier.feePerBlock and
seatSummary.paidTier.total) to branch on paidTier.quantity and produce the
appropriate string for unlimited vs. limited tiers.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 1cd96259-918b-49c3-9ce0-6aa6a4195339
📥 Commits
Reviewing files that changed from the base of the PR and between c5fd14c and 454faa6.
📒 Files selected for processing (9)
  • .changeset/billing-seat-tier-rows-payment-attempt.md
  • packages/clerk-js/src/core/resources/BillingPayment.ts
  • packages/clerk-js/src/utils/__tests__/billing.test.ts
  • packages/clerk-js/src/utils/billing.ts
  • packages/shared/src/types/billing.ts
  • packages/shared/src/types/json.ts
  • packages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
  • packages/ui/src/utils/__tests__/billingPlanSeats.test.ts
  • packages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
@pkg-pr-new
pkg-pr-newBot
commented
May 12, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8527

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8527

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8527

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8527

@clerk/dev-cli
npm i https://pkg.pr.new/@clerk/dev-cli@8527

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8527

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8527

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8527

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8527

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8527

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8527

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8527

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8527

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8527

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8527

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8527

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8527

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8527

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8527

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8527

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8527

commit: caaf316
@aeliox
aeliox
marked this pull request as ready for review
May 13, 2026 22:27
@aelioxaeliox
changed the title
feat(billing): Add seats info to payment attempts pagefeat(clerk-js): Add seats info to payment attempts pageMay 14, 2026
@aelioxaeliox
changed the title
feat(clerk-js): Add seats info to payment attempts pagefeat(clerk-js,shared,ui): Add seats info to payment attempts pageMay 14, 2026
@dstaley
dstaley
changed the base branch from
main
to
feat/per-seat-costsMay 14, 2026 14:28
dstaley
dstaley
reviewed
May 14, 2026
View reviewed changes
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Outdated

Comment threadpackages/ui/src/utils/billingPlanSeats.ts
Comment threadpackages/ui/src/components/PaymentAttempts/PaymentAttemptPage.tsx
Outdated

Comment threadpackages/shared/src/types/json.ts
Comment threadpackages/localizations/src/en-US.ts
Outdated

@aeliox
aeliox
requested a review
from dstaleyMay 15, 2026 21:42
@aeliox
aeliox
merged commit c4675c2
into
feat/per-seat-costsMay 19, 2026

9 checks passed

@aeliox
aeliox
deleted the

keiran/BILL-1752

branch
May 19, 2026 21:50
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
@dstaleydstaleyAwaiting requested review from dstaley

Assignees


No one assigned


Labels

clerk-jslocalizationsui

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aeliox@dstaley