') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(ui): don't treat numeric usernames as phone numbers by thiskevinwang · Pull Request #8532 · clerk/javascript · GitHub
Skip to content

fix(ui): don't treat numeric usernames as phone numbers - #8532

Merged
wobsoriano merged 1 commit into
mainfrom
kevin/aie-953-clerkjavascript-dont-parse-a-numeric-username-as-phonenumber
May 13, 2026
Merged

fix(ui): don't treat numeric usernames as phone numbers#8532
wobsoriano merged 1 commit into
mainfrom
kevin/aie-953-clerkjavascript-dont-parse-a-numeric-username-as-phonenumber

Conversation

@thiskevinwang

@thiskevinwangthiskevinwang commented May 12, 2026

Copy link
Copy Markdown
Member

Description

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercelBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 13, 2026 1:24pm

Request Review

@changeset-bot

changeset-botBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e11a8bb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
NameType
@clerk/uiPatch
@clerk/chrome-extensionPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitaiBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 14916a9d-614d-4be8-b6db-266184f2d086

📥 Commits

Reviewing files that changed from the base of the PR and between ace9af6 and e11a8bb.

📒 Files selected for processing (3)
  • .changeset/quiet-dancers-carry.md
  • packages/ui/src/utils/__tests__/formatSafeIdentifier.test.ts
  • packages/ui/src/utils/formatSafeIdentifier.ts
✅ Files skipped from review due to trivial changes (1)
  • .changeset/quiet-dancers-carry.md
📝 Walkthrough

Walkthrough

This PR changes formatSafeIdentifier's early-return guard to require that the input does not start with '+' before bypassing phone formatting, adds a test asserting "4245554242" is returned unchanged, and includes a changeset entry documenting the fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check nameStatusExplanationResolution
Description check❓ InconclusiveThe description contains only the template boilerplate without any meaningful details about the changes, testing instructions, or implementation context.Fill in the description template with specific details about the fix, how to test it, and the rationale for the changes made.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title clearly and concisely describes the main change: preventing numeric usernames from being treated as phone numbers, which aligns with all modifications across the test, implementation, and changeset files.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 12, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8532

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8532

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8532

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8532

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8532

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8532

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8532

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8532

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8532

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8532

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8532

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8532

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8532

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8532

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8532

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8532

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8532

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8532

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8532

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8532

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8532

commit: e11a8bb

@thiskevinwang
thiskevinwangforce-pushed the kevin/aie-953-clerkjavascript-dont-parse-a-numeric-username-as-phonenumber branch from bec4d05 to c6335caCompareMay 12, 2026 19:55
@thiskevinwang
thiskevinwangforce-pushed the kevin/aie-953-clerkjavascript-dont-parse-a-numeric-username-as-phonenumber branch from c6335ca to 5931b01CompareMay 12, 2026 20:53
@thiskevinwang
thiskevinwangforce-pushed the kevin/aie-953-clerkjavascript-dont-parse-a-numeric-username-as-phonenumber branch from 5931b01 to ace9af6CompareMay 12, 2026 20:54
@thiskevinwang
thiskevinwangforce-pushed the kevin/aie-953-clerkjavascript-dont-parse-a-numeric-username-as-phonenumber branch from ace9af6 to e11a8bbCompareMay 13, 2026 13:24
@wobsoriano
wobsoriano merged commit a1fc21c into mainMay 13, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the kevin/aie-953-clerkjavascript-dont-parse-a-numeric-username-as-phonenumber branch May 13, 2026 14:01
@clerk-cookieclerk-cookie mentioned this pull request May 13, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes
@brkalowbrkalowAwaiting requested review from brkalow

Assignees

No one assigned

Labels

ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thiskevinwang@brkalow@wobsoriano