fix(ui): Extract ref from ExternalElementMounter props to prevent nodeRef overwrite (React 19) by wobsoriano · Pull Request #8534 · clerk/javascript

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

wobsoriano · 2026-05-12T17:56:11Z

Description

In React 19, ref is a regular prop for function components (see ref as a prop). A forwarded ref was landing in ...rest inside ExternalElementMounter and overwriting ref={nodeRef} on the host div, so nodeRef.current stayed null and mountIcon was never called. React 18 silently dropped the ref, masking the bug.
Extracts ref from props before the spread to fix the collision.
Adds unit tests for mount/unmount behavior and the React 19 regression path.

Fixes#8512 #8447
Resolves SDK-73

Checklist

pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
(If applicable) Documentation has been updated

Type of change

…eRef overwrite (React 19)

vercel · 2026-05-12T17:56:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
clerk-js-sandbox	Ready	Preview, Comment	May 12, 2026 9:31pm

changeset-bot · 2026-05-12T17:56:21Z

🦋 Changeset detected

Latest commit: 88acc26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@clerk/ui	Patch
@clerk/chrome-extension	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-05-12T18:59:41Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 26c7b660-d859-4e3e-91d4-493372813750

📥 Commits

Reviewing files that changed from the base of the PR and between 01c777e and 88acc26.

📒 Files selected for processing (1)

.changeset/soft-worms-battle.md

✅ Files skipped from review due to trivial changes (1)

.changeset/soft-worms-battle.md

📝 Walkthrough

Walkthrough

This PR prevents a forwarded ref from being spread onto ExternalElementMounter's host div by explicitly destructuring ref (renamed _forwardedRef) from props, preserving the component's internal nodeRef so mount runs and unmount cleans up. It adds tests that assert mount/unmount behavior with and without a forwarded ref and includes a changeset patch entry for @clerk/ui.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main fix: extracting ref from props in ExternalElementMounter to prevent nodeRef overwrite in React 19.
Description check	✅ Passed	The description clearly explains the React 19 regression, the fix approach, and references the related issues with a detailed explanation of the problem and solution.
Linked Issues check	✅ Passed	The PR successfully addresses all requirements from issue `#8512`: extracts ref from props to prevent collision, ensures mount() is invoked properly, restores React 18/19 consistency, and adds comprehensive tests covering the regression path.
Out of Scope Changes check	✅ Passed	All changes directly support the linked issue objectives: the ExternalElementMounter fix, test coverage for mount/unmount behavior, and the changesets entry documenting the patch version bump.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

pkg-pr-new · 2026-05-12T19:10:00Z

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8534

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8534

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8534

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8534

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8534

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8534

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8534

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8534

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8534

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8534

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8534

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8534

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8534

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8534

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8534

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8534

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8534

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8534

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8534

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8534

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8534

commit: 88acc26

…rendered-when-ui-package-is

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

fix(ui): Extract ref from ExternalElementMounter props to prevent nod…
2c92423
…eRef overwrite (React 19)

github-actionsBot added the ui label May 12, 2026

chore: run format
b25229d

vercelBotdeployed to Preview May 12, 2026 18:00 View deployment

chore: add changeset
01c777e

vercelBotdeployed to Preview May 12, 2026 18:05 View deployment

wobsoriano marked this pull request as ready for review May 12, 2026 18:54

wobsoriano marked this pull request as draft May 12, 2026 18:55

wobsoriano marked this pull request as ready for review May 12, 2026 21:30

wobsoriano added 2 commits May 12, 2026 13:30

Merge branch 'main' into rob/sdk-73-userprofile-custom-page-icon-not-…
c5f5f25
…rendered-when-ui-package-is

chore: update changeset
88acc26

vercelBotdeployed to Preview May 12, 2026 21:31 View deployment

alexcarpenter approved these changes May 13, 2026
View reviewed changes

wobsoriano merged commit 9a360c9 into mainMay 13, 2026
43 checks passed

wobsoriano deleted the rob/sdk-73-userprofile-custom-page-icon-not-rendered-when-ui-package-is branch May 13, 2026 15:01

wobsoriano mentioned this pull request May 13, 2026
labelIcon of <UserButton.UserProfilePage> not showing if ui is provided in ClerkProvider#8447
Closed
4 tasks

clerk-cookie mentioned this pull request May 13, 2026
ci(repo): Version packages #8518
Merged

Uh oh!

Conversation

wobsoriano commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

vercelBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-botBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitaiBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Review ran into problems

Uh oh!

pkg-pr-newBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wobsoriano commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

vercelBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-botBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

coderabbitaiBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Review ran into problems

Uh oh!

pkg-pr-newBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

wobsoriano commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Type of change

Uh oh!

vercelBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-botBot commented May 12, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

wobsoriano commented May 12, 2026•
edited
Loading

vercelBot commented May 12, 2026•
edited
Loading

changeset-botBot commented May 12, 2026•
edited
Loading

coderabbitaiBot commented May 12, 2026•
edited
Loading

pkg-pr-newBot commented May 12, 2026•
edited
Loading

wobsoriano commented May 12, 2026•
edited
Loading

vercelBot commented May 12, 2026•
edited
Loading

changeset-botBot commented May 12, 2026•
edited
Loading

coderabbitaiBot commented May 12, 2026•
edited
Loading

pkg-pr-newBot commented May 12, 2026•
edited
Loading

wobsoriano commented May 12, 2026•
edited
Loading

vercelBot commented May 12, 2026•
edited
Loading

changeset-botBot commented May 12, 2026•
edited
Loading

coderabbitaiBot commented May 12, 2026•
edited
Loading

pkg-pr-newBot commented May 12, 2026•
edited
Loading

wobsoriano commented May 12, 2026•
edited
Loading

vercelBot commented May 12, 2026•
edited
Loading

changeset-botBot commented May 12, 2026•
edited
Loading

coderabbitaiBot commented May 12, 2026•
edited
Loading

pkg-pr-newBot commented May 12, 2026•
edited
Loading