Uh oh!
There was an error while loading. Please reload this page.
feat(ui): Add support for localization nodes - #8539
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 4fe4353 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds parsing and rendering for inline markup (converted to React ), integrates node-based localized rendering via localizedNodeFromKey, makes t() return markup-stripped strings, tightens token matching to own properties, and includes extensive tests covering correctness, injection-resistance, malformed-input fallbacks, performance bounds, SSR determinism, and module-state isolation. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
jacekradko
commented
May 14, 2026
@alexcarpenter are we planning on supporting |
Description
Add support for inline
<bold>markup in localization values, rendered as<strong>elements. Translators can now write'Agree to <bold>Terms</bold>'in a single key instead of splitting into prefix/bold/suffix fragments. Token values are substituted only into parsed text leaves, so user-controlled data can never become markup. Also hardensapplyTokensToStringto useObject.prototype.hasOwnProperty.callwhen filtering token names, preventing prototype-chain names like{{hasOwnProperty}}from crashing rendering.in support for #8535
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change