Skip to content

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs - #8562

Merged
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client
May 15, 2026
Merged

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs#8562
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

clerk-js@6.11.0 removed clerk.__internal_queryClient as part of #8434, which moved QueryClient ownership into @clerk/shared. However, apps still on @clerk/shared < 4.10.0 rely on that getter to initialize TanStack Query. With clerk-js auto-updating from the CDN, those apps started seeing useOrganizationList and useOrganization return empty data with no network request.

This PR restores the getter as a backward compat shim:

Behavior

  • Updated SDKs (@clerk/shared >= 4.10.0): no change, getter is never accessed, chunk is never fetched
  • Older SDKs (@clerk/shared < 4.10.0): getter works again, queries fire, data loads

Test plan

  • 4 new tests covering initial undefined state, post-resolve shape, instance stability, and queryClientStatus event emission
  • Full @clerk/clerk-js test suite passes (722 tests)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented May 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d328a48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 8:46pm

Request Review

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4932e68-7a54-429d-acd2-64cb7d83ec3a

📥 Commits

Reviewing files that changed from the base of the PR and between 74dca0b and d328a48.

📒 Files selected for processing (3)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json
  • packages/clerk-js/src/core/__tests__/clerk.internal-query-client.test.ts
✅ Files skipped from review due to trivial changes (2)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json

📝 Walkthrough

Walkthrough

This PR restores a backward-compatible internal React Query client on Clerk via a new lazy-loading getter __internal_queryClient. It adds a re-export module for QueryClient, a private field and getter on Clerk that dynamically imports and instantiates QueryClient, emits queryClientStatus when ready, and caches the instance. Build changes add @tanstack/query-core, configure Rspack to split it into a query-core-vendors chunk, and update bundlewatch thresholds. Tests exercise lazy initialization, singleton behavior, and event emission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: restoring an internal queryClient getter as a backward compatibility shim after it was removed in a previous version.
Description check✅ PassedThe description provides relevant context about the change, explaining why the getter was removed, why it needs to be restored, and how the implementation addresses backward compatibility concerns.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8562

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8562

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8562

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8562

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8562

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8562

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8562

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8562

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8562

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8562

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8562

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8562

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8562

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8562

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8562

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8562

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8562

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8562

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8562

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8562

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8562

commit: d328a48

…ent shim
- Use void to discard getter expressions in tests (no-unused-expressions)
- Add patch changeset for @clerk/clerk-js
- Bump clerk.js (543->549KB) and clerk.no-rhc.js (311->316KB) for the
query-core dynamic-import infrastructure re-added by the shim
@wobsoriano
wobsoriano merged commit 692b68d into mainMay 15, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/revert-internal-query-client branch May 15, 2026 23:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(clerk-js): Restore internal queryClient for backward compat with older SDKs by wobsoriano · Pull Request #8562 · clerk/javascript · GitHub
Skip to content

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs - #8562

Merged
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client
May 15, 2026
Merged

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs#8562
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

clerk-js@6.11.0 removed clerk.__internal_queryClient as part of #8434, which moved QueryClient ownership into @clerk/shared. However, apps still on @clerk/shared < 4.10.0 rely on that getter to initialize TanStack Query. With clerk-js auto-updating from the CDN, those apps started seeing useOrganizationList and useOrganization return empty data with no network request.

This PR restores the getter as a backward compat shim:

Behavior

  • Updated SDKs (@clerk/shared >= 4.10.0): no change, getter is never accessed, chunk is never fetched
  • Older SDKs (@clerk/shared < 4.10.0): getter works again, queries fire, data loads

Test plan

  • 4 new tests covering initial undefined state, post-resolve shape, instance stability, and queryClientStatus event emission
  • Full @clerk/clerk-js test suite passes (722 tests)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented May 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d328a48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 8:46pm

Request Review

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4932e68-7a54-429d-acd2-64cb7d83ec3a

📥 Commits

Reviewing files that changed from the base of the PR and between 74dca0b and d328a48.

📒 Files selected for processing (3)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json
  • packages/clerk-js/src/core/__tests__/clerk.internal-query-client.test.ts
✅ Files skipped from review due to trivial changes (2)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json

📝 Walkthrough

Walkthrough

This PR restores a backward-compatible internal React Query client on Clerk via a new lazy-loading getter __internal_queryClient. It adds a re-export module for QueryClient, a private field and getter on Clerk that dynamically imports and instantiates QueryClient, emits queryClientStatus when ready, and caches the instance. Build changes add @tanstack/query-core, configure Rspack to split it into a query-core-vendors chunk, and update bundlewatch thresholds. Tests exercise lazy initialization, singleton behavior, and event emission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: restoring an internal queryClient getter as a backward compatibility shim after it was removed in a previous version.
Description check✅ PassedThe description provides relevant context about the change, explaining why the getter was removed, why it needs to be restored, and how the implementation addresses backward compatibility concerns.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8562

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8562

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8562

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8562

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8562

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8562

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8562

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8562

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8562

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8562

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8562

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8562

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8562

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8562

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8562

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8562

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8562

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8562

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8562

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8562

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8562

commit: d328a48

…ent shim
- Use void to discard getter expressions in tests (no-unused-expressions)
- Add patch changeset for @clerk/clerk-js
- Bump clerk.js (543->549KB) and clerk.no-rhc.js (311->316KB) for the
query-core dynamic-import infrastructure re-added by the shim
@wobsoriano
wobsoriano merged commit 692b68d into mainMay 15, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/revert-internal-query-client branch May 15, 2026 23:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(clerk-js): Restore internal queryClient for backward compat with older SDKs by wobsoriano · Pull Request #8562 · clerk/javascript · GitHub
Skip to content

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs - #8562

Merged
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client
May 15, 2026
Merged

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs#8562
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

clerk-js@6.11.0 removed clerk.__internal_queryClient as part of #8434, which moved QueryClient ownership into @clerk/shared. However, apps still on @clerk/shared < 4.10.0 rely on that getter to initialize TanStack Query. With clerk-js auto-updating from the CDN, those apps started seeing useOrganizationList and useOrganization return empty data with no network request.

This PR restores the getter as a backward compat shim:

Behavior

  • Updated SDKs (@clerk/shared >= 4.10.0): no change, getter is never accessed, chunk is never fetched
  • Older SDKs (@clerk/shared < 4.10.0): getter works again, queries fire, data loads

Test plan

  • 4 new tests covering initial undefined state, post-resolve shape, instance stability, and queryClientStatus event emission
  • Full @clerk/clerk-js test suite passes (722 tests)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented May 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d328a48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 8:46pm

Request Review

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4932e68-7a54-429d-acd2-64cb7d83ec3a

📥 Commits

Reviewing files that changed from the base of the PR and between 74dca0b and d328a48.

📒 Files selected for processing (3)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json
  • packages/clerk-js/src/core/__tests__/clerk.internal-query-client.test.ts
✅ Files skipped from review due to trivial changes (2)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json

📝 Walkthrough

Walkthrough

This PR restores a backward-compatible internal React Query client on Clerk via a new lazy-loading getter __internal_queryClient. It adds a re-export module for QueryClient, a private field and getter on Clerk that dynamically imports and instantiates QueryClient, emits queryClientStatus when ready, and caches the instance. Build changes add @tanstack/query-core, configure Rspack to split it into a query-core-vendors chunk, and update bundlewatch thresholds. Tests exercise lazy initialization, singleton behavior, and event emission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: restoring an internal queryClient getter as a backward compatibility shim after it was removed in a previous version.
Description check✅ PassedThe description provides relevant context about the change, explaining why the getter was removed, why it needs to be restored, and how the implementation addresses backward compatibility concerns.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8562

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8562

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8562

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8562

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8562

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8562

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8562

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8562

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8562

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8562

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8562

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8562

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8562

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8562

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8562

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8562

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8562

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8562

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8562

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8562

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8562

commit: d328a48

…ent shim
- Use void to discard getter expressions in tests (no-unused-expressions)
- Add patch changeset for @clerk/clerk-js
- Bump clerk.js (543->549KB) and clerk.no-rhc.js (311->316KB) for the
query-core dynamic-import infrastructure re-added by the shim
@wobsoriano
wobsoriano merged commit 692b68d into mainMay 15, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/revert-internal-query-client branch May 15, 2026 23:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(clerk-js): Restore internal queryClient for backward compat with older SDKs by wobsoriano · Pull Request #8562 · clerk/javascript · GitHub
Skip to content

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs - #8562

Merged
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client
May 15, 2026
Merged

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs#8562
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

clerk-js@6.11.0 removed clerk.__internal_queryClient as part of #8434, which moved QueryClient ownership into @clerk/shared. However, apps still on @clerk/shared < 4.10.0 rely on that getter to initialize TanStack Query. With clerk-js auto-updating from the CDN, those apps started seeing useOrganizationList and useOrganization return empty data with no network request.

This PR restores the getter as a backward compat shim:

Behavior

  • Updated SDKs (@clerk/shared >= 4.10.0): no change, getter is never accessed, chunk is never fetched
  • Older SDKs (@clerk/shared < 4.10.0): getter works again, queries fire, data loads

Test plan

  • 4 new tests covering initial undefined state, post-resolve shape, instance stability, and queryClientStatus event emission
  • Full @clerk/clerk-js test suite passes (722 tests)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented May 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d328a48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 8:46pm

Request Review

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4932e68-7a54-429d-acd2-64cb7d83ec3a

📥 Commits

Reviewing files that changed from the base of the PR and between 74dca0b and d328a48.

📒 Files selected for processing (3)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json
  • packages/clerk-js/src/core/__tests__/clerk.internal-query-client.test.ts
✅ Files skipped from review due to trivial changes (2)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json

📝 Walkthrough

Walkthrough

This PR restores a backward-compatible internal React Query client on Clerk via a new lazy-loading getter __internal_queryClient. It adds a re-export module for QueryClient, a private field and getter on Clerk that dynamically imports and instantiates QueryClient, emits queryClientStatus when ready, and caches the instance. Build changes add @tanstack/query-core, configure Rspack to split it into a query-core-vendors chunk, and update bundlewatch thresholds. Tests exercise lazy initialization, singleton behavior, and event emission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: restoring an internal queryClient getter as a backward compatibility shim after it was removed in a previous version.
Description check✅ PassedThe description provides relevant context about the change, explaining why the getter was removed, why it needs to be restored, and how the implementation addresses backward compatibility concerns.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8562

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8562

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8562

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8562

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8562

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8562

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8562

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8562

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8562

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8562

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8562

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8562

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8562

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8562

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8562

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8562

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8562

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8562

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8562

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8562

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8562

commit: d328a48

…ent shim
- Use void to discard getter expressions in tests (no-unused-expressions)
- Add patch changeset for @clerk/clerk-js
- Bump clerk.js (543->549KB) and clerk.no-rhc.js (311->316KB) for the
query-core dynamic-import infrastructure re-added by the shim
@wobsoriano
wobsoriano merged commit 692b68d into mainMay 15, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/revert-internal-query-client branch May 15, 2026 23:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(clerk-js): Restore internal queryClient for backward compat with older SDKs by wobsoriano · Pull Request #8562 · clerk/javascript · GitHub
Skip to content

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs - #8562

Merged
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client
May 15, 2026
Merged

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs#8562
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

clerk-js@6.11.0 removed clerk.__internal_queryClient as part of #8434, which moved QueryClient ownership into @clerk/shared. However, apps still on @clerk/shared < 4.10.0 rely on that getter to initialize TanStack Query. With clerk-js auto-updating from the CDN, those apps started seeing useOrganizationList and useOrganization return empty data with no network request.

This PR restores the getter as a backward compat shim:

Behavior

  • Updated SDKs (@clerk/shared >= 4.10.0): no change, getter is never accessed, chunk is never fetched
  • Older SDKs (@clerk/shared < 4.10.0): getter works again, queries fire, data loads

Test plan

  • 4 new tests covering initial undefined state, post-resolve shape, instance stability, and queryClientStatus event emission
  • Full @clerk/clerk-js test suite passes (722 tests)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented May 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d328a48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 8:46pm

Request Review

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4932e68-7a54-429d-acd2-64cb7d83ec3a

📥 Commits

Reviewing files that changed from the base of the PR and between 74dca0b and d328a48.

📒 Files selected for processing (3)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json
  • packages/clerk-js/src/core/__tests__/clerk.internal-query-client.test.ts
✅ Files skipped from review due to trivial changes (2)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json

📝 Walkthrough

Walkthrough

This PR restores a backward-compatible internal React Query client on Clerk via a new lazy-loading getter __internal_queryClient. It adds a re-export module for QueryClient, a private field and getter on Clerk that dynamically imports and instantiates QueryClient, emits queryClientStatus when ready, and caches the instance. Build changes add @tanstack/query-core, configure Rspack to split it into a query-core-vendors chunk, and update bundlewatch thresholds. Tests exercise lazy initialization, singleton behavior, and event emission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: restoring an internal queryClient getter as a backward compatibility shim after it was removed in a previous version.
Description check✅ PassedThe description provides relevant context about the change, explaining why the getter was removed, why it needs to be restored, and how the implementation addresses backward compatibility concerns.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8562

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8562

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8562

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8562

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8562

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8562

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8562

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8562

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8562

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8562

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8562

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8562

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8562

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8562

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8562

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8562

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8562

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8562

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8562

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8562

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8562

commit: d328a48

…ent shim
- Use void to discard getter expressions in tests (no-unused-expressions)
- Add patch changeset for @clerk/clerk-js
- Bump clerk.js (543->549KB) and clerk.no-rhc.js (311->316KB) for the
query-core dynamic-import infrastructure re-added by the shim
@wobsoriano
wobsoriano merged commit 692b68d into mainMay 15, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/revert-internal-query-client branch May 15, 2026 23:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(clerk-js): Restore internal queryClient for backward compat with older SDKs by wobsoriano · Pull Request #8562 · clerk/javascript · GitHub
Skip to content

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs - #8562

Merged
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client
May 15, 2026
Merged

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs#8562
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

clerk-js@6.11.0 removed clerk.__internal_queryClient as part of #8434, which moved QueryClient ownership into @clerk/shared. However, apps still on @clerk/shared < 4.10.0 rely on that getter to initialize TanStack Query. With clerk-js auto-updating from the CDN, those apps started seeing useOrganizationList and useOrganization return empty data with no network request.

This PR restores the getter as a backward compat shim:

Behavior

  • Updated SDKs (@clerk/shared >= 4.10.0): no change, getter is never accessed, chunk is never fetched
  • Older SDKs (@clerk/shared < 4.10.0): getter works again, queries fire, data loads

Test plan

  • 4 new tests covering initial undefined state, post-resolve shape, instance stability, and queryClientStatus event emission
  • Full @clerk/clerk-js test suite passes (722 tests)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented May 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d328a48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 8:46pm

Request Review

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4932e68-7a54-429d-acd2-64cb7d83ec3a

📥 Commits

Reviewing files that changed from the base of the PR and between 74dca0b and d328a48.

📒 Files selected for processing (3)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json
  • packages/clerk-js/src/core/__tests__/clerk.internal-query-client.test.ts
✅ Files skipped from review due to trivial changes (2)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json

📝 Walkthrough

Walkthrough

This PR restores a backward-compatible internal React Query client on Clerk via a new lazy-loading getter __internal_queryClient. It adds a re-export module for QueryClient, a private field and getter on Clerk that dynamically imports and instantiates QueryClient, emits queryClientStatus when ready, and caches the instance. Build changes add @tanstack/query-core, configure Rspack to split it into a query-core-vendors chunk, and update bundlewatch thresholds. Tests exercise lazy initialization, singleton behavior, and event emission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: restoring an internal queryClient getter as a backward compatibility shim after it was removed in a previous version.
Description check✅ PassedThe description provides relevant context about the change, explaining why the getter was removed, why it needs to be restored, and how the implementation addresses backward compatibility concerns.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8562

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8562

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8562

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8562

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8562

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8562

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8562

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8562

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8562

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8562

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8562

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8562

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8562

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8562

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8562

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8562

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8562

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8562

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8562

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8562

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8562

commit: d328a48

…ent shim
- Use void to discard getter expressions in tests (no-unused-expressions)
- Add patch changeset for @clerk/clerk-js
- Bump clerk.js (543->549KB) and clerk.no-rhc.js (311->316KB) for the
query-core dynamic-import infrastructure re-added by the shim
@wobsoriano
wobsoriano merged commit 692b68d into mainMay 15, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/revert-internal-query-client branch May 15, 2026 23:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(clerk-js): Restore internal queryClient for backward compat with older SDKs by wobsoriano · Pull Request #8562 · clerk/javascript · GitHub
Skip to content

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs - #8562

Merged
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client
May 15, 2026
Merged

fix(clerk-js): Restore internal queryClient for backward compat with older SDKs#8562
wobsoriano merged 2 commits into
mainfrom
rob/revert-internal-query-client

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

clerk-js@6.11.0 removed clerk.__internal_queryClient as part of #8434, which moved QueryClient ownership into @clerk/shared. However, apps still on @clerk/shared < 4.10.0 rely on that getter to initialize TanStack Query. With clerk-js auto-updating from the CDN, those apps started seeing useOrganizationList and useOrganization return empty data with no network request.

This PR restores the getter as a backward compat shim:

Behavior

  • Updated SDKs (@clerk/shared >= 4.10.0): no change, getter is never accessed, chunk is never fetched
  • Older SDKs (@clerk/shared < 4.10.0): getter works again, queries fire, data loads

Test plan

  • 4 new tests covering initial undefined state, post-resolve shape, instance stability, and queryClientStatus event emission
  • Full @clerk/clerk-js test suite passes (722 tests)

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@changeset-bot

changeset-botBot commented May 15, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d328a48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
NameType
@clerk/clerk-jsPatch
@clerk/chrome-extensionPatch
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 15, 2026 8:46pm

Request Review

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b4932e68-7a54-429d-acd2-64cb7d83ec3a

📥 Commits

Reviewing files that changed from the base of the PR and between 74dca0b and d328a48.

📒 Files selected for processing (3)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json
  • packages/clerk-js/src/core/__tests__/clerk.internal-query-client.test.ts
✅ Files skipped from review due to trivial changes (2)
  • .changeset/restore-internal-query-client.md
  • packages/clerk-js/bundlewatch.config.json

📝 Walkthrough

Walkthrough

This PR restores a backward-compatible internal React Query client on Clerk via a new lazy-loading getter __internal_queryClient. It adds a re-export module for QueryClient, a private field and getter on Clerk that dynamically imports and instantiates QueryClient, emits queryClientStatus when ready, and caches the instance. Build changes add @tanstack/query-core, configure Rspack to split it into a query-core-vendors chunk, and update bundlewatch thresholds. Tests exercise lazy initialization, singleton behavior, and event emission.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: restoring an internal queryClient getter as a backward compatibility shim after it was removed in a previous version.
Description check✅ PassedThe description provides relevant context about the change, explaining why the getter was removed, why it needs to be restored, and how the implementation addresses backward compatibility concerns.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 15, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8562

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8562

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8562

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8562

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8562

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8562

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8562

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8562

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8562

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8562

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8562

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8562

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8562

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8562

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8562

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8562

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8562

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8562

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8562

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8562

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8562

commit: d328a48

…ent shim
- Use void to discard getter expressions in tests (no-unused-expressions)
- Add patch changeset for @clerk/clerk-js
- Bump clerk.js (543->549KB) and clerk.no-rhc.js (311->316KB) for the
query-core dynamic-import infrastructure re-added by the shim
@wobsoriano
wobsoriano merged commit 692b68d into mainMay 15, 2026
43 checks passed
@wobsoriano
wobsoriano deleted the rob/revert-internal-query-client branch May 15, 2026 23:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko