') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); chore(clerk-js): clear tracked setInterval timers between tests by jacekradko · Pull Request #8583 · clerk/javascript · GitHub
Skip to content

chore(clerk-js): clear tracked setInterval timers between tests - #8583

Merged
jacekradko merged 1 commit into
mainfrom
jacek/fix-ui-test-timer-leak
May 20, 2026
Merged

chore(clerk-js): clear tracked setInterval timers between tests#8583
jacekradko merged 1 commit into
mainfrom
jacek/fix-ui-test-timer-leak

Conversation

@jacekradko

@jacekradkojacekradko commented May 18, 2026

Copy link
Copy Markdown
Contributor

The shared vitest setup wraps setTimeout so leaked timers can be cleared in afterEach, but setInterval was untracked. @formkit/auto-animate registers a setInterval in poll() (index.mjs:161) that polls every two seconds and calls requestAnimationFrame inside lowPriority. After the test file finished and jsdom was torn down, that interval kept firing and tripped on the missing requestAnimationFrame global, which is what was failing the Unit Tests check on #8548 even though all 1833 tests passed.

This wraps setInterval/clearInterval the same way as setTimeout and clears tracked intervals in afterEach.

Verified locally: pnpm --filter @clerk/ui run test and pnpm --filter @clerk/clerk-js run test both pass with no unhandled errors.

@jacekradko
chore(clerk-js): clear tracked setInterval timers between tests
999e171
Auto-animate registers a setInterval in poll() that survived the existing
setTimeout-only cleanup. Once jsdom tore down, the interval fired and
referenced the now-missing requestAnimationFrame, producing 'Vitest caught
1 unhandled error' even though every test passed. Wrapping setInterval
the same way as setTimeout clears the leak.
@vercel

vercelBot commented May 18, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentMay 18, 2026 5:16pm

Request Review

@coderabbitai

coderabbitaiBot commented May 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 6fefc48a-bf83-4539-8a17-56c85748877a

📥 Commits

Reviewing files that changed from the base of the PR and between 4ff81b6 and 999e171.

📒 Files selected for processing (2)
  • .changeset/clear-tracked-test-intervals.md
  • packages/clerk-js/vitest.setup.mts
📝 Walkthrough

Walkthrough

This PR adds interval tracking to the vitest test setup file, mirroring existing setTimeout tracking behavior. A new activeIntervals set captures interval IDs created during tests, while wrapping global.setInterval and global.clearInterval to register and unregister those IDs. Test lifecycle hooks clear the set in beforeEach and explicitly cancel remaining intervals in afterEach. A corresponding changeset entry documents the infrastructure change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: wrapping setInterval timers in the clerk-js vitest setup to clear them between tests, which is precisely what the changeset implements.
Description check✅ PassedThe description provides clear context about the issue (untracked setInterval causing test failures), the root cause (@formkit/auto-animate registering intervals), and explains the solution with verification steps.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented May 18, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8583

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8583

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8583

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8583

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8583

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8583

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8583

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8583

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8583

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8583

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8583

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8583

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8583

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8583

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8583

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8583

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8583

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8583

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8583

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8583

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8583

commit: 999e171

@jacekradko
jacekradko merged commit 377152c into mainMay 20, 2026
43 checks passed
@jacekradko
jacekradko deleted the jacek/fix-ui-test-timer-leak branch May 20, 2026 01:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcarpenteralexcarpenteralexcarpenter approved these changes
@wobsorianowobsorianowobsoriano approved these changes

Assignees

No one assigned

Labels

clerk-js

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jacekradko@alexcarpenter@wobsoriano