Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/plain-apes-sneeze.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/react-router": patch
---

Forward redirect URL options from middleware to client state.
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,7 +79,10 @@ describe('clerkMiddleware', () => {
});

expect(mockContext.set).toHaveBeenCalledWith(authFnContext, expect.any(Function));
expect(mockContext.set).toHaveBeenCalledWith(requestStateContext, mockRequestState);
expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({ requestState: mockRequestState }),
);

expect(mockNext).toHaveBeenCalled();

Expand DownExpand Up@@ -119,6 +122,54 @@ describe('clerkMiddleware', () => {
expect(mockLoadOptions).toHaveBeenCalledWith(args, options);
});

it('should set redirect URL options from loadOptions in additionalStateContext', async () => {
mockLoadOptions.mockReturnValue({
audience: '',
authorizedParties: [],
signInUrl: '',
signUpUrl: '',
secretKey: 'sk_test_...',
publishableKey: 'pk_test_...',
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
} as unknown as ReturnType<typeof loadOptions>);

const mockRequestState = {
status: AuthStatus.SignedIn,
headers: new Headers(),
toAuth: vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken }),
};

mockClerkClient.mockReturnValue({
authenticateRequest: vi.fn().mockResolvedValue(mockRequestState),
} as unknown as ClerkClient);

const middleware = clerkMiddleware();
const args = {
request: new Request('http://clerk.com'),
context: mockContext,
} as LoaderFunctionArgs;

mockNext.mockResolvedValue(new Response('OK'));

await middleware(args, mockNext);

expect(mockContext.set).toHaveBeenCalledWith(
requestStateContext,
expect.objectContaining({
requestState: mockRequestState,
additionalState: expect.objectContaining({
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
}),
}),
);
});

it('should append request state headers to response', async () => {
const mockRequestState = {
status: AuthStatus.SignedIn,
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,16 +12,21 @@ describe('rootAuthLoader', () => {
});

describe('with middleware context', () => {
const mockRequestState = {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
};

const mockContext = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
toAuth: vi.fn().mockImplementation(() => ({
userId: 'user_xxx',
tokenType: TokenType.SessionToken,
})),
headers: new Headers(),
status: 'signed-in',
requestState: mockRequestState,
additionalState: {},
};
}
if (contextKey === authFnContext) {
Expand DownExpand Up@@ -101,5 +106,39 @@ describe('rootAuthLoader', () => {

expect(result).toHaveProperty('clerkState');
});

it('should forward redirect URL options from additionalState into clerkState', async () => {
const mockContext2 = {
get: vi.fn().mockImplementation(contextKey => {
if (contextKey === requestStateContext) {
return {
requestState: mockRequestState,
additionalState: {
signInForceRedirectUrl: '/dashboard',
signUpForceRedirectUrl: '/welcome',
signInFallbackRedirectUrl: '/home',
signUpFallbackRedirectUrl: '/home',
},
};
}
if (contextKey === authFnContext) {
return vi.fn().mockReturnValue({ userId: 'user_xxx', tokenType: TokenType.SessionToken });
}
return null;
}),
set: vi.fn(),
};

const result = (await rootAuthLoader({
context: mockContext2,
request: new Request('http://clerk.com'),
} as LoaderFunctionArgs)) as any;

const internalState = result.clerkState.__internal_clerk_state;
expect(internalState.__signInForceRedirectUrl).toBe('/dashboard');
expect(internalState.__signUpForceRedirectUrl).toBe('/welcome');
expect(internalState.__signInFallbackRedirectUrl).toBe('/home');
expect(internalState.__signUpFallbackRedirectUrl).toBe('/home');
});
});
});
26 changes: 18 additions & 8 deletions packages/react-router/src/server/clerkMiddleware.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,11 +9,16 @@ import { createContext } from 'react-router';
import { clerkClient } from './clerkClient';
import { resolveKeysWithKeylessFallback } from './keyless/utils';
import { loadOptions } from './loadOptions';
import type { ClerkMiddlewareOptions } from './types';
import type { AdditionalStateOptions, ClerkMiddlewareOptions } from './types';
import { patchRequest } from './utils';

type RequestStateContextValue = {
requestState: RequestState<any>;
additionalState: AdditionalStateOptions;
};

export const authFnContext = createContext<((options?: PendingSessionOptions) => AuthObject) | null>(null);
export const requestStateContext = createContext<RequestState<any> | null>(null);
export const requestStateContext = createContext<RequestStateContextValue | null>(null);

/**
* Middleware that integrates Clerk authentication into your React Router application.
Expand DownExpand Up@@ -83,11 +88,6 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
acceptsToken: 'any',
});

Object.assign(requestState, {
__keylessClaimUrl,
__keylessApiKeysUrl,
});

const locationHeader = requestState.headers.get(constants.Headers.Location);
if (locationHeader) {
handleNetlifyCacheInDevInstance({
Expand All@@ -104,7 +104,17 @@ export const clerkMiddleware = (options?: ClerkMiddlewareOptions): MiddlewareFun
}

args.context.set(authFnContext, (opts?: PendingSessionOptions) => requestState.toAuth(opts));
args.context.set(requestStateContext, requestState);
args.context.set(requestStateContext, {
requestState,
additionalState: {
__keylessClaimUrl,
__keylessApiKeysUrl,
signInForceRedirectUrl: loadedOptions.signInForceRedirectUrl,
signUpForceRedirectUrl: loadedOptions.signUpForceRedirectUrl,
signInFallbackRedirectUrl: loadedOptions.signInFallbackRedirectUrl,
signUpFallbackRedirectUrl: loadedOptions.signUpFallbackRedirectUrl,
},
});

const response = await next();

Expand Down
22 changes: 16 additions & 6 deletions packages/react-router/src/server/rootAuthLoader.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@ import type { LoaderFunctionArgs } from 'react-router';
import { invalidRootLoaderCallbackReturn } from '../utils/errors';
import { authFnContext, requestStateContext } from './clerkMiddleware';
import type {
AdditionalStateOptions,
LoaderFunctionArgsWithAuth,
LoaderFunctionReturn,
RootAuthLoaderCallback,
Expand DownExpand Up@@ -40,14 +41,15 @@ interface RootAuthLoader {
async function processRootAuthLoader(
args: LoaderFunctionArgs,
requestState: RequestState,
additionalState: AdditionalStateOptions,
handler?: RootAuthLoaderCallback<any>,
): Promise<LoaderFunctionReturn> {
const hasMiddleware = IsOptIntoMiddleware(args.context) && !!args.context.get(authFnContext);
const includeClerkHeaders = !hasMiddleware;

if (!handler) {
// if the user did not provide a handler, simply inject requestState into an empty response
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);
return {
...clerkState,
};
Expand All@@ -69,7 +71,13 @@ async function processRootAuthLoader(
}
// clone and try to inject requestState into all json-like responses
// if this fails, the user probably didn't return a json object or a valid json string
return injectRequestStateIntoResponse(handlerResult, requestState, args.context, includeClerkHeaders);
return injectRequestStateIntoResponse(
handlerResult,
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
throw new Error(invalidRootLoaderCallbackReturn);
}
Expand All@@ -83,6 +91,7 @@ async function processRootAuthLoader(
new Response(JSON.stringify(handlerResult.data), handlerResult.init ?? undefined),
requestState,
args.context,
additionalState,
includeClerkHeaders,
);
} catch {
Expand All@@ -91,7 +100,7 @@ async function processRootAuthLoader(
}

// If the return value of the user's handler is null or a plain object, return plain object with streaming support
const { clerkState } = getResponseClerkState(requestState, args.context);
const { clerkState } = getResponseClerkState(requestState, args.context, additionalState);

return {
...(handlerResult ?? {}),
Expand All@@ -111,13 +120,14 @@ export const rootAuthLoader: RootAuthLoader = async (
const handler = typeof handlerOrOptions === 'function' ? handlerOrOptions : undefined;

const hasMiddlewareFlag = IsOptIntoMiddleware(args.context);
const requestState = hasMiddlewareFlag && args.context.get(requestStateContext);
const contextValue = hasMiddlewareFlag && args.context.get(requestStateContext);

if (!requestState) {
if (!contextValue) {
throw new Error(
'Clerk: clerkMiddleware() not detected. Make sure you have installed the clerkMiddleware in your root route.',
);
}

return processRootAuthLoader(args, requestState, handler);
const { requestState, additionalState } = contextValue;
return processRootAuthLoader(args, requestState, additionalState, handler);
};
9 changes: 9 additions & 0 deletions packages/react-router/src/server/types.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -68,6 +68,15 @@ export interface KeylessUrls {
__keylessApiKeysUrl?: string;
}

export type AdditionalStateOptions = SignInFallbackRedirectUrl &
SignUpFallbackRedirectUrl &
SignInForceRedirectUrl &
SignUpForceRedirectUrl &
KeylessUrls;

/**
* @deprecated This type is no longer used internally. Use `AdditionalStateOptions` instead.
*/
export type RequestStateWithRedirectUrls = RequestState &
SignInForceRedirectUrl &
SignInFallbackRedirectUrl &
Expand Down
25 changes: 16 additions & 9 deletions packages/react-router/src/server/utils.ts
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
import type { RequestState } from '@clerk/backend/internal';
import { constants, debugRequestState } from '@clerk/backend/internal';
import { parse as parseCookie } from 'cookie';
import type { AppLoadContext, UNSAFE_DataWithResponseInit } from 'react-router';

import { getPublicEnvVariables } from '../utils/env';
import { canUseKeyless } from '../utils/feature-flags';
import type { RequestStateWithRedirectUrls } from './types';
import type { AdditionalStateOptions } from './types';

export function isResponse(value: any): value is Response {
return (
Expand DownExpand Up@@ -51,14 +52,15 @@ export const IsOptIntoMiddleware = (context: AppLoadContext) => {

export const injectRequestStateIntoResponse = async (
response: Response,
requestState: RequestStateWithRedirectUrls,
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
includeClerkHeaders = false,
) => {
const clone = new Response(response.body, response);
const data = await clone.json();

const { clerkState, headers } = getResponseClerkState(requestState, context);
const { clerkState, headers } = getResponseClerkState(requestState, context, additionalStateOptions);

// set the correct content-type header in case the user returned a `Response` directly
clone.headers.set(constants.Headers.ContentType, constants.ContentTypes.Json);
Expand All@@ -78,9 +80,14 @@ export const injectRequestStateIntoResponse = async (
*
* @internal
*/
export function getResponseClerkState(requestState: RequestStateWithRedirectUrls, context: AppLoadContext) {
const { reason, message, isSignedIn, __keylessClaimUrl, __keylessApiKeysUrl, ...rest } = requestState;
export function getResponseClerkState(
requestState: RequestState,
context: AppLoadContext,
additionalStateOptions: AdditionalStateOptions = {},
) {
const { reason, message, isSignedIn, ...rest } = requestState;
const envVars = getPublicEnvVariables(context);
const { __keylessClaimUrl, __keylessApiKeysUrl, ...redirectUrlOptions } = additionalStateOptions;

const baseState: Record<string, unknown> = {
__clerk_ssr_state: rest.toAuth(),
Expand All@@ -90,10 +97,10 @@ export function getResponseClerkState(requestState: RequestStateWithRedirectUrls
__isSatellite: requestState.isSatellite,
__signInUrl: requestState.signInUrl,
__signUpUrl: requestState.signUpUrl,
__signInForceRedirectUrl: requestState.signInForceRedirectUrl,
__signUpForceRedirectUrl: requestState.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: requestState.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: requestState.signUpFallbackRedirectUrl,
__signInForceRedirectUrl: redirectUrlOptions.signInForceRedirectUrl,
__signUpForceRedirectUrl: redirectUrlOptions.signUpForceRedirectUrl,
__signInFallbackRedirectUrl: redirectUrlOptions.signInFallbackRedirectUrl,
__signUpFallbackRedirectUrl: redirectUrlOptions.signUpFallbackRedirectUrl,
__clerk_debug: debugRequestState(requestState),
__clerkJSUrl: envVars.clerkJsUrl,
__clerkJSVersion: envVars.clerkJsVersion,
Expand Down
Loading