Uh oh!
There was an error while loading. Please reload this page.
fix(expo): pin clerk-ios and dedupe Expo SPM refs - #8689
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 0a0c040 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/dev-cli@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
chriscanin
commented
May 28, 2026
This PR looks good to me, I am not seeing any issues with the code. I am publishing this locally and running for a quick test & confirmation. |
chriscanin
left a comment
There was a problem hiding this comment.
This is compiling, building, and working well. Code is looking good.
📝 WalkthroughWalkthroughThis PR updates the Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/expo/app.plugin.js (1)
31-33: ⚡ Quick winHarden URL canonicalization before dedupe comparison.
Line 31 only strips wrapping quotes; URLs with trailing
/or without.gitwill not match and can bypass deduplication. Normalize those variants before equality checks.Suggested patch
const CLERK_IOS_REPO = 'https://github.com/clerk/clerk-ios.git'; +const NORMALIZED_CLERK_IOS_REPO = normalizeRepositoryURL(CLERK_IOS_REPO);-const normalizeRepositoryURL = repositoryURL => String(repositoryURL || '').replace(/^"|"$/g, '');+const normalizeRepositoryURL = repositoryURL =>+ String(repositoryURL || '')+ .replace(/^"|"$/g, '')+ .replace(/\/+$/g, '')+ .replace(/\.git$/i, '')+ .toLowerCase();-const isClerkIOSPackageReference = ref => normalizeRepositoryURL(ref?.repositoryURL) === CLERK_IOS_REPO;+const isClerkIOSPackageReference = ref =>+ normalizeRepositoryURL(ref?.repositoryURL) === NORMALIZED_CLERK_IOS_REPO;🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/expo/app.plugin.js` around lines 31 - 33, normalizeRepositoryURL currently only strips wrapping quotes, so isClerkIOSPackageReference can miss matches when URLs have trailing slashes or a .git suffix; update normalizeRepositoryURL to also trim whitespace, remove any trailing slash, strip a trailing ".git" (case-insensitive), and normalize case (toLowerCase) before returning, and keep isClerkIOSPackageReference using normalizeRepositoryURL(ref?.repositoryURL) to compare against CLERK_IOS_REPO so all canonical URL variants match.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/expo/app.plugin.js`:
- Around line 31-33: normalizeRepositoryURL currently only strips wrapping
quotes, so isClerkIOSPackageReference can miss matches when URLs have trailing
slashes or a .git suffix; update normalizeRepositoryURL to also trim whitespace,
remove any trailing slash, strip a trailing ".git" (case-insensitive), and
normalize case (toLowerCase) before returning, and keep
isClerkIOSPackageReference using normalizeRepositoryURL(ref?.repositoryURL) to
compare against CLERK_IOS_REPO so all canonical URL variants match.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7dfd5c26-fe76-481c-9b26-4a6aded5b23c
📒 Files selected for processing (3)
.changeset/fresh-clocks-pay.mdpackages/expo/app.plugin.jspackages/expo/src/__tests__/appPlugin.ios.test.js
Uh oh!
There was an error while loading. Please reload this page.
Summary
Testing