Uh oh!
There was an error while loading. Please reload this page.
chore(expo): bump native SDK versions - #8745
Conversation
🦋 Changeset detectedLatest commit: 63ae11e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
📝 WalkthroughWalkthroughThis PR bumps native SDK versions for the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/expo/app.plugin.js (1)
23-23: ⚡ Quick winAdd/adjust integration coverage for the native SDK version bump paths.
No test updates are included with this SDK bump. Please add or update coverage that validates iOS SPM pinning and Android dependency pin propagation in plugin outputs to catch future regression on version constants.
As per coding guidelines,
**/*: "If there are no tests added or modified as part of the PR, please suggest that tests be added to cover the changes."🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/expo/app.plugin.js` at line 23, The PR bumped the native SDK version constant CLERK_IOS_VERSION but added no tests; add/update tests that assert the Expo plugin output reflects iOS SPM pinning and Android dependency propagation for the new version: create/modify unit tests that run the plugin (the function exporting the plugin configuration) and verify the iOS SPM entry contains the CLERK_IOS_VERSION value and that Android gradle/maven dependency entries include the propagated version constant; ensure these tests fail on regressions by asserting exact version strings derived from CLERK_IOS_VERSION and add them to the test suite.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/expo/app.plugin.js`:
- Line 23: The PR bumped the native SDK version constant CLERK_IOS_VERSION but
added no tests; add/update tests that assert the Expo plugin output reflects iOS
SPM pinning and Android dependency propagation for the new version:
create/modify unit tests that run the plugin (the function exporting the plugin
configuration) and verify the iOS SPM entry contains the CLERK_IOS_VERSION value
and that Android gradle/maven dependency entries include the propagated version
constant; ensure these tests fail on regressions by asserting exact version
strings derived from CLERK_IOS_VERSION and add them to the test suite.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 7d804304-e772-4ebd-88cd-33a17ef866a9
📒 Files selected for processing (3)
.changeset/bump-expo-native-sdks.mdpackages/expo/android/build.gradlepackages/expo/app.plugin.js
Summary
clerk-ios@1.1.4toclerk-ios@1.1.5.@clerk/expofrom1.0.23to1.0.26for bothclerk-android-apiandclerk-android-ui.Verification
pnpm --filter @clerk/expo test -- --runInBandclerk-iosat1.1.5and SPM resolvedPackage.resolvedto1.1.5.com.clerk:clerk-android-ui:1.0.26.com.clerk:clerk-android-api:1.0.26.