Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(ui): Add mosaic design systems foundations by alexcarpenter · Pull Request #8755 · clerk/javascript · GitHub
Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ui): Add mosaic design systems foundations by alexcarpenter · Pull Request #8755 · clerk/javascript · GitHub
Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ui): Add mosaic design systems foundations by alexcarpenter · Pull Request #8755 · clerk/javascript · GitHub
Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(ui): Add mosaic design systems foundations by alexcarpenter · Pull Request #8755 · clerk/javascript · GitHub
Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ui): Add mosaic design systems foundations by alexcarpenter · Pull Request #8755 · clerk/javascript · GitHub
Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(ui): Add mosaic design systems foundations by alexcarpenter · Pull Request #8755 · clerk/javascript · GitHub
Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(ui): Add mosaic design systems foundations by alexcarpenter · Pull Request #8755 · clerk/javascript · GitHub
Skip to content

feat(ui): Add mosaic design systems foundations - #8755

Merged
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra
Jun 9, 2026
Merged

feat(ui): Add mosaic design systems foundations#8755
alexcarpenter merged 27 commits into
mainfrom
carp/mosaic-infra

Conversation

@alexcarpenter

@alexcarpenteralexcarpenter commented Jun 5, 2026

Copy link
Copy Markdown
Member

Description

  • Mosaic design system foundations: token-driven cva(), MosaicProvider with theme context, sx prop for one-off overrides
  • Token primitives: color (oklch, light-dark), spacing (multiplier fn), radius scale, fontSize scale with paired line-heights (Tailwind v4 convention)
  • Theme helpers: spacing(n), alpha(color, %), mix(a, b, %), text(size) — all return literal CSS values, spreadable into style objects
  • Button reference component demonstrating variant composition via cva()

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • New Features

    • Introduced the Mosaic design system: default tokens, theme resolver, provider + hook, theme helpers (spacing, alpha, mix, text) and a theme-aware variant utility (cva).
    • Added a Mosaic Button component with customizable variants for layout, typography, color, size, and states.
  • Documentation

    • Added a comprehensive Mosaic architecture guide with token details, patterns, and migration guidance.
  • Tests

    • Added an extensive test suite validating the variant utility and TypeScript typings.
  • Chores

    • Added a changeset declaring the new Mosaic foundations.

@changeset-bot

changeset-botBot commented Jun 5, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eb0dc28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 9, 2026 1:53pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed.

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Adds Mosaic design-system foundations: frozen token defaults and resolver, MosaicProvider with Emotion cache and optional CSS layer wrapping, a theme-aware cva utility with tests, a reference Button component, architecture documentation, and a release changeset.

Changes

Mosaic Design System Implementation

Layer / File(s)Summary
Token types and theme resolution
packages/ui/src/mosaic/variables.ts
Defines frozen default token values and TypeScript types (MosaicTokens, MosaicVariables, MosaicTheme) and implements resolveVariables() to deep-merge overrides and provide helper functions (spacing, alpha, mix, text).
Theme provider and context delivery
packages/ui/src/mosaic/MosaicProvider.tsx
MosaicProvider resolves theme variables, creates an Emotion cache with optional insertion point and nonce, and conditionally wraps generated CSS in an @layer when cssLayerName is provided. Exports useMosaicTheme() to access the resolved theme from context.
CVA variant system implementation
packages/ui/src/mosaic/cva.ts
Adds cva with static and theme-aware overloads, variant resolution (including boolean coercion), base/variant/compound application, optional sx merging, and CSS-variable key sanitization.
CVA variant system test coverage
packages/ui/src/mosaic/__tests__/cva.test.ts
Vitest suite validating cva behavior across base styles, variants, defaultVariants, boolean and compound variants, deep merging (including pseudo-selectors), CSS variable sanitization, theme-aware configs, handling of unknown/null props, and TypeScript VariantProps inference.
Button component example
packages/ui/src/mosaic/Button.tsx
Reference Button using buttonStyles from cva, reads theme via useMosaicTheme(), applies computed css, and forwards native button props and ref.
Mosaic architecture documentation
references/mosaic-architecture.md
Documentation covering token model, resolveVariables, provider delivery via context, cva design and typing, component authoring pattern, coexistence rules with Emotion theming, and migration steps.
Documentation reference
AGENTS.md
Adds a reference link to references/mosaic-architecture.md in the References section.
Release changeset
.changeset/mosaic-design-system-foundations.md
Adds a minor-release changeset describing the Mosaic foundations and the new UI primitives.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Suggested reviewers

  • jacekradko

Poem

🐰 Mosaic hops in with tokens bright and keen,
cva stitches styles where variants convene,
Provider hums themes into context's nest,
Buttons wear tokens, tests ensure the rest,
A rabbit applauds the interface scene!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title 'feat(ui): Add mosaic design systems foundations' accurately and clearly summarizes the primary change: introducing the foundational pieces of a new Mosaic design system including tokens, provider, utilities, and a reference component.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 5, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8755

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8755

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8755

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8755

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8755

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8755

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8755

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8755

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8755

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8755

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8755

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8755

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8755

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8755

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8755

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8755

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8755

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8755

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8755

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8755

commit: eb0dc28

Comment thread.changeset/mosaic-design-system-foundations.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-09T13:58:49.434Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

Note
Break Check could not snapshot 3 subpaths; the diff below excludes them.

  • @clerk/astro ./env: Internal Error: Unable to determine module for: /home/runner/_work/javascript/javascript/packages/astro/env.d.ts You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/shared ./cookie: Internal Error: Unable to follow symbol for "Cookies" You have encountered a software defect. Please consider reporting the issue to the maintainers of this application.
  • @clerk/testing ./cypress: Symbol not found for identifier: Cypress

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on eb0dc28.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@alexcarpenter@wobsoriano