Uh oh!
There was an error while loading. Please reload this page.
ci(e2e): upload staging Playwright JSON report from integration/ - #8766
Merged
Conversation
The json reporter's outputFile resolves relative to the Playwright config directory (integration/), not the repo root, so the report is written to integration/playwright-report/results.json. The upload step read playwright-report/results.json from the repo root and, with if-no-files-found: ignore, silently produced no artifact on every leg. Point the upload at the real path and switch to warn so a future regression is visible.
🦋 Changeset detectedLatest commit: fc87400 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Wondering what really moved? Review this PR in Change Stack to inspect semantic changes, definitions, and references. 📝 WalkthroughWalkthroughStaging E2E workflow and Turbo tasks were updated so Playwright’s JSON report lives under ChangesCI integration report and turbo outputs
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
tmilewski
approved these changes
Jun 5, 2026
Even with the upload path fixed, the report artifact was still empty: the staging legs are turbo-cacheable keyed on integration/** + env, not on the live staging deploy, so a verification dispatch with unchanged integration code hit '>>> FULL TURBO' and never ran Playwright (no report written). More broadly, a cached green pass can stand in for a new, untested staging deploy. Set TURBO_FORCE on the staging test step so the legs always execute, and declare the report as a turbo output on the integration test tasks so non-staging e2e cache hits restore it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The staging E2E workflow has never produced its JSON report artifact, on any leg. Two things were in the way.
First, a path bug: Playwright resolves a reporter's
outputFilerelative to the config directory (integration/), so the report lands atintegration/playwright-report/results.json, while the upload step looked for it at the repo root. Withif-no-files-found: ignorethe mismatch produced nothing and said nothing. That's the path fix, plus a switch towarn.The bigger one is caching, which is also why a first verification run came back empty even with the path fixed. The staging legs are turbo-cacheable keyed on
integration/**plus env, and that key doesn't include the live staging deploy they exist to validate. So a run with unchanged integration code hits>>> FULL TURBO, replays an old pass, and never runs Playwright (no report written).TURBO_FORCEon the test step makes the staging legs always execute, which is the behavior you want for per-deploy validation regardless of the report. Declaringintegration/playwright-report/**as a task output then lets non-staging e2e restore the report on its own cache hits.Worth landing ahead of the #8760 reporting work, since that classifier is the thing that consumes these reports.
Summary by CodeRabbit