Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 469
feat(headless): add Tabs, Tooltip, Popover, Select, Menu, Autocomplete, Collapsible primitives#8790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
feat(headless): add Tabs, Tooltip, Popover, Select, Menu, Autocomplete, Collapsible primitives #8790
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
aa845cd
feat(headless): add Tabs, Tooltip, Popover, Select, Menu, Autocomplet…
alexcarpenter a4ef08f
cleanup
alexcarpenter 9766b87
fix(headless): keep tabs indicator in sync on resize via ResizeObserver
alexcarpenter 906f575
fix(headless): address review feedback on new primitives
alexcarpenter fd7ad0a
fix(headless): forward refs through all primitive parts for React 18
alexcarpenter f710ae9
fix(headless): address automated review and PR feedback
alexcarpenter fe27e11
test(headless): add regression test for selectedIndex on filtered-opt…
alexcarpenter 5e17cd8
chore(repo): dedupe pnpm lockfile
alexcarpenter d4e892c
fix(headless): fix lint errors in test-utils type declaration files
alexcarpenter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,236 @@ | ||
| import { cleanup, render, screen } from '@testing-library/react'; | ||
| import userEvent from '@testing-library/user-event'; | ||
| import { afterEach, describe, expect, it } from 'vitest'; | ||
| import { Dialog } from '../primitives/dialog/index'; | ||
| import { Popover } from '../primitives/popover/index'; | ||
| import { Select } from '../primitives/select/index'; | ||
| import { Tooltip } from '../primitives/tooltip/index'; | ||
| afterEach(() => { | ||
| cleanup(); | ||
| }); | ||
| const fruits = [ | ||
| { value: 'apple', label: 'Apple' }, | ||
| { value: 'banana', label: 'Banana' }, | ||
| { value: 'cherry', label: 'Cherry' }, | ||
| ]; | ||
| describe('FloatingTree integration', () => { | ||
| describe('Select inside Popover', () => { | ||
| function SelectInPopover() { | ||
| return ( | ||
| <Popover.Root> | ||
| <Popover.Trigger>Open Popover</Popover.Trigger> | ||
| <Popover.Positioner> | ||
| <Popover.Popup> | ||
| <Popover.Title>Pick a fruit</Popover.Title> | ||
| <Select.Root> | ||
| <Select.Trigger> | ||
| <Select.Value placeholder='Choose...' /> | ||
| </Select.Trigger> | ||
| <Select.Positioner> | ||
| <Select.Popup> | ||
| {fruits.map(f => ( | ||
| <Select.Option | ||
| key={f.value} | ||
| value={f.value} | ||
| label={f.label} | ||
| > | ||
| {f.label} | ||
| </Select.Option> | ||
| ))} | ||
| </Select.Popup> | ||
| </Select.Positioner> | ||
| </Select.Root> | ||
| </Popover.Popup> | ||
| </Popover.Positioner> | ||
| </Popover.Root> | ||
| ); | ||
| } | ||
| it('popover stays open when select dropdown opens', async () => { | ||
| const user = userEvent.setup(); | ||
| render(<SelectInPopover />); | ||
| await user.click(screen.getByText('Open Popover')); | ||
| expect(screen.getByText('Pick a fruit')).toBeInTheDocument(); | ||
| await user.click(screen.getByText('Choose...')); | ||
| // Popover should still be open | ||
| expect(screen.getByText('Pick a fruit')).toBeInTheDocument(); | ||
| // Select dropdown should be visible | ||
| expect(screen.getByText('Apple')).toBeInTheDocument(); | ||
| }); | ||
| it('popover stays open when clicking select option', async () => { | ||
| const user = userEvent.setup(); | ||
| render(<SelectInPopover />); | ||
| await user.click(screen.getByText('Open Popover')); | ||
| await user.click(screen.getByText('Choose...')); | ||
| await user.click(screen.getByText('Banana')); | ||
| // Popover should still be open after selecting | ||
| expect(screen.getByText('Pick a fruit')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| describe('Select inside Dialog', () => { | ||
| function SelectInDialog() { | ||
| return ( | ||
| <Dialog.Root> | ||
| <Dialog.Trigger>Open Dialog</Dialog.Trigger> | ||
| <Dialog.Backdrop> | ||
| <Dialog.Popup> | ||
| <Dialog.Title>Select a fruit</Dialog.Title> | ||
| <Select.Root> | ||
| <Select.Trigger> | ||
| <Select.Value placeholder='Choose...' /> | ||
| </Select.Trigger> | ||
| <Select.Positioner> | ||
| <Select.Popup> | ||
| {fruits.map(f => ( | ||
| <Select.Option | ||
| key={f.value} | ||
| value={f.value} | ||
| label={f.label} | ||
| > | ||
| {f.label} | ||
| </Select.Option> | ||
| ))} | ||
| </Select.Popup> | ||
| </Select.Positioner> | ||
| </Select.Root> | ||
| </Dialog.Popup> | ||
| </Dialog.Backdrop> | ||
| </Dialog.Root> | ||
| ); | ||
| } | ||
| it('dialog stays open when select dropdown opens', async () => { | ||
| const user = userEvent.setup(); | ||
| render(<SelectInDialog />); | ||
| await user.click(screen.getByText('Open Dialog')); | ||
| expect(screen.getByText('Select a fruit')).toBeInTheDocument(); | ||
| await user.click(screen.getByText('Choose...')); | ||
| // Dialog should still be open | ||
| expect(screen.getByText('Select a fruit')).toBeInTheDocument(); | ||
| // Select options visible | ||
| expect(screen.getByText('Apple')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| describe('Popover inside Popover', () => { | ||
| function NestedPopover() { | ||
| return ( | ||
| <Popover.Root> | ||
| <Popover.Trigger>Outer</Popover.Trigger> | ||
| <Popover.Positioner> | ||
| <Popover.Popup> | ||
| <Popover.Title>Outer Content</Popover.Title> | ||
| <Popover.Root> | ||
| <Popover.Trigger>Inner</Popover.Trigger> | ||
| <Popover.Positioner> | ||
| <Popover.Popup> | ||
| <Popover.Title>Inner Content</Popover.Title> | ||
| </Popover.Popup> | ||
| </Popover.Positioner> | ||
| </Popover.Root> | ||
| </Popover.Popup> | ||
| </Popover.Positioner> | ||
| </Popover.Root> | ||
| ); | ||
| } | ||
| it('outer popover stays open when inner popover opens', async () => { | ||
| const user = userEvent.setup(); | ||
| render(<NestedPopover />); | ||
| await user.click(screen.getByText('Outer')); | ||
| expect(screen.getByText('Outer Content')).toBeInTheDocument(); | ||
| await user.click(screen.getByText('Inner')); | ||
| // Both should be visible | ||
| expect(screen.getByText('Outer Content')).toBeInTheDocument(); | ||
| expect(screen.getByText('Inner Content')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| describe('Tooltip inside Popover', () => { | ||
| function TooltipInPopover() { | ||
| return ( | ||
| <Popover.Root> | ||
| <Popover.Trigger>Open Popover</Popover.Trigger> | ||
| <Popover.Positioner> | ||
| <Popover.Popup> | ||
| <Popover.Title>Content</Popover.Title> | ||
| <Tooltip.Root> | ||
| <Tooltip.Trigger>Hover me</Tooltip.Trigger> | ||
| <Tooltip.Positioner> | ||
| <Tooltip.Popup>Tooltip text</Tooltip.Popup> | ||
| </Tooltip.Positioner> | ||
| </Tooltip.Root> | ||
| </Popover.Popup> | ||
| </Popover.Positioner> | ||
| </Popover.Root> | ||
| ); | ||
| } | ||
| it('popover stays open when tooltip trigger is hovered', async () => { | ||
| const user = userEvent.setup(); | ||
| render(<TooltipInPopover />); | ||
| await user.click(screen.getByText('Open Popover')); | ||
| expect(screen.getByText('Content')).toBeInTheDocument(); | ||
| await user.hover(screen.getByText('Hover me')); | ||
| // Popover should remain open | ||
| expect(screen.getByText('Content')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| describe('Popover inside Dialog', () => { | ||
| function PopoverInDialog() { | ||
| return ( | ||
| <Dialog.Root> | ||
| <Dialog.Trigger>Open Dialog</Dialog.Trigger> | ||
| <Dialog.Backdrop> | ||
| <Dialog.Popup> | ||
| <Dialog.Title>Dialog Content</Dialog.Title> | ||
| <Popover.Root> | ||
| <Popover.Trigger>Open Popover</Popover.Trigger> | ||
| <Popover.Positioner> | ||
| <Popover.Popup> | ||
| <Popover.Title>Popover Content</Popover.Title> | ||
| </Popover.Popup> | ||
| </Popover.Positioner> | ||
| </Popover.Root> | ||
| </Dialog.Popup> | ||
| </Dialog.Backdrop> | ||
| </Dialog.Root> | ||
| ); | ||
| } | ||
| it('dialog stays open when popover opens inside it', async () => { | ||
| const user = userEvent.setup(); | ||
| render(<PopoverInDialog />); | ||
| await user.click(screen.getByText('Open Dialog')); | ||
| expect(screen.getByText('Dialog Content')).toBeInTheDocument(); | ||
| await user.click(screen.getByText('Open Popover')); | ||
| // Both should be visible | ||
| expect(screen.getByText('Dialog Content')).toBeInTheDocument(); | ||
| expect(screen.getByText('Popover Content')).toBeInTheDocument(); | ||
| }); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.