Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(ui): `inert` attribute for React 18/19 compatibility by alexcarpenter · Pull Request #8820 · clerk/javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): `inert` attribute for React 18/19 compatibility by alexcarpenter · Pull Request #8820 · clerk/javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): `inert` attribute for React 18/19 compatibility by alexcarpenter · Pull Request #8820 · clerk/javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(ui): `inert` attribute for React 18/19 compatibility by alexcarpenter · Pull Request #8820 · clerk/javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): `inert` attribute for React 18/19 compatibility by alexcarpenter · Pull Request #8820 · clerk/javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(ui): `inert` attribute for React 18/19 compatibility by alexcarpenter · Pull Request #8820 · clerk/javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix(ui): `inert` attribute for React 18/19 compatibility by alexcarpenter · Pull Request #8820 · clerk/javascript · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-inert-react-19-compat.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/ui": patch
---

Add support for the `inert` attribute usage under React 19. Inert content is now correctly non-interactive on both React 18 and 19.
5 changes: 5 additions & 0 deletions .changeset/shared-inert-props-helper.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@clerk/shared": patch
---

Add an `inertProps` helper (`@clerk/shared/inert`) that resolves the correct `inert` attribute value for the consumer's React major (React 19 dropped the `inert` attribute for falsy string values).
1 change: 1 addition & 0 deletions packages/headless/package.json
Original file line numberDiff line numberDiff line change
Expand Up@@ -58,6 +58,7 @@
"typecheck": "tsc --noEmit"
},
"dependencies": {
"@clerk/shared": "workspace:^",
"@floating-ui/react": "catalog:repo"
},
"devDependencies": {
Expand Down
13 changes: 2 additions & 11 deletions packages/headless/src/primitives/tabs/tabs-panel.tsx
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,13 @@
'use client';

import { inertProps } from '@clerk/shared/inert';
import { useMergeRefs } from '@floating-ui/react';
import React, { useRef, version } from 'react';
import React, { useRef } from 'react';

import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';

const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}

export interface TabsPanelProps extends ComponentProps<'div'> {
value: string;
/** When true, removes `hidden` so the panel stays in layout flow. */
Expand Down
24 changes: 24 additions & 0 deletions packages/headless/src/primitives/tabs/tabs.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -506,6 +506,30 @@ describe('Tabs', () => {
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"][data-cl-hidden]');
expect(panels).toHaveLength(2);
});

it('non-selected panels have inert attribute, selected panel does not', () => {
renderTabs();
const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const inert = Array.from(panels).filter(p => p.hasAttribute('inert'));
const notInert = Array.from(panels).filter(p => !p.hasAttribute('inert'));
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(inert).toHaveLength(2);
expect(notInert).toHaveLength(1);
});

it('inert updates when selection changes', async () => {
const user = userEvent.setup();
renderTabs();

await user.click(screen.getByText('Settings'));

const panels = document.querySelectorAll('[data-cl-slot="tabs-panel"]');
const [account, settings, billing] = Array.from(panels);
expect(account).toHaveAttribute('inert');
expect(settings).not.toHaveAttribute('inert');
expect(billing).toHaveAttribute('inert');
});
});

describe('roving tabindex', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/headless/vite.config.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -31,7 +31,7 @@ export default defineConfig({
formats: ['es'],
},
rollupOptions: {
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react'],
external: ['react', 'react-dom', 'react/jsx-runtime', '@floating-ui/react', /^@clerk\/shared(\/.*)?$/],
// Preserve module-level directives such as `'use client'`. Rollup otherwise
// strips them when bundling (emitting a warning), which would drop the
// client boundary for React Server Component consumers of the primitives.
Expand Down
29 changes: 29 additions & 0 deletions packages/shared/src/inert.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
import { version } from 'react';

// React 19 turned `inert` into a real boolean attribute, so a falsy value like `''`
// is no longer reflected to the DOM. React 18 doesn't know `inert` and only serializes
// a (non-undefined) string value. Resolve the consumer's React major once at module
// load — `react` is a peer dependency, so this reads the same copy the component renders
// with — and emit the value that major actually reflects.
//
// `parseInt` handles prerelease strings like `19.0.0-rc-...`. Experimental builds report
// `0.0.0-experimental-...` (major 0) but ship React 19 behavior, so treat 0 as modern too.
const major = parseInt(version, 10);
const isModernReact = major >= 19 || major === 0;

/**
* Returns props to spread onto an element to apply (or omit) the `inert` attribute
* correctly across React 18 and 19.
*
* Typed as `Record<string, unknown>` on purpose: React 18's types reject `inert` and
* React 19's type it as `boolean`, so an untyped spread sidesteps both type-level shapes
* regardless of which `@types/react` a consumer compiles against.
*
* @param active - Whether the element should be inert.
*/
export function inertProps(active: boolean): Record<string, unknown> {
if (!active) {
return {};
}
return { inert: isModernReact ? true : '' };
}
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import type { BillingPlanResource, BillingSubscriptionPlanPeriod } from '@clerk/shared/types';
import * as React from 'react';

Expand DownExpand Up@@ -265,8 +266,7 @@ export function PricingTableMatrix({
}),
feePeriodNoticeAnimation,
]}
// @ts-ignore - Needed until React 19 support
inert={planPeriod !== 'annual' ? 'true' : undefined}
{...inertProps(planPeriod !== 'annual')}
>
<Box
elementDescriptor={descriptors.pricingTableMatrixFeePeriodNoticeInner}
Expand Down
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { useUser } from '@clerk/shared/react';
// eslint-disable-next-line no-restricted-imports
import { css } from '@emotion/react';
Expand DownExpand Up@@ -506,7 +507,7 @@ function KeylessPromptInternal(props: KeylessPromptProps) {
</button>
<div
id={id}
{...(!isOpen && { inert: '' as any })}
{...inertProps(!isOpen)}
css={css`
${CSS_RESET};
display: grid;
Expand Down
4 changes: 2 additions & 2 deletions packages/ui/src/elements/Collapsible.tsx
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
import { inertProps } from '@clerk/shared/inert';
import { type PropsWithChildren, useEffect, useState } from 'react';

import { Box, descriptors, useAppearance } from '../customizables';
Expand DownExpand Up@@ -75,8 +76,7 @@ export function Collapsible({ open, children, sx }: CollapsibleProps): JSX.Eleme
}),
sx,
]}
// @ts-ignore - inert not yet in React types
inert={!open ? '' : undefined}
{...inertProps(!open)}
>
<Box
elementDescriptor={descriptors.collapsibleInner}
Expand Down
6 changes: 4 additions & 2 deletions packages/ui/src/elements/__tests__/Collapsible.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -367,15 +367,17 @@ describe('Collapsible', () => {
});

describe('Inert Attribute', () => {
it('sets inert to empty string when open={false}', async () => {
it('sets inert when open={false}', async () => {
const { wrapper } = await createFixtures();
const { container, rerender } = render(<Collapsible open>Content</Collapsible>, { wrapper });

await waitForAnimationFrame();
rerender(<Collapsible open={false}>Content</Collapsible>);

const element = container.querySelector('.cl-collapsible') as HTMLElement;
expect(element).toHaveAttribute('inert', '');
// Presence check only — `inertProps` emits the value each React major reflects
// (string '' on 18, boolean true on 19), both of which serialize to inert="".
expect(element).toHaveAttribute('inert');
});

it('does not set inert when open={true}', async () => {
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading