Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 470
feat(swingset): proptable badges, inline variables reset, folder source links#8822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| --- | ||
| --- | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| import { mergeProps } from '@base-ui/react/merge-props'; | ||
| import { useRender } from '@base-ui/react/use-render'; | ||
| import { cva, type VariantProps } from 'class-variance-authority'; | ||
| import { cn } from '@/lib/utils'; | ||
| const badgeVariants = cva( | ||
| 'group/badge inline-flex h-5 w-fit shrink-0 items-center justify-center gap-1 overflow-hidden rounded-4xl border border-transparent px-2 py-0.5 text-xs font-medium whitespace-nowrap transition-all focus-visible:border-ring focus-visible:ring-[3px] focus-visible:ring-ring/50 has-data-[icon=inline-end]:pr-1.5 has-data-[icon=inline-start]:pl-1.5 aria-invalid:border-destructive aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 [&>svg]:pointer-events-none [&>svg]:size-3!', | ||
| { | ||
| variants: { | ||
| variant: { | ||
| default: 'bg-primary text-primary-foreground [a]:hover:bg-primary/80', | ||
| secondary: 'bg-secondary text-secondary-foreground [a]:hover:bg-secondary/80', | ||
| destructive: | ||
| 'bg-destructive/10 text-destructive focus-visible:ring-destructive/20 dark:bg-destructive/20 dark:focus-visible:ring-destructive/40 [a]:hover:bg-destructive/20', | ||
| outline: 'border-border text-foreground [a]:hover:bg-muted [a]:hover:text-muted-foreground', | ||
| ghost: 'hover:bg-muted hover:text-muted-foreground dark:hover:bg-muted/50', | ||
| link: 'text-primary underline-offset-4 hover:underline', | ||
| }, | ||
| }, | ||
| defaultVariants: { | ||
| variant: 'default', | ||
| }, | ||
| }, | ||
| ); | ||
| function Badge({ | ||
| className, | ||
| variant = 'default', | ||
| render, | ||
| ...props | ||
| }: useRender.ComponentProps<'span'> & VariantProps<typeof badgeVariants>) { | ||
| return useRender({ | ||
| defaultTagName: 'span', | ||
| props: mergeProps<'span'>( | ||
| { | ||
| className: cn(badgeVariants({ variant }), className), | ||
| }, | ||
| props, | ||
| ), | ||
| render, | ||
| state: { | ||
| slot: 'badge', | ||
| variant, | ||
| }, | ||
| }); | ||
| } | ||
| export { Badge, badgeVariants }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,16 @@ | ||
| // The repo these components are documented from. `source` paths in `StoryMeta` are | ||
| // relative to the monorepo root and resolved against this base on the default branch. | ||
| const REPO_BLOB_BASE = 'https://github.com/clerk/javascript/blob/main'; | ||
| const REPO_BASE = 'https://github.com/clerk/javascript'; | ||
| const BRANCH = 'main'; | ||
| /** Build a GitHub URL to the file that exports a component, from a repo-root-relative path. */ | ||
| /** | ||
| * Build a GitHub URL from a repo-root-relative path. Index/barrel files (`index.ts`, | ||
| * `index.tsx`, …) resolve to their containing folder as a `tree` view — the folder of | ||
| * source files is more useful than the re-export file. Any other path links straight | ||
| * to the file as a `blob` view. | ||
| */ | ||
| export function sourceUrl(path: string): string { | ||
| return `${REPO_BLOB_BASE}/${path.replace(/^\/+/, '')}`; | ||
| const clean = path.replace(/^\/+/, ''); | ||
| const folder = clean.match(/^(.*)\/index\.[jt]sx?$/)?.[1]; | ||
| return folder ? `${REPO_BASE}/tree/${BRANCH}/${folder}` : `${REPO_BASE}/blob/${BRANCH}/${clean}`; | ||
| } |
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: clerk/javascript
Length of output: 133
Remove/fill the empty changeset for private
@clerk/swingset@clerk/swingsetis marked"private": true, so it doesn’t need a version-bump/changelog entry. The file.changeset/swingset-proptable-badges.mdis currently just---(lines 1-2); either delete it or add real content if some internal tooling relies on it.🤖 Prompt for AI Agents
Source: Learnings