Uh oh!
There was an error while loading. Please reload this page.
feat(testing): log response diagnostics when FAPI retries are exhausted - #8848
Conversation
🦋 Changeset detectedLatest commit: 31b8867 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Repository UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThis PR enhances the ChangesRetry Exhaustion Diagnostics
🎯 2 (Simple) | ⏱️ ~12 minutes
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
@clerk/astro@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/expo@clerk/expo-passkeys@clerk/express@clerk/fastify@clerk/hono@clerk/localizations@clerk/nextjs@clerk/nuxt@clerk/react@clerk/react-router@clerk/shared@clerk/tanstack-react-start@clerk/testing@clerk/ui@clerk/upgrade@clerk/vuecommit: |
API Changes Report
Summary
No API Changes DetectedAll packages have stable APIs with no detected changes. Report generated by Break Check Last ran on |
When the
setupClerkTestingTokenretry helper exhausts its retries on a 429/5xx, the warning now includes thecf-ray,retry-after, andcontent-typeheaders plus the first 500 chars of the response body. A Clerk JSON error body means FAPI's app-level limiter; a Cloudflare error page means an edge rule, and the cf-ray is the direct lookup key for which one. The network-error give-up path now folds the error into the same single warning line.Motivated by staging E2E run 27401231903, where a 429 storm on
attempt_first_factorfailed the generic leg and the log gave us no way to tell which side produced the 429s. Diagnostics are gathered best-effort so a failed body read can never prevent the response from being fulfilled.Summary by CodeRabbit
Bug Fixes
Tests