Skip to content

fix(expo): Preserve platform-specific imports in tsdown builds - #8865

Merged
wobsoriano merged 3 commits into
mainfrom
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged

fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

Conversation

@wobsoriano

@wobsorianowobsoriano commented Jun 15, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Description

Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).

With tsup, bundleless CJS output preserved extensionless internal imports (ref):

require("../hooks/useSignInWithApple")

After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):

require("../hooks/useSignInWithApple.js")

That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.

This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.

The alternative would be reverting @clerk/expo to tsup

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Summary by CodeRabbit

  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.

@changeset-bot

changeset-botBot commented Jun 15, 2026•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8a58e59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 15, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 15, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f

📥 Commits

Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.

📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough

Walkthrough

A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.

Changes

Expo Platform Specifier Resolution

Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested labels

testing

Suggested reviewers

  • jacekradko
  • dstaley

Poem

🐇 Hop, hop through the build tree,
Metro needs its .ios to see!
A plugin now peeks at each sibling file,
Externalizes imports in bundleless style.
No more tangled native vs. web—
The rabbit wired it right, every spec! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Comment @coderabbitai help to get the list of available commands and usage tips.

wobsoriano
wobsoriano commented Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
outDir: './dist',
entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,

@wobsorianowobsorianoJun 15, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated

@pkg-pr-new

pkg-pr-newBot commented Jun 15, 2026•
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59

coderabbitai[bot]
coderabbitaiBot reviewed Jun 15, 2026
View reviewed changes

@coderabbitaicoderabbitaiBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Repository UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28

📥 Commits

Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.

📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts

Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts Outdated
@github-actions

github-actionsBot commented Jun 15, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-15T20:43:02.132Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on 8a58e59.

@wobsoriano
wobsoriano requested a review from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano merged commit a148899 into mainJun 15, 2026
49 checks passed
@wobsoriano
wobsoriano deleted the rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow branch June 15, 2026 21:07
@clerk-cookieclerk-cookie mentioned this pull request Jun 15, 2026
Merged
@coderabbitaicoderabbitaiBot mentioned this pull request Jun 16, 2026
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments
+1 more reviewer
@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

expo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(expo): Preserve platform-specific imports in tsdown builds by wobsoriano · Pull Request #8865 · clerk/javascript · GitHub
Skip to content
fix(expo): Preserve platform-specific imports in tsdown builds - #8865
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged
fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 15, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).
With tsup, bundleless CJS output preserved extensionless internal imports (ref):
require("../hooks/useSignInWithApple")
After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):
require("../hooks/useSignInWithApple.js")
That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.
This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.
The alternative would be reverting @clerk/expo to tsup
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.
@changeset-bot
changeset-botBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8a58e59
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f
📥 Commits
Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.
📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough
Walkthrough
A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.
Changes
Expo Platform Specifier Resolution
Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
testing
Suggested reviewers
  • jacekradko
  • dstaley
Poem
🐇 Hop, hop through the build tree,

Metro needs its .ios to see!

A plugin now peeks at each sibling file,

Externalizes imports in bundleless style.

No more tangled native vs. web—

The rabbit wired it right, every spec! ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands and usage tips.
wobsoriano
wobsoriano
commented
Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
 outDir: './dist',
 entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,
@wobsorianowobsorianoJun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated
@pkg-pr-new
pkg-pr-newBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 15, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28
📥 Commits
Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.
📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts
Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts
Outdated

@github-actions
github-actionsBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-15T20:43:02.132Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 8a58e59.
@wobsoriano
wobsoriano
requested a review
from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano
merged commit a148899
into
mainJun 15, 2026

49 checks passed

@wobsoriano
wobsoriano
deleted the

rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

branch
June 15, 2026 21:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 15, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 16, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): Preserve platform-specific imports in tsdown builds by wobsoriano · Pull Request #8865 · clerk/javascript · GitHub
Skip to content
fix(expo): Preserve platform-specific imports in tsdown builds - #8865
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged
fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 15, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).
With tsup, bundleless CJS output preserved extensionless internal imports (ref):
require("../hooks/useSignInWithApple")
After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):
require("../hooks/useSignInWithApple.js")
That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.
This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.
The alternative would be reverting @clerk/expo to tsup
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.
@changeset-bot
changeset-botBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8a58e59
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f
📥 Commits
Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.
📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough
Walkthrough
A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.
Changes
Expo Platform Specifier Resolution
Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
testing
Suggested reviewers
  • jacekradko
  • dstaley
Poem
🐇 Hop, hop through the build tree,

Metro needs its .ios to see!

A plugin now peeks at each sibling file,

Externalizes imports in bundleless style.

No more tangled native vs. web—

The rabbit wired it right, every spec! ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands and usage tips.
wobsoriano
wobsoriano
commented
Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
 outDir: './dist',
 entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,
@wobsorianowobsorianoJun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated
@pkg-pr-new
pkg-pr-newBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 15, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28
📥 Commits
Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.
📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts
Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts
Outdated

@github-actions
github-actionsBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-15T20:43:02.132Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 8a58e59.
@wobsoriano
wobsoriano
requested a review
from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano
merged commit a148899
into
mainJun 15, 2026

49 checks passed

@wobsoriano
wobsoriano
deleted the

rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

branch
June 15, 2026 21:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 15, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 16, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): Preserve platform-specific imports in tsdown builds by wobsoriano · Pull Request #8865 · clerk/javascript · GitHub
Skip to content
fix(expo): Preserve platform-specific imports in tsdown builds - #8865
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged
fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 15, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).
With tsup, bundleless CJS output preserved extensionless internal imports (ref):
require("../hooks/useSignInWithApple")
After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):
require("../hooks/useSignInWithApple.js")
That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.
This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.
The alternative would be reverting @clerk/expo to tsup
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.
@changeset-bot
changeset-botBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8a58e59
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f
📥 Commits
Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.
📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough
Walkthrough
A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.
Changes
Expo Platform Specifier Resolution
Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
testing
Suggested reviewers
  • jacekradko
  • dstaley
Poem
🐇 Hop, hop through the build tree,

Metro needs its .ios to see!

A plugin now peeks at each sibling file,

Externalizes imports in bundleless style.

No more tangled native vs. web—

The rabbit wired it right, every spec! ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands and usage tips.
wobsoriano
wobsoriano
commented
Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
 outDir: './dist',
 entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,
@wobsorianowobsorianoJun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated
@pkg-pr-new
pkg-pr-newBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 15, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28
📥 Commits
Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.
📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts
Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts
Outdated

@github-actions
github-actionsBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-15T20:43:02.132Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 8a58e59.
@wobsoriano
wobsoriano
requested a review
from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano
merged commit a148899
into
mainJun 15, 2026

49 checks passed

@wobsoriano
wobsoriano
deleted the

rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

branch
June 15, 2026 21:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 15, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 16, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(expo): Preserve platform-specific imports in tsdown builds by wobsoriano · Pull Request #8865 · clerk/javascript · GitHub
Skip to content
fix(expo): Preserve platform-specific imports in tsdown builds - #8865
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged
fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 15, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).
With tsup, bundleless CJS output preserved extensionless internal imports (ref):
require("../hooks/useSignInWithApple")
After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):
require("../hooks/useSignInWithApple.js")
That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.
This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.
The alternative would be reverting @clerk/expo to tsup
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.
@changeset-bot
changeset-botBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8a58e59
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f
📥 Commits
Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.
📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough
Walkthrough
A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.
Changes
Expo Platform Specifier Resolution
Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
testing
Suggested reviewers
  • jacekradko
  • dstaley
Poem
🐇 Hop, hop through the build tree,

Metro needs its .ios to see!

A plugin now peeks at each sibling file,

Externalizes imports in bundleless style.

No more tangled native vs. web—

The rabbit wired it right, every spec! ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands and usage tips.
wobsoriano
wobsoriano
commented
Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
 outDir: './dist',
 entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,
@wobsorianowobsorianoJun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated
@pkg-pr-new
pkg-pr-newBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 15, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28
📥 Commits
Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.
📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts
Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts
Outdated

@github-actions
github-actionsBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-15T20:43:02.132Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 8a58e59.
@wobsoriano
wobsoriano
requested a review
from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano
merged commit a148899
into
mainJun 15, 2026

49 checks passed

@wobsoriano
wobsoriano
deleted the

rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

branch
June 15, 2026 21:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 15, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 16, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): Preserve platform-specific imports in tsdown builds by wobsoriano · Pull Request #8865 · clerk/javascript · GitHub
Skip to content
fix(expo): Preserve platform-specific imports in tsdown builds - #8865
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged
fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 15, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).
With tsup, bundleless CJS output preserved extensionless internal imports (ref):
require("../hooks/useSignInWithApple")
After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):
require("../hooks/useSignInWithApple.js")
That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.
This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.
The alternative would be reverting @clerk/expo to tsup
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.
@changeset-bot
changeset-botBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8a58e59
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f
📥 Commits
Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.
📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough
Walkthrough
A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.
Changes
Expo Platform Specifier Resolution
Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
testing
Suggested reviewers
  • jacekradko
  • dstaley
Poem
🐇 Hop, hop through the build tree,

Metro needs its .ios to see!

A plugin now peeks at each sibling file,

Externalizes imports in bundleless style.

No more tangled native vs. web—

The rabbit wired it right, every spec! ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands and usage tips.
wobsoriano
wobsoriano
commented
Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
 outDir: './dist',
 entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,
@wobsorianowobsorianoJun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated
@pkg-pr-new
pkg-pr-newBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 15, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28
📥 Commits
Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.
📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts
Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts
Outdated

@github-actions
github-actionsBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-15T20:43:02.132Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 8a58e59.
@wobsoriano
wobsoriano
requested a review
from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano
merged commit a148899
into
mainJun 15, 2026

49 checks passed

@wobsoriano
wobsoriano
deleted the

rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

branch
June 15, 2026 21:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 15, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 16, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): Preserve platform-specific imports in tsdown builds by wobsoriano · Pull Request #8865 · clerk/javascript · GitHub
Skip to content
fix(expo): Preserve platform-specific imports in tsdown builds - #8865
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged
fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 15, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).
With tsup, bundleless CJS output preserved extensionless internal imports (ref):
require("../hooks/useSignInWithApple")
After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):
require("../hooks/useSignInWithApple.js")
That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.
This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.
The alternative would be reverting @clerk/expo to tsup
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.
@changeset-bot
changeset-botBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8a58e59
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f
📥 Commits
Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.
📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough
Walkthrough
A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.
Changes
Expo Platform Specifier Resolution
Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
testing
Suggested reviewers
  • jacekradko
  • dstaley
Poem
🐇 Hop, hop through the build tree,

Metro needs its .ios to see!

A plugin now peeks at each sibling file,

Externalizes imports in bundleless style.

No more tangled native vs. web—

The rabbit wired it right, every spec! ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands and usage tips.
wobsoriano
wobsoriano
commented
Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
 outDir: './dist',
 entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,
@wobsorianowobsorianoJun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated
@pkg-pr-new
pkg-pr-newBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 15, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28
📥 Commits
Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.
📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts
Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts
Outdated

@github-actions
github-actionsBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-15T20:43:02.132Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 8a58e59.
@wobsoriano
wobsoriano
requested a review
from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano
merged commit a148899
into
mainJun 15, 2026

49 checks passed

@wobsoriano
wobsoriano
deleted the

rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

branch
June 15, 2026 21:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 15, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 16, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(expo): Preserve platform-specific imports in tsdown builds by wobsoriano · Pull Request #8865 · clerk/javascript · GitHub
Skip to content
fix(expo): Preserve platform-specific imports in tsdown builds - #8865
Merged
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Jun 15, 2026
Merged
fix(expo): Preserve platform-specific imports in tsdown builds#8865
wobsoriano merged 3 commits into
mainfrom 
rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow
Conversation
@wobsoriano
@wobsorianowobsoriano
commented
Jun 15, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Description
Fixes Expo platform-specific module resolution regression introduced by the tsup to tsdown migration (ref).
With tsup, bundleless CJS output preserved extensionless internal imports (ref):
require("../hooks/useSignInWithApple")
After the tsdown migration, Rolldown's preserveModules output rewrites those imports to emitted filenames (ref):
require("../hooks/useSignInWithApple.js")
That bypasses Metro's platform-specific resolution (ref), which needs the extensionless specifier so it can select files like useSignInWithApple.ios.js, NativeClerkModule.web.js, etc.
This PR keeps the tsdown build and adds an Expo-local Rolldown plugin that preserves only the relative imports whose resolved source has platform-specific siblings. Normal internal imports still point at emitted .js chunks.
The alternative would be reverting @clerk/expo to tsup
Checklist
  • pnpm test runs as expected.
  • pnpm build runs as expected.
  •  (If applicable) JSDoc comments have been added or updated for any package exports
  •  (If applicable) Documentation has been updated
Type of change
  •  🐛 Bug fix
  •  🌟 New feature
  •  🔨 Breaking change
  •  📖 Refactoring / dependency upgrade / documentation
  •  other:
Summary by CodeRabbit
  • Bug Fixes
    • Fixed platform-specific module resolution during Expo builds to ensure correct native vs web implementations are selected.
@changeset-bot
changeset-botBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 8a58e59
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@vercel
vercelBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 15, 2026 8:41pm
swingsetReadyReadyPreview, CommentJun 15, 2026 8:41pm
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 8d402b7e-23c5-453f-ab1f-3f5307bf254f
📥 Commits
Reviewing files that changed from the base of the PR and between b2ab1eb and 8a58e59.
📒 Files selected for processing (2)
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
🚧 Files skipped from review as they are similar to previous changes (2)
  • packages/expo/scripts/tests/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
📝 Walkthrough
Walkthrough
A new Rolldown plugin preservePlatformSpecifiers is added to @clerk/expo's tsdown build scripts. It intercepts relative imports during bundleless builds, checks for platform-specific file siblings (.ios, .android, .web, .native), and externalizes matching imports so Metro's platform resolver receives extensionless specifiers. The plugin is registered in tsdown.config.mts with unbundle: true, and a Vitest suite validates all three resolution paths.
Changes
Expo Platform Specifier Resolution
Layer / File(s)Summary
preservePlatformSpecifiers plugin implementation
packages/expo/scripts/preservePlatformSpecifiers.mts		Defines platform suffixes (ios, android, web, native) and source extensions (.ts, .tsx, .js, .jsx) as constants. Adds hasPlatformSuffix and hasPlatformSibling helpers, then implements the resolveId hook that externalizes extensionless relative imports whose resolved file has a platform-specific sibling on disk.
tsdown config wiring and changeset
packages/expo/tsdown.config.mts, .changeset/expo-platform-imports.md		Imports and registers preservePlatformSpecifiers() as a plugin in tsdown options; switches bundle: false to unbundle: true. Adds a patch changeset entry for @clerk/expo.
Vitest test suite
packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts		Creates temp-directory fixture files with afterEach cleanup. Tests three cases: extensionless specifier with platform sibling is externalized; missing sibling returns null; already-platform-suffixed and already-extensioned specifiers are not processed.
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Suggested labels
testing
Suggested reviewers
  • jacekradko
  • dstaley
Poem
🐇 Hop, hop through the build tree,

Metro needs its .ios to see!

A plugin now peeks at each sibling file,

Externalizes imports in bundleless style.

No more tangled native vs. web—

The rabbit wired it right, every spec! ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 warning)
Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 20.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Title check✅ PassedThe title clearly and concisely describes the primary fix: preserving platform-specific imports in tsdown builds, which directly addresses the main changeset focused on implementing the preservePlatformSpecifiers plugin.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Comment @coderabbitai help to get the list of available commands and usage tips.
wobsoriano
wobsoriano
commented
Jun 15, 2026
View reviewed changes
Comment threadpackages/expo/tsdown.config.mts
 outDir: './dist',
 entry: ['./src/**/*.{ts,tsx,js,jsx}', '!./src/**/*.test.{ts,tsx}', '!./src/**/__tests__/**'],
bundle: false,
unbundle: true,
@wobsorianowobsorianoJun 15, 2026

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle is deprecated
@pkg-pr-new
pkg-pr-newBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Open in StackBlitz
@clerk/astro
npm i https://pkg.pr.new/@clerk/astro@8865

@clerk/backend
npm i https://pkg.pr.new/@clerk/backend@8865

@clerk/chrome-extension
npm i https://pkg.pr.new/@clerk/chrome-extension@8865

@clerk/clerk-js
npm i https://pkg.pr.new/@clerk/clerk-js@8865

@clerk/expo
npm i https://pkg.pr.new/@clerk/expo@8865

@clerk/expo-passkeys
npm i https://pkg.pr.new/@clerk/expo-passkeys@8865

@clerk/express
npm i https://pkg.pr.new/@clerk/express@8865

@clerk/fastify
npm i https://pkg.pr.new/@clerk/fastify@8865

@clerk/hono
npm i https://pkg.pr.new/@clerk/hono@8865

@clerk/localizations
npm i https://pkg.pr.new/@clerk/localizations@8865

@clerk/nextjs
npm i https://pkg.pr.new/@clerk/nextjs@8865

@clerk/nuxt
npm i https://pkg.pr.new/@clerk/nuxt@8865

@clerk/react
npm i https://pkg.pr.new/@clerk/react@8865

@clerk/react-router
npm i https://pkg.pr.new/@clerk/react-router@8865

@clerk/shared
npm i https://pkg.pr.new/@clerk/shared@8865

@clerk/tanstack-react-start
npm i https://pkg.pr.new/@clerk/tanstack-react-start@8865

@clerk/testing
npm i https://pkg.pr.new/@clerk/testing@8865

@clerk/ui
npm i https://pkg.pr.new/@clerk/ui@8865

@clerk/upgrade
npm i https://pkg.pr.new/@clerk/upgrade@8865

@clerk/vue
npm i https://pkg.pr.new/@clerk/vue@8865

commit: 8a58e59
coderabbitai[bot]
coderabbitaiBot
reviewed
Jun 15, 2026
View reviewed changes
@coderabbitaicoderabbitaiBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/expo/scripts/preservePlatformSpecifiers.mts`:
- Around line 45-55: The guard condition at line 45 does not reject sources with
explicit file extensions (like .js or .ts), allowing extensioned imports such as
./foo.js to pass through and be externalized at line 55 when platform siblings
exist. This violates the plugin's constraint to only handle extensionless
imports. Add a check to the condition at line 45 that rejects any source with an
explicit file extension (by detecting a dot followed by an extension pattern) so
only truly extensionless imports like ./foo can be processed.

🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
  •  Push a commit to this branch (recommended)
  •  Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Repository UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: f29cc734-d2aa-4659-b83a-4266bcf20a28
📥 Commits
Reviewing files that changed from the base of the PR and between ed2cf75 and b2ab1eb.
📒 Files selected for processing (4)
  • .changeset/expo-platform-imports.md
  • packages/expo/scripts/__tests__/preservePlatformSpecifiers.test.ts
  • packages/expo/scripts/preservePlatformSpecifiers.mts
  • packages/expo/tsdown.config.mts
Comment threadpackages/expo/scripts/preservePlatformSpecifiers.mts
Outdated

@github-actions
github-actionsBot
commented
Jun 15, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-15T20:43:02.132Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 8a58e59.
@wobsoriano
wobsoriano
requested a review
from a teamJune 15, 2026 20:31
@wobsoriano
wobsoriano
merged commit a148899
into
mainJun 15, 2026

49 checks passed

@wobsoriano
wobsoriano
deleted the

rob/mobile-553-apple-sign-in-fails-in-expo-custom-flow

branch
June 15, 2026 21:07
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 15, 2026
 Merged

@coderabbitaicoderabbitaiBot
mentioned this pull request
Jun 16, 2026
 Merged

9 tasks
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@coderabbitaicoderabbitai[bot]coderabbitai[bot] left review comments

+1 more reviewer

@jacekradkojacekradkojacekradko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano@jacekradko