Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
feat(expo): send host SDK headers from iOS by mikepitre · Pull Request #8883 · clerk/javascript · GitHub
Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(expo): send host SDK headers from iOS by mikepitre · Pull Request #8883 · clerk/javascript · GitHub
Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(expo): send host SDK headers from iOS by mikepitre · Pull Request #8883 · clerk/javascript · GitHub
Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' feat(expo): send host SDK headers from iOS by mikepitre · Pull Request #8883 · clerk/javascript · GitHub
Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(expo): send host SDK headers from iOS by mikepitre · Pull Request #8883 · clerk/javascript · GitHub
Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' feat(expo): send host SDK headers from iOS by mikepitre · Pull Request #8883 · clerk/javascript · GitHub
Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); feat(expo): send host SDK headers from iOS by mikepitre · Pull Request #8883 · clerk/javascript · GitHub
Skip to content

feat(expo): send host SDK headers from iOS - #8883

Merged
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers
Jun 17, 2026
Merged

feat(expo): send host SDK headers from iOS#8883
wobsoriano merged 3 commits into
mainfrom
mike/expo-ios-host-sdk-headers

Conversation

@mikepitre

@mikepitremikepitre commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds iOS-only host SDK request headers for native Clerk SDK requests made through @clerk/expo:

  • x-clerk-host-sdk: expo
  • x-clerk-host-sdk-version: <@clerk/expo package version>

This also adds a patch changeset for @clerk/expo.

Reasoning

@clerk/expo already identifies Expo on the JavaScript-side FAPI client, but requests from the embedded clerk-ios SDK did not have an equivalent host-SDK signal. Since clerk-ios already supports request middleware, Expo can add these headers in the generated iOS bridge without changing the iOS SDK API or adding new Expo-facing configuration.

Approach

  • Adds a small ClerkRequestMiddleware to the app-target ClerkNativeBridge.swift.
  • Keeps the source Swift file version-agnostic with a __CLERK_EXPO_VERSION__ placeholder.
  • Replaces that placeholder from the Expo config plugin when the bridge is copied into the generated iOS app target, using the installed @clerk/expo package version.
  • Adds dedicated app-plugin test coverage for version injection in appPlugin.injectClerkExpoVersion.test.js.
  • Adds a patch changeset describing the published @clerk/expo behavior change.

Tradeoffs

This is intentionally iOS-only for now. It avoids adding an Expo-level custom header API and relies on the native SDK extension point that already exists on iOS. Android parity will follow once the Android SDK-side work is done: clerk/clerk-android#729

The version is injected at prebuild time instead of hardcoded into Swift source so published packages report their own installed version and the bridge source does not need manual updates for every release.

Testing

  • pnpm --filter @clerk/expo format:check
  • pnpm --dir packages/expo exec vitest run src/__tests__/appPlugin.injectClerkExpoVersion.test.js
  • git diff --check
  • Smoke-tested with NativeComponentQuickstart on iOS Simulator after expo prebuild --clean --platform ios; verified the generated app-target bridge contains the two headers with version 3.4.3.

Note: local commands emit the existing Node engine warning because this shell is on Node 22.12.0 while the repo expects >=24.15.0.

Summary by CodeRabbit

  • New Features

    • Enhanced iOS native requests by adding Expo host SDK identification headers that automatically include the SDK version, improving diagnostics and request tracking.
  • Tests

    • Added test coverage for SDK version injection functionality.

@changeset-bot

changeset-botBot commented Jun 16, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03a2ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 16, 2026 6:21pm
swingsetReadyReadyPreview, CommentJun 16, 2026 6:21pm

Request Review

@coderabbitai

coderabbitaiBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a ClerkExpoHeaderMiddleware Swift struct to ClerkNativeBridge.swift that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing requests. The Expo config plugin is updated to read its own package.json, replace a __CLERK_EXPO_VERSION__ placeholder in the Swift file during installation, and expose the helper for testing.

Changes

SDK version header injection

Layer / File(s)Summary
ClerkExpoHeaderMiddleware and makeClerkOptions wiring
packages/expo/ios/ClerkNativeBridge.swift
Adds a private ClerkExpoHeaderMiddleware that appends x-clerk-host-sdk and x-clerk-host-sdk-version headers to outgoing URLRequests. makeClerkOptions() is updated to wrap this middleware in Clerk.Options.MiddlewareConfig for both keychain and non-keychain paths.
Config plugin version placeholder substitution
packages/expo/app.plugin.js
Reads package.json to resolve the current version, defines __CLERK_EXPO_VERSION__ as a placeholder constant, and introduces injectClerkExpoVersion(source, version) to substitute it. The ClerkNativeBridge.swift installation step changes from copyFileSync to a read-inject-write flow. injectClerkExpoVersion is added to _testing exports.
Version injection test and changeset
packages/expo/src/__tests__/appPlugin.injectClerkExpoVersion.test.js, .changeset/tall-rockets-jog.md
Adds a Vitest suite asserting placeholder replacement in both header-value and variable-assignment contexts. Includes the patch changeset for @clerk/expo.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop, hop through the Swift bridge I go,
Tucking my version in headers below.
The plugin reads JSON, stamps the right name,
x-clerk-host-sdk — middleware, my fame!
No more unknown callers, the server will know,
It's Expo the rabbit putting on a show! 🌟

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately describes the main change: adding host SDK request headers from the iOS native bridge in the Expo package.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-newBot commented Jun 16, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8883

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8883

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8883

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8883

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8883

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8883

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8883

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8883

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8883

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8883

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8883

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8883

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8883

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8883

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8883

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8883

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8883

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8883

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8883

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8883

commit: fe79d97

@github-actions

github-actionsBot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-16T18:22:05.874Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fe79d97.

@wobsoriano
wobsoriano merged commit c6127bc into mainJun 17, 2026
53 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-ios-host-sdk-headers branch June 17, 2026 13:34
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano