Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran a full org-wide sweep of
docsUrl/OAUTH_PROVIDERSconsumers (in-repo +gh search code --owner clerk), and there is the one spot worth a second look — everything appears safe.clerk/clireadsOAUTH_PROVIDERS[].docsUrlbut defensively (?.docsUrl ?? fallback), and the in-repo UI consumers only read.strategy/.provider/.name, never.docsUrl, so we're good here.The tricky one is
clerk/dashboard. ItsgetSocialSettings.tsimportsOAUTH_PROVIDERSfrom@clerk/shared/oauthand readsitem.docsUrlwith a name-based fallback:Then, it renders that as the provider's docs link on the SSO connection page.
With
docsUrlgone, Enstall falls through to…/guides/configure/auth-strategies/social-connections/enstall, which currently 404s — whereas the URL being removed here 308-redirects to the live social-connections overview (via the redirect added in clerk-docs#3391). So on the Enstall-enabled instance, this swaps a working (redirected) link for a hard 404 on the surface that actually renders it.Since the dashboard is what surfaces this link, should we pair this with a dashboard change that drops the link when
docsUrlis absent (or skips the fallback for private providers), or add a clerk-docs redirect for the new…/auth-strategies/social-connections/enstallpath so the fallback resolves?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! Made a sibling
dashboardPR. @manovotny