Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/headless-measurement-gaps.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
---
---
41 changes: 38 additions & 3 deletions packages/headless/src/primitives/accordion/accordion-panel.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useAccordionItemContext } from './accordion-context';

export type AccordionPanelProps = ComponentProps<'div'>;
Expand All@@ -27,11 +29,13 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

// Measure the content height and keep it in sync via ResizeObserver
useLayoutEffect(() => {
if (!mounted) {
Expand All@@ -43,8 +47,12 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
return;
}

// Measure scrollHeight of the panel's content
// Measure scrollHeight of the panel's content. Reset flex/grid alignment
// first so non-default alignment can't shrink the reported height.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
};

Expand All@@ -54,9 +62,36 @@ export const AccordionPanel = React.forwardRef<HTMLDivElement, AccordionPanelPro
// Observe children mutations that affect height
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel height so the
// panel flows naturally with its content (CSS var omitted → height: auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => setHeight(undefined));
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to a measured pixel value when closing starts so the exit
// transition animates from a concrete height (height: auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

// Skip enter animation for panels that have never been closed
Expand Down
26 changes: 23 additions & 3 deletions packages/headless/src/primitives/accordion/accordion.test.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -209,11 +209,31 @@ describe('Accordion', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --cl-accordion-panel-height CSS variable on panel', () => {
it('pins --cl-accordion-panel-height while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the var) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned height once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel height so it
// flows naturally with its content.
renderAccordion({ defaultValue: ['item1'] });
const panel = document.querySelector('[data-cl-slot="accordion-panel"]') as HTMLElement;
// Verify the CSS variable is present in the style attribute
expect(panel.getAttribute('style')).toContain('--cl-accordion-panel-height');
expect(panel.getAttribute('style') ?? '').not.toContain('--cl-accordion-panel-height');
});
});

Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,8 +3,10 @@
import { useMergeRefs } from '@floating-ui/react';
import React, { type RefObject, useLayoutEffect, useRef, useState } from 'react';

import { useAnimationsFinished } from '../../hooks/use-animations-finished';
import { useTransition } from '../../hooks/use-transition';
import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { resetLayoutStyles } from '../../utils/reset-layout-styles';
import { useCollapsibleContext } from './collapsible-context';

export type CollapsiblePanelProps = ComponentProps<'div'>;
Expand All@@ -26,11 +28,13 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
hasBeenClosed.current = true;
}

const { mounted, transitionProps } = useTransition({
const { mounted, transitionStatus, transitionProps } = useTransition({
open,
ref: panelRef as RefObject<HTMLElement>,
});

const runOnAnimationsFinished = useAnimationsFinished(panelRef, open);

useLayoutEffect(() => {
if (!mounted) {
return;
Expand All@@ -41,7 +45,12 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
return;
}

// Reset flex/grid alignment before measuring so non-default alignment
// can't shrink the reported scroll dimensions.
let restoreLayoutStyles: (() => void) | undefined;
const measure = () => {
restoreLayoutStyles?.();
restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
};
Expand All@@ -51,9 +60,40 @@ export const CollapsiblePanel = React.forwardRef<HTMLDivElement, CollapsiblePane
const ro = new ResizeObserver(measure);
ro.observe(panel, { box: 'border-box' });

return () => ro.disconnect();
return () => {
ro.disconnect();
restoreLayoutStyles?.();
};
}, [mounted]);

// Once the open animation settles, drop the measured pixel dimensions so the
// panel flows naturally with its content (CSS vars omitted → auto).
useLayoutEffect(() => {
if (!open || !mounted) {
return;
}
runOnAnimationsFinished(() => {
setHeight(undefined);
setWidth(undefined);
});
}, [open, mounted, runOnAnimationsFinished]);

// Re-pin to measured pixel values when closing starts so the exit
// transition animates from concrete dimensions (auto can't interpolate).
useLayoutEffect(() => {
if (open || transitionStatus !== 'ending') {
return;
}
const panel = panelRef.current;
if (!panel) {
return;
}
const restoreLayoutStyles = resetLayoutStyles(panel);
setHeight(panel.scrollHeight);
setWidth(panel.scrollWidth);
return restoreLayoutStyles;
}, [open, transitionStatus]);

const state = { open };

const effectiveTransitionProps = !hasBeenClosed.current
Expand Down
Original file line numberDiff line numberDiff line change
Expand Up@@ -157,16 +157,34 @@ describe('Collapsible', () => {
expect(panel).not.toHaveAttribute('data-cl-starting-style');
});

it('sets --collapsible-panel-height CSS variable on panel', () => {
it('pins --collapsible-panel-height/width while the open animation is in progress', () => {
// Keep an animation pending so the idle reset (which clears the vars) holds off.
const original = (Element.prototype as { getAnimations?: unknown }).getAnimations;
(Element.prototype as { getAnimations?: unknown }).getAnimations = () => [
{ finished: new Promise<void>(() => {}) },
];
try {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
} finally {
if (original) {
(Element.prototype as { getAnimations?: unknown }).getAnimations = original;
} else {
delete (Element.prototype as { getAnimations?: unknown }).getAnimations;
}
}
});

it('clears the pinned dimensions once the panel settles open (flows at auto)', () => {
// With no running animations the panel drops the measured pixel dimensions so
// it flows naturally with its content.
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-height');
});

it('sets --collapsible-panel-width CSS variable on panel', () => {
renderCollapsible({ defaultOpen: true });
const panel = document.querySelector('[data-cl-slot="collapsible-panel"]') as HTMLElement;
expect(panel.getAttribute('style')).toContain('--collapsible-panel-width');
const style = panel.getAttribute('style') ?? '';
expect(style).not.toContain('--collapsible-panel-height');
expect(style).not.toContain('--collapsible-panel-width');
});
});

Expand Down
6 changes: 5 additions & 1 deletion packages/headless/src/primitives/tabs/tabs-context.ts
Original file line numberDiff line numberDiff line change
Expand Up@@ -8,7 +8,11 @@ export interface TabsContextValue {
tabsId: string;
registerTab: (value: string, element: HTMLElement | null) => void;
getTabElement: (value: string) => HTMLElement | null;
listRef: React.RefObject<HTMLElement>;
// The list element is tracked as state (not a ref) so the indicator, a child,
// re-renders once the list mounts. A child's layout effect runs before its
// parent's ref is attached, so a plain ref would read null on first measure.
listElement: HTMLElement | null;
setListElement: (element: HTMLElement | null) => void;
direction: 1 | -1;
}

Expand Down
12 changes: 7 additions & 5 deletions packages/headless/src/primitives/tabs/tabs-indicator.tsx
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
'use client';

import type React from 'react';
import { useEffect, useRef, useState } from 'react';
import { useLayoutEffect, useRef, useState } from 'react';

import { type ComponentProps, mergeProps, renderElement } from '../../utils/render-element';
import { useTabsContext } from './tabs-context';
Expand All@@ -10,7 +10,7 @@ export type TabsIndicatorProps = ComponentProps<'span'>;

export function TabsIndicator(props: TabsIndicatorProps) {
const { render, ...otherProps } = props;
const { value, getTabElement, orientation, listRef } = useTabsContext();
const { value, getTabElement, orientation, listElement } = useTabsContext();

const [style, setStyle] = useState<React.CSSProperties>({});
const previousRectRef = useRef<{
Expand All@@ -20,9 +20,11 @@ export function TabsIndicator(props: TabsIndicatorProps) {
height: number;
} | null>(null);

useEffect(() => {
// Measure synchronously before paint so the indicator never commits a frame
// at a stale position when the active tab changes.
useLayoutEffect(() => {
const el = getTabElement(value);
const list = listRef.current;
const list = listElement;
if (!el || !list) {
return;
}
Expand DownExpand Up@@ -64,7 +66,7 @@ export function TabsIndicator(props: TabsIndicatorProps) {
ro.observe(el);
ro.observe(list);
return () => ro.disconnect();
}, [value, getTabElement, orientation, listRef]);
}, [value, getTabElement, orientation, listElement]);

const defaultProps = {
'data-cl-slot': 'tabs-indicator',
Expand Down
4 changes: 2 additions & 2 deletions packages/headless/src/primitives/tabs/tabs-list.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,11 +10,11 @@ export type TabsListProps = ComponentProps<'div'>;

export function TabsList(props: TabsListProps) {
const { render, children, ...otherProps } = props;
const { orientation, listRef } = useTabsContext();
const { orientation, setListElement } = useTabsContext();

return (
<Composite
ref={listRef}
ref={setListElement}
orientation={orientation}
render={(compositeProps: React.HTMLAttributes<HTMLElement>) => {
const defaultProps: Record<string, unknown> = {
Expand Down
7 changes: 4 additions & 3 deletions packages/headless/src/primitives/tabs/tabs-root.tsx
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,7 +23,7 @@ export function TabsRoot(props: TabsProps) {
const tabsId = useId();
const tabElementsRef = useRef<Map<string, HTMLElement>>(new Map());
const tabOrderRef = useRef<string[]>([]);
const listRef = useRef<HTMLElement>(null);
const [listElement, setListElement] = useState<HTMLElement | null>(null);
const valueRef = useRef(value);
valueRef.current = value;

Expand DownExpand Up@@ -64,10 +64,11 @@ export function TabsRoot(props: TabsProps) {
tabsId,
registerTab,
getTabElement,
listRef,
listElement,
setListElement,
direction,
}),
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, direction],
[value, setValue, orientation, activationMode, tabsId, registerTab, getTabElement, listElement, direction],
);

return <TabsContext.Provider value={contextValue}>{children}</TabsContext.Provider>;
Expand Down
1 change: 1 addition & 0 deletions packages/headless/src/utils/index.ts
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,3 @@
export { cssVars } from './css-vars';
export { resetLayoutStyles } from './reset-layout-styles';
export { type ComponentProps, type DefaultProps, mergeProps, type RenderProp, renderElement } from './render-element';
51 changes: 51 additions & 0 deletions packages/headless/src/utils/reset-layout-styles.ts
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
/**
* Temporarily forces flex/grid alignment properties to `initial` so the
* element's content height can be measured accurately.
*
* When a panel uses `display: flex` or `display: grid` with a non-default
* `justify-content` / `align-items` / `align-content` / `justify-items`, the
* alignment can make `scrollHeight`/`scrollWidth` report a value smaller than
* the true content size. Resetting these to `initial` before measuring avoids
* that distortion.
*
* The original inline values are restored on the next animation frame so the
* forced-initial layout never flashes. The returned cleanup cancels that
* scheduled restore and reapplies the original values immediately — call it
* from the effect cleanup so a re-run before the frame fires doesn't leak the
* forced styles.
*
* @param element - The element being measured.
* @returns A cleanup function that cancels the scheduled restore and restores
* the original inline layout styles immediately.
*/
export function resetLayoutStyles(element: HTMLElement): () => void {
// Capture the value AND its priority flag so an inline `!important` is
// restored faithfully (getPropertyValue alone would drop the priority).
const keys = ['justify-content', 'align-items', 'align-content', 'justify-items'];
const originalLayoutStyles = keys.map(key => ({
key,
value: element.style.getPropertyValue(key),
priority: element.style.getPropertyPriority(key),
}));

keys.forEach(key => {
element.style.setProperty(key, 'initial', 'important');
});

function restore() {
for (const { key, value, priority } of originalLayoutStyles) {
if (value === '') {
element.style.removeProperty(key);
continue;
}
element.style.setProperty(key, value, priority);
}
}

const frame = requestAnimationFrame(restore);

return () => {
cancelAnimationFrame(frame);
restore();
};
}
Loading