Skip to content

fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911

Merged
wobsoriano merged 1 commit into
mainfrom
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged

fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom
mike/expo-google-expomodulescore-dep

Conversation

@mikepitre

@mikepitremikepitre commented Jun 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.

Why

After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:

import ExpoModulesCore

The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.

This shows up at Xcode compile time, not during prebuild or pod install:

node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^

Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.

Validation

I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.

Without this change:

  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn

With this change:

  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro

Also ran:

  • pnpm --filter @clerk/expo format:check
  • git diff --check

Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.

@vercel

vercelBot commented Jun 18, 2026•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am

Request Review

@coderabbitai

coderabbitaiBot commented Jun 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.

Changes

iOS podspec dependency fix

Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop hop, a pod was lost,
ExpoModulesCore had a hidden cost.
One line added, the build turns green,
The cleanest fix that I have seen.
Patch it up and ship with glee! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mikepitre
mikepitreforce-pushed the mike/expo-google-expomodulescore-dep branch from 4736874 to 9d32c83CompareJune 18, 2026 02:34
@changeset-bot

changeset-botBot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9d32c83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@clerk/expoPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mikepitre
mikepitre marked this pull request as draft June 18, 2026 02:35
@github-actions

github-actionsBot commented Jun 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T03:02:34.289Z

Summary

MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0

No API Changes Detected

All packages have stable APIs with no detected changes.

Report generated by Break Check

Last ran on 9d32c83.

@mikepitre
mikepitre marked this pull request as ready for review June 18, 2026 02:44
@mikepitre
mikepitre marked this pull request as draft June 18, 2026 02:59
@mikepitre
mikepitre marked this pull request as ready for review June 18, 2026 02:59
@wobsoriano
wobsoriano merged commit 0850fce into mainJun 18, 2026
117 of 120 checks passed
@wobsoriano
wobsoriano deleted the mike/expo-google-expomodulescore-dep branch June 18, 2026 10:01
@clerk-cookieclerk-cookie mentioned this pull request Jun 18, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees

No one assigned

Labels

expo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(expo): declare Google Sign-In ExpoModulesCore dependency by mikepitre · Pull Request #8911 · clerk/javascript · GitHub
Skip to content
fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911
Merged
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Conversation
@mikepitre
@mikepitremikepitre
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.
Why
After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:
import ExpoModulesCore
The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.
This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^
Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.
Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.
Without this change:
  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn
With this change:
  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro
Also ran:
  • pnpm --filter @clerk/expo format:check
  • git diff --check
Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.
@vercel
vercelBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.
Changes
iOS podspec dependency fix
Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.
Suggested reviewers
  • wobsoriano
Poem
🐇 Hop hop, a pod was lost,

ExpoModulesCore had a hidden cost.

One line added, the build turns green,

The cleanest fix that I have seen.

Patch it up and ship with glee! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@mikepitre
mikepitreforce-pushed
the
mike/expo-google-expomodulescore-dep
branch
from
4736874 to
9d32c83CompareJune 18, 2026 02:34
@changeset-bot
changeset-botBot
commented
Jun 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 9d32c83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:35
@github-actions
github-actionsBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-18T03:02:34.289Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 9d32c83.
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:44
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:59
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:59
@wobsoriano
wobsoriano
merged commit 0850fce
into
mainJun 18, 2026

117 of 120 checks passed

@wobsoriano
wobsoriano
deleted the

mike/expo-google-expomodulescore-dep

branch
June 18, 2026 10:01
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 18, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): declare Google Sign-In ExpoModulesCore dependency by mikepitre · Pull Request #8911 · clerk/javascript · GitHub
Skip to content
fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911
Merged
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Conversation
@mikepitre
@mikepitremikepitre
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.
Why
After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:
import ExpoModulesCore
The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.
This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^
Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.
Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.
Without this change:
  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn
With this change:
  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro
Also ran:
  • pnpm --filter @clerk/expo format:check
  • git diff --check
Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.
@vercel
vercelBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.
Changes
iOS podspec dependency fix
Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.
Suggested reviewers
  • wobsoriano
Poem
🐇 Hop hop, a pod was lost,

ExpoModulesCore had a hidden cost.

One line added, the build turns green,

The cleanest fix that I have seen.

Patch it up and ship with glee! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@mikepitre
mikepitreforce-pushed
the
mike/expo-google-expomodulescore-dep
branch
from
4736874 to
9d32c83CompareJune 18, 2026 02:34
@changeset-bot
changeset-botBot
commented
Jun 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 9d32c83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:35
@github-actions
github-actionsBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-18T03:02:34.289Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 9d32c83.
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:44
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:59
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:59
@wobsoriano
wobsoriano
merged commit 0850fce
into
mainJun 18, 2026

117 of 120 checks passed

@wobsoriano
wobsoriano
deleted the

mike/expo-google-expomodulescore-dep

branch
June 18, 2026 10:01
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 18, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): declare Google Sign-In ExpoModulesCore dependency by mikepitre · Pull Request #8911 · clerk/javascript · GitHub
Skip to content
fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911
Merged
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Conversation
@mikepitre
@mikepitremikepitre
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.
Why
After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:
import ExpoModulesCore
The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.
This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^
Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.
Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.
Without this change:
  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn
With this change:
  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro
Also ran:
  • pnpm --filter @clerk/expo format:check
  • git diff --check
Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.
@vercel
vercelBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.
Changes
iOS podspec dependency fix
Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.
Suggested reviewers
  • wobsoriano
Poem
🐇 Hop hop, a pod was lost,

ExpoModulesCore had a hidden cost.

One line added, the build turns green,

The cleanest fix that I have seen.

Patch it up and ship with glee! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@mikepitre
mikepitreforce-pushed
the
mike/expo-google-expomodulescore-dep
branch
from
4736874 to
9d32c83CompareJune 18, 2026 02:34
@changeset-bot
changeset-botBot
commented
Jun 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 9d32c83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:35
@github-actions
github-actionsBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-18T03:02:34.289Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 9d32c83.
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:44
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:59
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:59
@wobsoriano
wobsoriano
merged commit 0850fce
into
mainJun 18, 2026

117 of 120 checks passed

@wobsoriano
wobsoriano
deleted the

mike/expo-google-expomodulescore-dep

branch
June 18, 2026 10:01
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 18, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
fix(expo): declare Google Sign-In ExpoModulesCore dependency by mikepitre · Pull Request #8911 · clerk/javascript · GitHub
Skip to content
fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911
Merged
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Conversation
@mikepitre
@mikepitremikepitre
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.
Why
After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:
import ExpoModulesCore
The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.
This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^
Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.
Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.
Without this change:
  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn
With this change:
  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro
Also ran:
  • pnpm --filter @clerk/expo format:check
  • git diff --check
Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.
@vercel
vercelBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.
Changes
iOS podspec dependency fix
Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.
Suggested reviewers
  • wobsoriano
Poem
🐇 Hop hop, a pod was lost,

ExpoModulesCore had a hidden cost.

One line added, the build turns green,

The cleanest fix that I have seen.

Patch it up and ship with glee! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@mikepitre
mikepitreforce-pushed
the
mike/expo-google-expomodulescore-dep
branch
from
4736874 to
9d32c83CompareJune 18, 2026 02:34
@changeset-bot
changeset-botBot
commented
Jun 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 9d32c83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:35
@github-actions
github-actionsBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-18T03:02:34.289Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 9d32c83.
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:44
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:59
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:59
@wobsoriano
wobsoriano
merged commit 0850fce
into
mainJun 18, 2026

117 of 120 checks passed

@wobsoriano
wobsoriano
deleted the

mike/expo-google-expomodulescore-dep

branch
June 18, 2026 10:01
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 18, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): declare Google Sign-In ExpoModulesCore dependency by mikepitre · Pull Request #8911 · clerk/javascript · GitHub
Skip to content
fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911
Merged
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Conversation
@mikepitre
@mikepitremikepitre
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.
Why
After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:
import ExpoModulesCore
The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.
This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^
Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.
Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.
Without this change:
  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn
With this change:
  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro
Also ran:
  • pnpm --filter @clerk/expo format:check
  • git diff --check
Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.
@vercel
vercelBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.
Changes
iOS podspec dependency fix
Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.
Suggested reviewers
  • wobsoriano
Poem
🐇 Hop hop, a pod was lost,

ExpoModulesCore had a hidden cost.

One line added, the build turns green,

The cleanest fix that I have seen.

Patch it up and ship with glee! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@mikepitre
mikepitreforce-pushed
the
mike/expo-google-expomodulescore-dep
branch
from
4736874 to
9d32c83CompareJune 18, 2026 02:34
@changeset-bot
changeset-botBot
commented
Jun 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 9d32c83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:35
@github-actions
github-actionsBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-18T03:02:34.289Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 9d32c83.
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:44
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:59
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:59
@wobsoriano
wobsoriano
merged commit 0850fce
into
mainJun 18, 2026

117 of 120 checks passed

@wobsoriano
wobsoriano
deleted the

mike/expo-google-expomodulescore-dep

branch
June 18, 2026 10:01
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 18, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
fix(expo): declare Google Sign-In ExpoModulesCore dependency by mikepitre · Pull Request #8911 · clerk/javascript · GitHub
Skip to content
fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911
Merged
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Conversation
@mikepitre
@mikepitremikepitre
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.
Why
After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:
import ExpoModulesCore
The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.
This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^
Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.
Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.
Without this change:
  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn
With this change:
  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro
Also ran:
  • pnpm --filter @clerk/expo format:check
  • git diff --check
Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.
@vercel
vercelBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.
Changes
iOS podspec dependency fix
Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.
Suggested reviewers
  • wobsoriano
Poem
🐇 Hop hop, a pod was lost,

ExpoModulesCore had a hidden cost.

One line added, the build turns green,

The cleanest fix that I have seen.

Patch it up and ship with glee! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@mikepitre
mikepitreforce-pushed
the
mike/expo-google-expomodulescore-dep
branch
from
4736874 to
9d32c83CompareJune 18, 2026 02:34
@changeset-bot
changeset-botBot
commented
Jun 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 9d32c83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:35
@github-actions
github-actionsBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-18T03:02:34.289Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 9d32c83.
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:44
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:59
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:59
@wobsoriano
wobsoriano
merged commit 0850fce
into
mainJun 18, 2026

117 of 120 checks passed

@wobsoriano
wobsoriano
deleted the

mike/expo-google-expomodulescore-dep

branch
June 18, 2026 10:01
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 18, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
fix(expo): declare Google Sign-In ExpoModulesCore dependency by mikepitre · Pull Request #8911 · clerk/javascript · GitHub
Skip to content
fix(expo): declare Google Sign-In ExpoModulesCore dependency - #8911
Merged
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged
fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom 
mike/expo-google-expomodulescore-dep
Conversation
@mikepitre
@mikepitremikepitre
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Summary
Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.
Why
After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:
import ExpoModulesCore
The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.
This shows up at Xcode compile time, not during prebuild or pod install:
node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
^
Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.
Validation
I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.
Without this change:
  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn
With this change:
  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro
Also ran:
  • pnpm --filter @clerk/expo format:check
  • git diff --check
Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.
@vercel
vercelBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.
ProjectDeploymentActionsUpdated (UTC)
clerk-js-sandboxReadyReadyPreview, CommentJun 18, 2026 2:36am
swingsetReadyReadyPreview, CommentJun 18, 2026 2:36am
Request Review
@coderabbitai
coderabbitaiBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
Review Change Stack
📝 Walkthrough
Walkthrough
ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.
Changes
iOS podspec dependency fix
Layer / File(s)Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md		ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~2 minutes
Possibly related PRs
  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.
Suggested reviewers
  • wobsoriano
Poem
🐇 Hop hop, a pod was lost,

ExpoModulesCore had a hidden cost.

One line added, the build turns green,

The cleanest fix that I have seen.

Patch it up and ship with glee! 🌿
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check nameStatusExplanation
Title check✅ PassedThe PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
📝 Generate docstrings
  •  Create stacked PR
  •  Commit on current branch
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
@mikepitre
mikepitreforce-pushed
the
mike/expo-google-expomodulescore-dep
branch
from
4736874 to
9d32c83CompareJune 18, 2026 02:34
@changeset-bot
changeset-botBot
commented
Jun 18, 2026

Copy link


Copy Markdown

🦋 Changeset detected
Latest commit: 9d32c83
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 1 package
NameType
@clerk/expoPatch
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:35
@github-actions
github-actionsBot
commented
Jun 18, 2026•

edited

Loading

Copy link


Copy Markdown

Contributor
API Changes Report
Generated by Break Check on 2026-06-18T03:02:34.289Z
Summary
MetricCount
Packages analyzed19
Packages with changes0
🔴 Breaking changes0
🟡 Non-breaking changes0
🟢 Additions0
No API Changes Detected
All packages have stable APIs with no detected changes.
Report generated by Break Check
Last ran on 9d32c83.
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:44
@mikepitre
mikepitre
marked this pull request as draft
June 18, 2026 02:59
@mikepitre
mikepitre
marked this pull request as ready for review
June 18, 2026 02:59
@wobsoriano
wobsoriano
merged commit 0850fce
into
mainJun 18, 2026

117 of 120 checks passed

@wobsoriano
wobsoriano
deleted the

mike/expo-google-expomodulescore-dep

branch
June 18, 2026 10:01
@clerk-cookieclerk-cookie
mentioned this pull request
Jun 18, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wobsorianowobsorianowobsoriano approved these changes

Assignees


No one assigned


Labels

expo

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@mikepitre@wobsoriano